* [PATCH] ktest: add ability to skip during BISECT_MANUAL
@ 2014-08-27 18:26 Chris J Arges
[not found] ` <CAMym5wtmgsAUP6C-eYgMKJcbiPCUVJ-jZW0PFtv4Mwvr3S9jdw@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Chris J Arges @ 2014-08-27 18:26 UTC (permalink / raw)
To: rostedt; +Cc: Chris J Arges, Satoru Takeuchi, linux-kernel
When doing a manual bisect, a build can fail or a test can be inconclusive.
In these cases it would be helpful to be able to skip the test entirely.
Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
---
tools/testing/ktest/ktest.pl | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 55ab700..72010f4 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -2336,15 +2336,17 @@ sub success {
sub answer_bisect {
for (;;) {
- doprint "Pass or fail? [p/f]";
+ doprint "Pass, fail, or skip? [p/f/s]";
my $ans = <STDIN>;
chomp $ans;
if ($ans eq "p" || $ans eq "P") {
return 1;
} elsif ($ans eq "f" || $ans eq "F") {
return 0;
+ } elsif ($ans eq "s" || $ans eq "S") {
+ return -1;
} else {
- print "Please answer 'P' or 'F'\n";
+ print "Please answer 'p', 'f', or 's'\n";
}
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ktest: add ability to skip during BISECT_MANUAL
[not found] ` <CAMym5wtmgsAUP6C-eYgMKJcbiPCUVJ-jZW0PFtv4Mwvr3S9jdw@mail.gmail.com>
@ 2014-08-30 13:06 ` Satoru Takeuchi
2014-09-08 17:51 ` Chris J Arges
0 siblings, 1 reply; 3+ messages in thread
From: Satoru Takeuchi @ 2014-08-30 13:06 UTC (permalink / raw)
To: Chris J Arges; +Cc: Steven Rostedt, LKML
Hi Chris,
Sorry for late reply.
2014-08-28 3:26 GMT+09:00 Chris J Arges <chris.j.arges@canonical.com>:
> When doing a manual bisect, a build can fail or a test can be inconclusive.
> In these cases it would be helpful to be able to skip the test entirely.
>
> Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
It look good to me.
Reviewed-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
Thanks,
Satoru
>
> ---
> tools/testing/ktest/ktest.pl | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
> index 55ab700..72010f4 100755
> --- a/tools/testing/ktest/ktest.pl
> +++ b/tools/testing/ktest/ktest.pl
> @@ -2336,15 +2336,17 @@ sub success {
>
> sub answer_bisect {
> for (;;) {
> - doprint "Pass or fail? [p/f]";
> + doprint "Pass, fail, or skip? [p/f/s]";
> my $ans = <STDIN>;
> chomp $ans;
> if ($ans eq "p" || $ans eq "P") {
> return 1;
> } elsif ($ans eq "f" || $ans eq "F") {
> return 0;
> + } elsif ($ans eq "s" || $ans eq "S") {
> + return -1;
> } else {
> - print "Please answer 'P' or 'F'\n";
> + print "Please answer 'p', 'f', or 's'\n";
> }
> }
> }
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ktest: add ability to skip during BISECT_MANUAL
2014-08-30 13:06 ` Satoru Takeuchi
@ 2014-09-08 17:51 ` Chris J Arges
0 siblings, 0 replies; 3+ messages in thread
From: Chris J Arges @ 2014-09-08 17:51 UTC (permalink / raw)
To: Satoru Takeuchi; +Cc: Steven Rostedt, LKML
Satoru,
Thanks for the review.
Steven,
When you have time, let me know if there are any issues with this being
applied.
--chris j arges
On 08/30/2014 08:06 AM, Satoru Takeuchi wrote:
> Hi Chris,
>
> Sorry for late reply.
>
> 2014-08-28 3:26 GMT+09:00 Chris J Arges <chris.j.arges@canonical.com>:
>
>> When doing a manual bisect, a build can fail or a test can be inconclusive.
>> In these cases it would be helpful to be able to skip the test entirely.
>>
>> Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
>
> It look good to me.
>
> Reviewed-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
>
> Thanks,
> Satoru
>
>>
>> ---
>> tools/testing/ktest/ktest.pl | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
>> index 55ab700..72010f4 100755
>> --- a/tools/testing/ktest/ktest.pl
>> +++ b/tools/testing/ktest/ktest.pl
>> @@ -2336,15 +2336,17 @@ sub success {
>>
>> sub answer_bisect {
>> for (;;) {
>> - doprint "Pass or fail? [p/f]";
>> + doprint "Pass, fail, or skip? [p/f/s]";
>> my $ans = <STDIN>;
>> chomp $ans;
>> if ($ans eq "p" || $ans eq "P") {
>> return 1;
>> } elsif ($ans eq "f" || $ans eq "F") {
>> return 0;
>> + } elsif ($ans eq "s" || $ans eq "S") {
>> + return -1;
>> } else {
>> - print "Please answer 'P' or 'F'\n";
>> + print "Please answer 'p', 'f', or 's'\n";
>> }
>> }
>> }
>> --
>> 1.9.1
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-08 17:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-27 18:26 [PATCH] ktest: add ability to skip during BISECT_MANUAL Chris J Arges
[not found] ` <CAMym5wtmgsAUP6C-eYgMKJcbiPCUVJ-jZW0PFtv4Mwvr3S9jdw@mail.gmail.com>
2014-08-30 13:06 ` Satoru Takeuchi
2014-09-08 17:51 ` Chris J Arges
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.