* [PATCH] Input: synaptics - handle spurious release of trackstick buttons, again
@ 2016-03-15 10:18 Benjamin Tissoires
2016-03-15 14:25 ` Benjamin Tissoires
2016-03-18 0:14 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2016-03-15 10:18 UTC (permalink / raw)
To: Dmitry Torokhov, Andrew Duggan, linux-input; +Cc: linux-kernel
Looks like the fimware 8.2 stall has the extra buttons spurious release
bug.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=114321
Cc: stable@vger.kernel.org
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/input/mouse/synaptics.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 6025eb4..9f3b83f 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -862,8 +862,9 @@ static void synaptics_report_ext_buttons(struct psmouse *psmouse,
if (!SYN_CAP_MULTI_BUTTON_NO(priv->ext_cap))
return;
- /* Bug in FW 8.1, buttons are reported only when ExtBit is 1 */
- if (SYN_ID_FULL(priv->identity) == 0x801 &&
+ /* Bug in FW 8.1 & 8.2, buttons are reported only when ExtBit is 1 */
+ if (((SYN_ID_FULL(priv->identity) == 0x801) ||
+ (SYN_ID_FULL(priv->identity) == 0x802)) &&
!((psmouse->packet[0] ^ psmouse->packet[3]) & 0x02))
return;
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: synaptics - handle spurious release of trackstick buttons, again
2016-03-15 10:18 [PATCH] Input: synaptics - handle spurious release of trackstick buttons, again Benjamin Tissoires
@ 2016-03-15 14:25 ` Benjamin Tissoires
2016-03-18 0:14 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2016-03-15 14:25 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Dmitry Torokhov, Andrew Duggan, linux-input, linux-kernel
On Tue, Mar 15, 2016 at 11:18 AM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> Looks like the fimware 8.2 stall has the extra buttons spurious release
Typo: *still, not stall. (sorry)
Cheers,
Benjamin
> bug.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=114321
> Cc: stable@vger.kernel.org
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> drivers/input/mouse/synaptics.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 6025eb4..9f3b83f 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -862,8 +862,9 @@ static void synaptics_report_ext_buttons(struct psmouse *psmouse,
> if (!SYN_CAP_MULTI_BUTTON_NO(priv->ext_cap))
> return;
>
> - /* Bug in FW 8.1, buttons are reported only when ExtBit is 1 */
> - if (SYN_ID_FULL(priv->identity) == 0x801 &&
> + /* Bug in FW 8.1 & 8.2, buttons are reported only when ExtBit is 1 */
> + if (((SYN_ID_FULL(priv->identity) == 0x801) ||
> + (SYN_ID_FULL(priv->identity) == 0x802)) &&
> !((psmouse->packet[0] ^ psmouse->packet[3]) & 0x02))
> return;
>
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: synaptics - handle spurious release of trackstick buttons, again
2016-03-15 10:18 [PATCH] Input: synaptics - handle spurious release of trackstick buttons, again Benjamin Tissoires
2016-03-15 14:25 ` Benjamin Tissoires
@ 2016-03-18 0:14 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2016-03-18 0:14 UTC (permalink / raw)
To: Benjamin Tissoires; +Cc: Andrew Duggan, linux-input, linux-kernel
On Tue, Mar 15, 2016 at 11:18:17AM +0100, Benjamin Tissoires wrote:
> Looks like the fimware 8.2 stall has the extra buttons spurious release
> bug.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=114321
> Cc: stable@vger.kernel.org
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Applied, thank you.
> ---
> drivers/input/mouse/synaptics.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 6025eb4..9f3b83f 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -862,8 +862,9 @@ static void synaptics_report_ext_buttons(struct psmouse *psmouse,
> if (!SYN_CAP_MULTI_BUTTON_NO(priv->ext_cap))
> return;
>
> - /* Bug in FW 8.1, buttons are reported only when ExtBit is 1 */
> - if (SYN_ID_FULL(priv->identity) == 0x801 &&
> + /* Bug in FW 8.1 & 8.2, buttons are reported only when ExtBit is 1 */
> + if (((SYN_ID_FULL(priv->identity) == 0x801) ||
> + (SYN_ID_FULL(priv->identity) == 0x802)) &&
but dropped extra parenthesis...
> !((psmouse->packet[0] ^ psmouse->packet[3]) & 0x02))
> return;
>
> --
> 2.5.0
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-18 0:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-15 10:18 [PATCH] Input: synaptics - handle spurious release of trackstick buttons, again Benjamin Tissoires
2016-03-15 14:25 ` Benjamin Tissoires
2016-03-18 0:14 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.