[PATCH 1/1] NFSv3: Ignore wcc before ctime attribute

* [PATCH 1/1] NFSv3: Ignore wcc before ctime attribute
@ 2016-04-01 20:19 Olga Kornievskaia
  2017-01-17 14:33 ` Olga Kornievskaia
  0 siblings, 1 reply; 6+ messages in thread
From: Olga Kornievskaia @ 2016-04-01 20:19 UTC (permalink / raw)
  To: Trond.Myklebust; +Cc: linux-nfs

Commit 7c2dad99d60c86ec686b3bfdcb787c450a7ea89f
"Don't let the ctime override attribute barriers" introduced a problem
of invalidating the cache when receiving in-order WRITE replies. Because
ctime is no longer checked then attributes are not updated appropriately
and then leads to mismatch of received "before" with what's stored.

Given that sending the wcc attributes is not mandatory (and linux
server doesn't), we can ignore the received "before" ctime. It fixes
the current problem and also help when we receive out-of-order WRITEs.

Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
 fs/nfs/nfs3xdr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/nfs/nfs3xdr.c b/fs/nfs/nfs3xdr.c
index 267126d..feca07f 100644
--- a/fs/nfs/nfs3xdr.c
+++ b/fs/nfs/nfs3xdr.c
@@ -732,14 +732,12 @@ static int decode_wcc_attr(struct xdr_stream *xdr, struct nfs_fattr *fattr)
 		goto out_overflow;
 
 	fattr->valid |= NFS_ATTR_FATTR_PRESIZE
-		| NFS_ATTR_FATTR_PRECHANGE
 		| NFS_ATTR_FATTR_PREMTIME
 		| NFS_ATTR_FATTR_PRECTIME;
 
 	p = xdr_decode_size3(p, &fattr->pre_size);
 	p = xdr_decode_nfstime3(p, &fattr->pre_mtime);
 	xdr_decode_nfstime3(p, &fattr->pre_ctime);
-	fattr->pre_change_attr = nfs_timespec_to_change_attr(&fattr->pre_ctime);
 
 	return 0;
 out_overflow:
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread