* [Buildroot] [PATCH] package/python-greenlet: enable as host package
@ 2021-06-23 14:52 Cyril Bur
2022-01-08 18:43 ` Romain Naour
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Cyril Bur @ 2021-06-23 14:52 UTC (permalink / raw)
To: buildroot
Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
---
package/python-greenlet/python-greenlet.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/python-greenlet/python-greenlet.mk b/package/python-greenlet/python-greenlet.mk
index 01d578a183..e90d1c0f56 100644
--- a/package/python-greenlet/python-greenlet.mk
+++ b/package/python-greenlet/python-greenlet.mk
@@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0
PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF
$(eval $(python-package))
+$(eval $(host-python-package))
--
2.32.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [Buildroot] [PATCH] package/python-greenlet: enable as host package 2021-06-23 14:52 [Buildroot] [PATCH] package/python-greenlet: enable as host package Cyril Bur @ 2022-01-08 18:43 ` Romain Naour 2022-01-08 19:03 ` Cyril Bur 2022-01-10 13:02 ` [Buildroot] [PATCH v2] " Cyril Bur 2022-01-10 14:11 ` [Buildroot] [PATCH v3] " Cyril Bur 2 siblings, 1 reply; 9+ messages in thread From: Romain Naour @ 2022-01-08 18:43 UTC (permalink / raw) To: Cyril Bur, buildroot Hello, Le 23/06/2021 à 16:52, Cyril Bur a écrit : Why? There is not package using host-python-greenlet in the tree. Best regards, Romain > Signed-off-by: Cyril Bur <cyrilbur@gmail.com> > --- > package/python-greenlet/python-greenlet.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/python-greenlet/python-greenlet.mk b/package/python-greenlet/python-greenlet.mk > index 01d578a183..e90d1c0f56 100644 > --- a/package/python-greenlet/python-greenlet.mk > +++ b/package/python-greenlet/python-greenlet.mk > @@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 > PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF > > $(eval $(python-package)) > +$(eval $(host-python-package)) > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH] package/python-greenlet: enable as host package 2022-01-08 18:43 ` Romain Naour @ 2022-01-08 19:03 ` Cyril Bur 2022-01-08 19:13 ` Romain Naour 0 siblings, 1 reply; 9+ messages in thread From: Cyril Bur @ 2022-01-08 19:03 UTC (permalink / raw) To: Romain Naour; +Cc: buildroot [-- Attachment #1.1: Type: text/plain, Size: 1102 bytes --] Hi Romain, Thanks for your interest. My employer has some custom packages which do depend on host python greenlet. I'm keen to avoid any forks (however small) of buildroot internally, it just makes life easier. Cyril On Sat, 8 Jan 2022, 18:43 Romain Naour, <romain.naour@smile.fr> wrote: > Hello, > > Le 23/06/2021 à 16:52, Cyril Bur a écrit : > > Why? > > There is not package using host-python-greenlet in the tree. > > Best regards, > Romain > > > Signed-off-by: Cyril Bur <cyrilbur@gmail.com> > > --- > > package/python-greenlet/python-greenlet.mk | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/package/python-greenlet/python-greenlet.mk > b/package/python-greenlet/python-greenlet.mk > > index 01d578a183..e90d1c0f56 100644 > > --- a/package/python-greenlet/python-greenlet.mk > > +++ b/package/python-greenlet/python-greenlet.mk > > @@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 > > PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF > > > > $(eval $(python-package)) > > +$(eval $(host-python-package)) > > > > [-- Attachment #1.2: Type: text/html, Size: 2160 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH] package/python-greenlet: enable as host package 2022-01-08 19:03 ` Cyril Bur @ 2022-01-08 19:13 ` Romain Naour 2022-01-08 19:16 ` Cyril Bur 0 siblings, 1 reply; 9+ messages in thread From: Romain Naour @ 2022-01-08 19:13 UTC (permalink / raw) To: Cyril Bur; +Cc: buildroot Hello Cyril, Le 08/01/2022 à 20:03, Cyril Bur a écrit : > Hi Romain, > > Thanks for your interest. > > My employer has some custom packages which do depend on host python > greenlet. > > I'm keen to avoid any forks (however small) of buildroot internally, it > just makes life easier. I understand. It seems there is an exception in the tree (host-python-lxml), but you have to add at least a Config.in.host: https://git.buildroot.net/buildroot/commit/?id=4f147ae0a0f940dfc7ec93af8e70b6625821d91d Also add a comment to explain why we don't have any package using it in the tree. I have marked this patch as "Changes Requested". Best regards, Romain > > Cyril > > > On Sat, 8 Jan 2022, 18:43 Romain Naour, <romain.naour@smile.fr> wrote: > >> Hello, >> >> Le 23/06/2021 à 16:52, Cyril Bur a écrit : >> >> Why? >> >> There is not package using host-python-greenlet in the tree. >> >> Best regards, >> Romain >> >>> Signed-off-by: Cyril Bur <cyrilbur@gmail.com> >>> --- >>> package/python-greenlet/python-greenlet.mk | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/package/python-greenlet/python-greenlet.mk >> b/package/python-greenlet/python-greenlet.mk >>> index 01d578a183..e90d1c0f56 100644 >>> --- a/package/python-greenlet/python-greenlet.mk >>> +++ b/package/python-greenlet/python-greenlet.mk >>> @@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 >>> PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF >>> >>> $(eval $(python-package)) >>> +$(eval $(host-python-package)) >>> >> >> > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH] package/python-greenlet: enable as host package 2022-01-08 19:13 ` Romain Naour @ 2022-01-08 19:16 ` Cyril Bur 0 siblings, 0 replies; 9+ messages in thread From: Cyril Bur @ 2022-01-08 19:16 UTC (permalink / raw) To: Romain Naour; +Cc: buildroot [-- Attachment #1.1: Type: text/plain, Size: 1876 bytes --] On Sat, 8 Jan 2022, 19:13 Romain Naour, <romain.naour@smile.fr> wrote: > Hello Cyril, > > Le 08/01/2022 à 20:03, Cyril Bur a écrit : > > Hi Romain, > > > > Thanks for your interest. > > > > My employer has some custom packages which do depend on host python > > greenlet. > > > > I'm keen to avoid any forks (however small) of buildroot internally, it > > just makes life easier. > > I understand. > > It seems there is an exception in the tree (host-python-lxml), but you > have to > add at least a Config.in.host: > Ah sorry! Yep will do. > > > https://git.buildroot.net/buildroot/commit/?id=4f147ae0a0f940dfc7ec93af8e70b6625821d91d > > Also add a comment to explain why we don't have any package using it in > the tree. > Perfect will do. Thanks, Cyril > > I have marked this patch as "Changes Requested". > > Best regards, > Romain > > > > > > Cyril > > > > > > On Sat, 8 Jan 2022, 18:43 Romain Naour, <romain.naour@smile.fr> wrote: > > > >> Hello, > >> > >> Le 23/06/2021 à 16:52, Cyril Bur a écrit : > >> > >> Why? > >> > >> There is not package using host-python-greenlet in the tree. > >> > >> Best regards, > >> Romain > >> > >>> Signed-off-by: Cyril Bur <cyrilbur@gmail.com> > >>> --- > >>> package/python-greenlet/python-greenlet.mk | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/package/python-greenlet/python-greenlet.mk > >> b/package/python-greenlet/python-greenlet.mk > >>> index 01d578a183..e90d1c0f56 100644 > >>> --- a/package/python-greenlet/python-greenlet.mk > >>> +++ b/package/python-greenlet/python-greenlet.mk > >>> @@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 > >>> PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF > >>> > >>> $(eval $(python-package)) > >>> +$(eval $(host-python-package)) > >>> > >> > >> > > > > [-- Attachment #1.2: Type: text/html, Size: 3809 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2] package/python-greenlet: enable as host package 2021-06-23 14:52 [Buildroot] [PATCH] package/python-greenlet: enable as host package Cyril Bur 2022-01-08 18:43 ` Romain Naour @ 2022-01-10 13:02 ` Cyril Bur 2022-01-10 14:07 ` Cyril Bur 2022-01-10 14:11 ` [Buildroot] [PATCH v3] " Cyril Bur 2 siblings, 1 reply; 9+ messages in thread From: Cyril Bur @ 2022-01-10 13:02 UTC (permalink / raw) To: buildroot, Romain Naour While currently there is no in-tree Buildroot package which depends on host-python-lxml, we (Adder Technology) have some proprietary modules that use it as part of their builds. I've tested python-greenlet as host package and confirmed that it builds and works correctly. Someone else might require it, so we are proposing its inclusion. Signed-off-by: Cyril Bur <cyrilbur@gmail.com> --- V2: Added Config.in.host and a better commit message package/Config.in.host | 1 + package/python-greenlet/Config.in.host | 7 +++++++ package/python-greenlet/python-greenlet.mk | 1 + 3 files changed, 9 insertions(+) create mode 100644 package/python-greenlet/Config.in.host diff --git a/package/Config.in.host b/package/Config.in.host index b3e00bb482..6e027d96c2 100644 --- a/package/Config.in.host +++ b/package/Config.in.host @@ -69,6 +69,7 @@ menu "Host utilities" source "package/pwgen/Config.in.host" source "package/python/Config.in.host" source "package/python-cython/Config.in.host" + source "package/python-greenlet/Config.in.host" source "package/python-lxml/Config.in.host" source "package/python-six/Config.in.host" source "package/python-xlrd/Config.in.host" diff --git a/package/python-greenlet/Config.in.host b/package/python-greenlet/Config.in.host new file mode 100644 index 0000000000..673fee8cc5 --- /dev/null +++ b/package/python-greenlet/Config.in.host @@ -0,0 +1,7 @@ +config BR2_PACKAGE_HOST_PYTHON_GREENLET + bool "host python-greenlet" + help + Greenlets are lightweight coroutines for in-process concurrent + programming. + + https://greenlet.readthedocs.io/ diff --git a/package/python-greenlet/python-greenlet.mk b/package/python-greenlet/python-greenlet.mk index 7b983ff0ef..3b1ef7e314 100644 --- a/package/python-greenlet/python-greenlet.mk +++ b/package/python-greenlet/python-greenlet.mk @@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF $(eval $(python-package)) +$(eval $(host-python-package)) -- 2.34.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2] package/python-greenlet: enable as host package 2022-01-10 13:02 ` [Buildroot] [PATCH v2] " Cyril Bur @ 2022-01-10 14:07 ` Cyril Bur 0 siblings, 0 replies; 9+ messages in thread From: Cyril Bur @ 2022-01-10 14:07 UTC (permalink / raw) To: buildroot, Romain Naour Sorry ignore me, sent a version with mistakes. I'll send v3. On Mon, 10 Jan 2022 at 13:02, Cyril Bur <cyrilbur@gmail.com> wrote: > > While currently there is no in-tree Buildroot package which depends on > host-python-lxml, we (Adder Technology) have some proprietary modules > that use it as part of their builds. > > I've tested python-greenlet as host package and confirmed that it builds > and works correctly. Someone else might require it, so we are proposing > its inclusion. > > Signed-off-by: Cyril Bur <cyrilbur@gmail.com> > --- > V2: Added Config.in.host and a better commit message > > package/Config.in.host | 1 + > package/python-greenlet/Config.in.host | 7 +++++++ > package/python-greenlet/python-greenlet.mk | 1 + > 3 files changed, 9 insertions(+) > create mode 100644 package/python-greenlet/Config.in.host > > diff --git a/package/Config.in.host b/package/Config.in.host > index b3e00bb482..6e027d96c2 100644 > --- a/package/Config.in.host > +++ b/package/Config.in.host > @@ -69,6 +69,7 @@ menu "Host utilities" > source "package/pwgen/Config.in.host" > source "package/python/Config.in.host" > source "package/python-cython/Config.in.host" > + source "package/python-greenlet/Config.in.host" > source "package/python-lxml/Config.in.host" > source "package/python-six/Config.in.host" > source "package/python-xlrd/Config.in.host" > diff --git a/package/python-greenlet/Config.in.host b/package/python-greenlet/Config.in.host > new file mode 100644 > index 0000000000..673fee8cc5 > --- /dev/null > +++ b/package/python-greenlet/Config.in.host > @@ -0,0 +1,7 @@ > +config BR2_PACKAGE_HOST_PYTHON_GREENLET > + bool "host python-greenlet" > + help > + Greenlets are lightweight coroutines for in-process concurrent > + programming. > + > + https://greenlet.readthedocs.io/ > diff --git a/package/python-greenlet/python-greenlet.mk b/package/python-greenlet/python-greenlet.mk > index 7b983ff0ef..3b1ef7e314 100644 > --- a/package/python-greenlet/python-greenlet.mk > +++ b/package/python-greenlet/python-greenlet.mk > @@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 > PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF > > $(eval $(python-package)) > +$(eval $(host-python-package)) > -- > 2.34.1 > -- Cyril _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v3] package/python-greenlet: enable as host package 2021-06-23 14:52 [Buildroot] [PATCH] package/python-greenlet: enable as host package Cyril Bur 2022-01-08 18:43 ` Romain Naour 2022-01-10 13:02 ` [Buildroot] [PATCH v2] " Cyril Bur @ 2022-01-10 14:11 ` Cyril Bur 2022-01-10 15:49 ` Yann E. MORIN 2 siblings, 1 reply; 9+ messages in thread From: Cyril Bur @ 2022-01-10 14:11 UTC (permalink / raw) To: buildroot, romain.naour While currently there is no in-tree Buildroot package which depends on host-python-greenlet, we (Adder Technology) have some proprietary modules that use it as part of their builds. I've tested python-greenlet as host package and confirmed that it builds and works correctly. Someone else might require it, so I'm proposing its inclusion. Signed-off-by: Cyril Bur <cyrilbur@gmail.com> --- v2: Half completed commit message update - sorry v3: Updated commit message and Config.in.host package/Config.in.host | 1 + package/python-greenlet/Config.in.host | 7 +++++++ package/python-greenlet/python-greenlet.mk | 1 + 3 files changed, 9 insertions(+) create mode 100644 package/python-greenlet/Config.in.host diff --git a/package/Config.in.host b/package/Config.in.host index b3e00bb482..6e027d96c2 100644 --- a/package/Config.in.host +++ b/package/Config.in.host @@ -69,6 +69,7 @@ menu "Host utilities" source "package/pwgen/Config.in.host" source "package/python/Config.in.host" source "package/python-cython/Config.in.host" + source "package/python-greenlet/Config.in.host" source "package/python-lxml/Config.in.host" source "package/python-six/Config.in.host" source "package/python-xlrd/Config.in.host" diff --git a/package/python-greenlet/Config.in.host b/package/python-greenlet/Config.in.host new file mode 100644 index 0000000000..673fee8cc5 --- /dev/null +++ b/package/python-greenlet/Config.in.host @@ -0,0 +1,7 @@ +config BR2_PACKAGE_HOST_PYTHON_GREENLET + bool "host python-greenlet" + help + Greenlets are lightweight coroutines for in-process concurrent + programming. + + https://greenlet.readthedocs.io/ diff --git a/package/python-greenlet/python-greenlet.mk b/package/python-greenlet/python-greenlet.mk index 7b983ff0ef..3b1ef7e314 100644 --- a/package/python-greenlet/python-greenlet.mk +++ b/package/python-greenlet/python-greenlet.mk @@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF $(eval $(python-package)) +$(eval $(host-python-package)) -- 2.34.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v3] package/python-greenlet: enable as host package 2022-01-10 14:11 ` [Buildroot] [PATCH v3] " Cyril Bur @ 2022-01-10 15:49 ` Yann E. MORIN 0 siblings, 0 replies; 9+ messages in thread From: Yann E. MORIN @ 2022-01-10 15:49 UTC (permalink / raw) To: Cyril Bur; +Cc: romain.naour, buildroot Cyril, All, On 2022-01-10 14:11 +0000, Cyril Bur spake thusly: > While currently there is no in-tree Buildroot package which depends on > host-python-greenlet, we (Adder Technology) have some proprietary > modules that use it as part of their builds. > > I've tested python-greenlet as host package and confirmed that it builds > and works correctly. Someone else might require it, so I'm proposing its > inclusion. In all theory, host-python-greenlet should have the same dependencies toward the host that the target variant has toward the target: config BR2_PACKAGE_PYTHON_GREENLET_ARCH_SUPPORTS bool default y if BR2_arm || BR2_armeb default y if BR2_aarch64 default y if BR2_csky default y if BR2_m68k default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le default y if BR2_riscv default y if BR2_sparc || BR2_sparc64 default y if BR2_i386 || BR2_x86_64 However, in practice, hosts that are commonly used to run Buildroot are virtually all in that list: x86 or x86_64, AArch64 (and maybe a very few arms just for the fun), PPC, and maybe a few adventurous on riscv. So in practice, we do not care. > Signed-off-by: Cyril Bur <cyrilbur@gmail.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > v2: Half completed commit message update - sorry > v3: Updated commit message and Config.in.host > > package/Config.in.host | 1 + > package/python-greenlet/Config.in.host | 7 +++++++ > package/python-greenlet/python-greenlet.mk | 1 + > 3 files changed, 9 insertions(+) > create mode 100644 package/python-greenlet/Config.in.host > > diff --git a/package/Config.in.host b/package/Config.in.host > index b3e00bb482..6e027d96c2 100644 > --- a/package/Config.in.host > +++ b/package/Config.in.host > @@ -69,6 +69,7 @@ menu "Host utilities" > source "package/pwgen/Config.in.host" > source "package/python/Config.in.host" > source "package/python-cython/Config.in.host" > + source "package/python-greenlet/Config.in.host" > source "package/python-lxml/Config.in.host" > source "package/python-six/Config.in.host" > source "package/python-xlrd/Config.in.host" > diff --git a/package/python-greenlet/Config.in.host b/package/python-greenlet/Config.in.host > new file mode 100644 > index 0000000000..673fee8cc5 > --- /dev/null > +++ b/package/python-greenlet/Config.in.host > @@ -0,0 +1,7 @@ > +config BR2_PACKAGE_HOST_PYTHON_GREENLET > + bool "host python-greenlet" > + help > + Greenlets are lightweight coroutines for in-process concurrent > + programming. > + > + https://greenlet.readthedocs.io/ > diff --git a/package/python-greenlet/python-greenlet.mk b/package/python-greenlet/python-greenlet.mk > index 7b983ff0ef..3b1ef7e314 100644 > --- a/package/python-greenlet/python-greenlet.mk > +++ b/package/python-greenlet/python-greenlet.mk > @@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 > PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF > > $(eval $(python-package)) > +$(eval $(host-python-package)) > -- > 2.34.1 > > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-01-10 15:50 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-23 14:52 [Buildroot] [PATCH] package/python-greenlet: enable as host package Cyril Bur 2022-01-08 18:43 ` Romain Naour 2022-01-08 19:03 ` Cyril Bur 2022-01-08 19:13 ` Romain Naour 2022-01-08 19:16 ` Cyril Bur 2022-01-10 13:02 ` [Buildroot] [PATCH v2] " Cyril Bur 2022-01-10 14:07 ` Cyril Bur 2022-01-10 14:11 ` [Buildroot] [PATCH v3] " Cyril Bur 2022-01-10 15:49 ` Yann E. MORIN
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.