* [PATCH] staging: lustre: lustre: libcfs: pr_warn instead printk
@ 2014-08-15 18:18 Hema Prathaban
2014-08-15 23:21 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Hema Prathaban @ 2014-08-15 18:18 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, devel, andreas.dilger, oleg.drokin
This patch fixes the following warning using checkpatch.pl
WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
Signed-off-by: Hema Prathaban <hemaklnce@gmail.com>
---
drivers/staging/lustre/lustre/libcfs/debug.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c b/drivers/staging/lustre/lustre/libcfs/debug.c
index 6b58469..8143ebe 100644
--- a/drivers/staging/lustre/lustre/libcfs/debug.c
+++ b/drivers/staging/lustre/lustre/libcfs/debug.c
@@ -344,7 +344,7 @@ void libcfs_debug_dumplog_internal(void *arg)
snprintf(debug_file_name, sizeof(debug_file_name) - 1,
"%s.%ld.%ld", libcfs_debug_file_path_arr,
get_seconds(), (long_ptr_t)arg);
- printk(KERN_ALERT "LustreError: dumping log to %s\n",
+ pr_alert(KERN_ALERT "LustreError: dumping log to %s\n",
debug_file_name);
cfs_tracefile_dump_all_pages(debug_file_name);
libcfs_run_debug_log_upcall(debug_file_name);
@@ -376,7 +376,7 @@ void libcfs_debug_dumplog(void)
(void *)(long)current_pid(),
"libcfs_debug_dumper");
if (IS_ERR(dumper))
- printk(KERN_ERR "LustreError: cannot start log dump thread:"
+ pr_err(KERN_ERR "LustreError: cannot start log dump thread:"
" %ld\n", PTR_ERR(dumper));
else
schedule();
@@ -453,7 +453,7 @@ int libcfs_debug_mark_buffer(const char *text)
void libcfs_debug_set_level(unsigned int debug_level)
{
- printk(KERN_WARNING "Lustre: Setting portals debug level to %08x\n",
+ pr_warn(KERN_WARNING "Lustre: Setting portals debug level to %08x\n",
debug_level);
libcfs_debug = debug_level;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: lustre: lustre: libcfs: pr_warn instead printk
2014-08-15 18:18 [PATCH] staging: lustre: lustre: libcfs: pr_warn instead printk Hema Prathaban
@ 2014-08-15 23:21 ` Greg KH
2014-08-16 18:40 ` Hema .p
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2014-08-15 23:21 UTC (permalink / raw)
To: Hema Prathaban; +Cc: devel, oleg.drokin, andreas.dilger, linux-kernel
On Fri, Aug 15, 2014 at 11:48:05PM +0530, Hema Prathaban wrote:
> This patch fixes the following warning using checkpatch.pl
> WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
> dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
>
> Signed-off-by: Hema Prathaban <hemaklnce@gmail.com>
> ---
> drivers/staging/lustre/lustre/libcfs/debug.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c b/drivers/staging/lustre/lustre/libcfs/debug.c
> index 6b58469..8143ebe 100644
> --- a/drivers/staging/lustre/lustre/libcfs/debug.c
> +++ b/drivers/staging/lustre/lustre/libcfs/debug.c
> @@ -344,7 +344,7 @@ void libcfs_debug_dumplog_internal(void *arg)
> snprintf(debug_file_name, sizeof(debug_file_name) - 1,
> "%s.%ld.%ld", libcfs_debug_file_path_arr,
> get_seconds(), (long_ptr_t)arg);
> - printk(KERN_ALERT "LustreError: dumping log to %s\n",
> + pr_alert(KERN_ALERT "LustreError: dumping log to %s\n",
> debug_file_name);
> cfs_tracefile_dump_all_pages(debug_file_name);
> libcfs_run_debug_log_upcall(debug_file_name);
> @@ -376,7 +376,7 @@ void libcfs_debug_dumplog(void)
> (void *)(long)current_pid(),
> "libcfs_debug_dumper");
> if (IS_ERR(dumper))
> - printk(KERN_ERR "LustreError: cannot start log dump thread:"
> + pr_err(KERN_ERR "LustreError: cannot start log dump thread:"
You need to take the printk prefix off of these types of lines if you
are using the pr_*() macro, otherwise you will get a mess in the system
log.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: lustre: lustre: libcfs: pr_warn instead printk
2014-08-15 23:21 ` Greg KH
@ 2014-08-16 18:40 ` Hema .p
0 siblings, 0 replies; 3+ messages in thread
From: Hema .p @ 2014-08-16 18:40 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel
On Sat, Aug 16, 2014 at 4:51 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Aug 15, 2014 at 11:48:05PM +0530, Hema Prathaban wrote:
>> This patch fixes the following warning using checkpatch.pl
>> WARNING: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
>> dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
>>
>> Signed-off-by: Hema Prathaban <hemaklnce@gmail.com>
>> ---
>> drivers/staging/lustre/lustre/libcfs/debug.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c b/drivers/staging/lustre/lustre/libcfs/debug.c
>> index 6b58469..8143ebe 100644
>> --- a/drivers/staging/lustre/lustre/libcfs/debug.c
>> +++ b/drivers/staging/lustre/lustre/libcfs/debug.c
>> @@ -344,7 +344,7 @@ void libcfs_debug_dumplog_internal(void *arg)
>> snprintf(debug_file_name, sizeof(debug_file_name) - 1,
>> "%s.%ld.%ld", libcfs_debug_file_path_arr,
>> get_seconds(), (long_ptr_t)arg);
>> - printk(KERN_ALERT "LustreError: dumping log to %s\n",
>> + pr_alert(KERN_ALERT "LustreError: dumping log to %s\n",
>> debug_file_name);
>> cfs_tracefile_dump_all_pages(debug_file_name);
>> libcfs_run_debug_log_upcall(debug_file_name);
>> @@ -376,7 +376,7 @@ void libcfs_debug_dumplog(void)
>> (void *)(long)current_pid(),
>> "libcfs_debug_dumper");
>> if (IS_ERR(dumper))
>> - printk(KERN_ERR "LustreError: cannot start log dump thread:"
>> + pr_err(KERN_ERR "LustreError: cannot start log dump thread:"
>
> You need to take the printk prefix off of these types of lines if you
> are using the pr_*() macro, otherwise you will get a mess in the system
> log.
>
> thanks,
>
> greg k-h
Hi Greg,
I have resented my patches.
Thanks
Hema
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-16 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-15 18:18 [PATCH] staging: lustre: lustre: libcfs: pr_warn instead printk Hema Prathaban
2014-08-15 23:21 ` Greg KH
2014-08-16 18:40 ` Hema .p
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.