From: Rick Chen <rickchen36@gmail.com>
To: saproj@gmail.com
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
jh80.chung@samsung.com, Peng Fan <peng.fan@nxp.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Simon Glass <sjg@chromium.org>,
Leo Liang <ycliang@andestech.com>, rick <rick@andestech.com>
Subject: Re: [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment
Date: Mon, 5 Sep 2022 08:53:17 +0800 [thread overview]
Message-ID: <CAN5B=eJYAvMSyA2SCEo1WpbZQyxZpoOUKvSSnm_4Cec36JQoNA@mail.gmail.com> (raw)
In-Reply-To: <HK0PR03MB299427578088D127EA94F428C17F9@HK0PR03MB2994.apcprd03.prod.outlook.com>
> From: Sergei Antonov <saproj@gmail.com>
> Sent: Friday, September 02, 2022 3:40 PM
> To: u-boot@lists.denx.de
> Cc: jh80.chung@samsung.com; peng.fan@nxp.com; yamada.masahiro@socionext.com; sjg@chromium.org; Rick Jian-Zhi Chen(陳建志) <rick@andestech.com>; Sergei Antonov <saproj@gmail.com>
> Subject: [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment
>
> Get rid of discrepancy beween comment /* 250 ms */ and code which shifts by 4 thus dividing by 16.
> So change code to shift by 2 and make the timeout value 250 ms.
>
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
> ---
> drivers/mmc/ftsdc010_mci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/ftsdc010_mci.c b/drivers/mmc/ftsdc010_mci.c index 570d54cf9d8f..cabb747fbbdb 100644
> --- a/drivers/mmc/ftsdc010_mci.c
> +++ b/drivers/mmc/ftsdc010_mci.c
> @@ -30,7 +30,7 @@
> #include <syscon.h>
> #include <linux/err.h>
>
> -#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4) /* 250 ms */
> +#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2) /* 250 ms */
Reviewed-by: Rick Chen <rick@andestech.com>
next prev parent reply other threads:[~2022-09-05 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 7:40 [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment Sergei Antonov
[not found] ` <HK0PR03MB299427578088D127EA94F428C17F9@HK0PR03MB2994.apcprd03.prod.outlook.com>
2022-09-05 0:53 ` Rick Chen [this message]
2022-09-08 11:20 ` Jaehoon Chung
[not found] ` <CGME20221025000026epcas1p148f488302b641e18797d7874962ca264@epcas1p1.samsung.com>
2022-10-25 0:00 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN5B=eJYAvMSyA2SCEo1WpbZQyxZpoOUKvSSnm_4Cec36JQoNA@mail.gmail.com' \
--to=rickchen36@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=peng.fan@nxp.com \
--cc=rick@andestech.com \
--cc=saproj@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=yamada.masahiro@socionext.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.