From: Etienne Carriere <etienne.carriere@linaro.org> To: Rob Herring <robh@kernel.org> Cc: linux-kernel@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi <cristian.marussi@arm.com>, Vincent Guittot <vincent.guittot@linaro.org>, devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI Date: Tue, 19 Oct 2021 11:20:44 +0200 [thread overview] Message-ID: <CAN5uoS_ab2Te6++JPAQ2UJqjdO46t=vyT2Ek0DvWG8umSibTnQ@mail.gmail.com> (raw) In-Reply-To: <YW2xhRXQ+MA/Cxm1@robh.at.kernel.org> On Mon, 18 Oct 2021 at 19:40, Rob Herring <robh@kernel.org> wrote: > > On Mon, Oct 18, 2021 at 01:40:45PM +0200, Etienne Carriere wrote: > > Introduce compatible "linaro,scmi-optee" for SCMI transport channel > > based on an OP-TEE service invocation. The compatible mandates a > > channel ID defined with property "linaro,optee-channel-id". > > > > Cc: devicetree@vger.kernel.org > > Cc: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > > --- > > Changes since v2: > > - Define mandatory property linaro,optee-channel-id > > - Rebased on yaml description file > > > > Changes since v1: > > - Removed modification regarding mboxes property description. > > --- > > .../bindings/firmware/arm,scmi.yaml | 44 +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > index 5c4c6782e052..12154ecc081b 100644 > > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > @@ -38,6 +38,9 @@ properties: > > The virtio transport only supports a single device. > > items: > > - const: arm,scmi-virtio > > + - description: SCMI compliant firmware with OP-TEE transport > > + items: > > + - const: linaro,scmi-optee > > > > interrupts: > > description: > > @@ -83,6 +86,11 @@ properties: > > description: > > SMC id required when using smc or hvc transports > > > > + linaro,optee-channel-id: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + Channel id required when using OP-TEE transports > > + > > protocol@11: > > type: object > > properties: > > @@ -195,6 +203,9 @@ patternProperties: > > minItems: 1 > > maxItems: 2 > > > > + linaro,optee-channel-id: > > + maxItems: 1 > > Why is the same property in 2 different spots? That doesn't seem ideal. > > Unfortunately, you have to duplicate the definition. Property linaro,optee-channel-id for compatible linaro,scmi-optee is like properties mboxes and shmem for compatibile arm,scmi. There are mandated in the scmi node and are optional in its subnodes: an scmi protocol (a subnode), can have a dedicated scmi channel. The yaml description is expected to reflect that. Regards, Etienne > > > + > > required: > > - reg > > > > @@ -226,6 +237,16 @@ else: > > - arm,smc-id > > - shmem > > > > + else: > > + if: > > + properties: > > + compatible: > > + contains: > > + const: linaro,scmi-optee > > + then: > > + required: > > + - linaro,optee-channel-id > > + > > examples: > > - | > > firmware { > > @@ -340,7 +361,30 @@ examples: > > reg = <0x11>; > > #power-domain-cells = <1>; > > }; > > + }; > > + }; > > + > > + - | > > + firmware { > > + scmi { > > + compatible = "linaro,scmi-optee"; > > + linaro,optee-channel = <0>; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + scmi_clk: protocol@14 { > > + reg = <0x14>; > > + #clock-cells = <1>; > > + }; > > + > > + scmi_dvfs: protocol@13 { > > + reg = <0x13>; > > > > + #clock-cells = <1>; > > + linaro,optee-channel = <1>; > > + shmem = <&cpu_scp_hpri0>; > > + }; > > }; > > }; > > > > -- > > 2.17.1 > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Etienne Carriere <etienne.carriere@linaro.org> To: Rob Herring <robh@kernel.org> Cc: linux-kernel@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi <cristian.marussi@arm.com>, Vincent Guittot <vincent.guittot@linaro.org>, devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI Date: Tue, 19 Oct 2021 11:20:44 +0200 [thread overview] Message-ID: <CAN5uoS_ab2Te6++JPAQ2UJqjdO46t=vyT2Ek0DvWG8umSibTnQ@mail.gmail.com> (raw) In-Reply-To: <YW2xhRXQ+MA/Cxm1@robh.at.kernel.org> On Mon, 18 Oct 2021 at 19:40, Rob Herring <robh@kernel.org> wrote: > > On Mon, Oct 18, 2021 at 01:40:45PM +0200, Etienne Carriere wrote: > > Introduce compatible "linaro,scmi-optee" for SCMI transport channel > > based on an OP-TEE service invocation. The compatible mandates a > > channel ID defined with property "linaro,optee-channel-id". > > > > Cc: devicetree@vger.kernel.org > > Cc: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > > --- > > Changes since v2: > > - Define mandatory property linaro,optee-channel-id > > - Rebased on yaml description file > > > > Changes since v1: > > - Removed modification regarding mboxes property description. > > --- > > .../bindings/firmware/arm,scmi.yaml | 44 +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > index 5c4c6782e052..12154ecc081b 100644 > > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > @@ -38,6 +38,9 @@ properties: > > The virtio transport only supports a single device. > > items: > > - const: arm,scmi-virtio > > + - description: SCMI compliant firmware with OP-TEE transport > > + items: > > + - const: linaro,scmi-optee > > > > interrupts: > > description: > > @@ -83,6 +86,11 @@ properties: > > description: > > SMC id required when using smc or hvc transports > > > > + linaro,optee-channel-id: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + Channel id required when using OP-TEE transports > > + > > protocol@11: > > type: object > > properties: > > @@ -195,6 +203,9 @@ patternProperties: > > minItems: 1 > > maxItems: 2 > > > > + linaro,optee-channel-id: > > + maxItems: 1 > > Why is the same property in 2 different spots? That doesn't seem ideal. > > Unfortunately, you have to duplicate the definition. Property linaro,optee-channel-id for compatible linaro,scmi-optee is like properties mboxes and shmem for compatibile arm,scmi. There are mandated in the scmi node and are optional in its subnodes: an scmi protocol (a subnode), can have a dedicated scmi channel. The yaml description is expected to reflect that. Regards, Etienne > > > + > > required: > > - reg > > > > @@ -226,6 +237,16 @@ else: > > - arm,smc-id > > - shmem > > > > + else: > > + if: > > + properties: > > + compatible: > > + contains: > > + const: linaro,scmi-optee > > + then: > > + required: > > + - linaro,optee-channel-id > > + > > examples: > > - | > > firmware { > > @@ -340,7 +361,30 @@ examples: > > reg = <0x11>; > > #power-domain-cells = <1>; > > }; > > + }; > > + }; > > + > > + - | > > + firmware { > > + scmi { > > + compatible = "linaro,scmi-optee"; > > + linaro,optee-channel = <0>; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + scmi_clk: protocol@14 { > > + reg = <0x14>; > > + #clock-cells = <1>; > > + }; > > + > > + scmi_dvfs: protocol@13 { > > + reg = <0x13>; > > > > + #clock-cells = <1>; > > + linaro,optee-channel = <1>; > > + shmem = <&cpu_scp_hpri0>; > > + }; > > }; > > }; > > > > -- > > 2.17.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-19 9:21 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-18 11:40 [PATCH v3 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI Etienne Carriere 2021-10-18 11:40 ` Etienne Carriere 2021-10-18 11:40 ` [PATCH v3 2/2] firmware: arm_scmi: Add optee transport Etienne Carriere 2021-10-18 11:40 ` Etienne Carriere 2021-10-18 19:43 ` Cristian Marussi 2021-10-18 19:43 ` Cristian Marussi 2021-10-19 9:10 ` Etienne Carriere 2021-10-19 9:10 ` Etienne Carriere 2021-10-19 14:24 ` Etienne Carriere 2021-10-19 14:24 ` Etienne Carriere 2021-10-19 16:19 ` Cristian Marussi 2021-10-19 16:19 ` Cristian Marussi 2021-10-19 12:50 ` kernel test robot 2021-10-19 12:50 ` kernel test robot 2021-10-19 12:50 ` kernel test robot 2021-10-18 17:32 ` [PATCH v3 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI Rob Herring 2021-10-18 17:32 ` Rob Herring 2021-10-20 15:52 ` Etienne Carriere 2021-10-20 15:52 ` Etienne Carriere 2021-10-20 16:45 ` Etienne Carriere 2021-10-20 16:45 ` Etienne Carriere 2021-10-18 17:40 ` Rob Herring 2021-10-18 17:40 ` Rob Herring 2021-10-19 9:20 ` Etienne Carriere [this message] 2021-10-19 9:20 ` Etienne Carriere
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAN5uoS_ab2Te6++JPAQ2UJqjdO46t=vyT2Ek0DvWG8umSibTnQ@mail.gmail.com' \ --to=etienne.carriere@linaro.org \ --cc=cristian.marussi@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.