All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drm/bridge: clean up some inconsistent indentings
@ 2023-09-20  0:44 ` Yang Li
  0 siblings, 0 replies; 5+ messages in thread
From: Yang Li @ 2023-09-20  0:44 UTC (permalink / raw)
  To: airlied, daniel, andrzej.hajda, neil.armstrong, rfoss
  Cc: Laurent.pinchart, jonas, jernej.skrabec, dri-devel, linux-kernel,
	Yang Li

drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
index 673661160e54..fe2ff4984fc5 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
@@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
 	struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
 
 	/* store interrupt status/mask registers */
-	 cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
-	 cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
-	 cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
+	cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
+	cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
+	cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
 
 	return 0;
 }
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH -next] drm/bridge: clean up some inconsistent indentings
@ 2023-09-20  0:44 ` Yang Li
  0 siblings, 0 replies; 5+ messages in thread
From: Yang Li @ 2023-09-20  0:44 UTC (permalink / raw)
  To: airlied, daniel, andrzej.hajda, neil.armstrong, rfoss
  Cc: jernej.skrabec, jonas, linux-kernel, dri-devel, Yang Li,
	Laurent.pinchart

drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
index 673661160e54..fe2ff4984fc5 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
@@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
 	struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
 
 	/* store interrupt status/mask registers */
-	 cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
-	 cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
-	 cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
+	cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
+	cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
+	cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
 
 	return 0;
 }
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH -next] drm/bridge: clean up some inconsistent indentings
  2023-09-20  0:44 ` Yang Li
@ 2023-09-25 10:50   ` Robert Foss
  -1 siblings, 0 replies; 5+ messages in thread
From: Robert Foss @ 2023-09-25 10:50 UTC (permalink / raw)
  To: Yang Li
  Cc: airlied, daniel, andrzej.hajda, neil.armstrong, Laurent.pinchart,
	jonas, jernej.skrabec, dri-devel, linux-kernel

NAK

Personally I value maintaining a simple to follow `git blame` history
over correcting indentation.

Ideally bad indentation should never be committed in the first place.

On Wed, Sep 20, 2023 at 2:44 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> index 673661160e54..fe2ff4984fc5 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> @@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
>         struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
>
>         /* store interrupt status/mask registers */
> -        cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> -        cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> -        cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
> +       cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> +       cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> +       cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
>
>         return 0;
>  }
> --
> 2.20.1.7.g153144c
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH -next] drm/bridge: clean up some inconsistent indentings
@ 2023-09-25 10:50   ` Robert Foss
  0 siblings, 0 replies; 5+ messages in thread
From: Robert Foss @ 2023-09-25 10:50 UTC (permalink / raw)
  To: Yang Li
  Cc: neil.armstrong, jonas, dri-devel, linux-kernel, jernej.skrabec,
	Laurent.pinchart, andrzej.hajda

NAK

Personally I value maintaining a simple to follow `git blame` history
over correcting indentation.

Ideally bad indentation should never be committed in the first place.

On Wed, Sep 20, 2023 at 2:44 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> index 673661160e54..fe2ff4984fc5 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> @@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
>         struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
>
>         /* store interrupt status/mask registers */
> -        cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> -        cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> -        cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
> +       cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> +       cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> +       cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
>
>         return 0;
>  }
> --
> 2.20.1.7.g153144c
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH -next] drm/bridge: clean up some inconsistent indentings
  2023-09-25 10:50   ` Robert Foss
  (?)
@ 2023-09-25 11:08   ` Jani Nikula
  -1 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2023-09-25 11:08 UTC (permalink / raw)
  To: Robert Foss, Yang Li
  Cc: neil.armstrong, jonas, dri-devel, linux-kernel, jernej.skrabec,
	Laurent.pinchart, andrzej.hajda

On Mon, 25 Sep 2023, Robert Foss <rfoss@kernel.org> wrote:
> NAK

Feels a bit harsh.

> Personally I value maintaining a simple to follow `git blame` history
> over correcting indentation.
>
> Ideally bad indentation should never be committed in the first place.

Agreed, but when that inevitably happens, do you really want it to be
cast in stone? To me leaving bad indent (or style, or whatever) in place
indicates we don't care, while the opposite is true.

Maybe look into tooling that lets you easily git blame the parent commit
of a line in git blame? (For example, in emacs vc-annotate, it's just a
matter of hitting 'a'.)


BR,
Jani.


>
> On Wed, Sep 20, 2023 at 2:44 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>>
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting
>>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
>> index 673661160e54..fe2ff4984fc5 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
>> @@ -333,9 +333,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
>>         struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
>>
>>         /* store interrupt status/mask registers */
>> -        cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
>> -        cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
>> -        cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
>> +       cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
>> +       cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
>> +       cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
>>
>>         return 0;
>>  }
>> --
>> 2.20.1.7.g153144c
>>

-- 
Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-25 11:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-20  0:44 [PATCH -next] drm/bridge: clean up some inconsistent indentings Yang Li
2023-09-20  0:44 ` Yang Li
2023-09-25 10:50 ` Robert Foss
2023-09-25 10:50   ` Robert Foss
2023-09-25 11:08   ` Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.