From: Anand Moon <linux.amoon@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>,
linux-gpio@vger.kernel.org, balbes-150@yandex.ru,
"Kevin Hilman" <khilman@baylibre.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-mmc@vger.kernel.org, bgolaszewski@baylibre.com,
"Guenter Roeck" <linux@roeck-us.net>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] ARM: dts: meson8b: odroidc1: mark the SD card detection GPIO active-low
Date: Mon, 7 Jan 2019 14:21:01 +0530 [thread overview]
Message-ID: <CANAwSgQjoXqbV2hDs4W3kR=7ULK0gkR24V6SiEJw2+mYsaNcVQ@mail.gmail.com> (raw)
In-Reply-To: <20181229125711.5205-2-martin.blumenstingl@googlemail.com>
Hi Martin,
On Sat, 29 Dec 2018 at 18:28, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device
> tree") SD cards are not detected anymore.
>
> The CD GPIO is "active low" on Odroid-C1. The MMC dt-bindings specify:
> "[...] using the "cd-inverted" property means, that the CD line is active
> high, i.e. it is high, when a card is inserted".
>
> Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and
> drop the "cd-inverted" property. This makes the definition consistent
> with the existing dt-bindings and fixes the check whether an SD card is
> inserted.
>
> Fixes: e03efbce6bebf5 ("ARM: dts: meson8b-odroidc1: add microSD support")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm/boot/dts/meson8b-odroidc1.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> index 58669abda259..070d69889f3e 100644
> --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> @@ -273,8 +273,7 @@
> cap-sd-highspeed;
> disable-wp;
>
> - cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
> - cd-inverted;
> + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
>
> vmmc-supply = <&tflash_vdd>;
> vqmmc-supply = <&tf_io>;
> --
> 2.20.1
>
Please add my on my Odroid c1+
Tested-by: Anand Moon <linux.amoon@gmail.com>
My Odroid C2 is also fails to bootup with out these changes.
Can you send patch to fix them as well.
Best Regards
-Anand
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>,
linux-gpio@vger.kernel.org, balbes-150@yandex.ru,
"Kevin Hilman" <khilman@baylibre.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-mmc@vger.kernel.org, bgolaszewski@baylibre.com,
"Guenter Roeck" <linux@roeck-us.net>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] ARM: dts: meson8b: odroidc1: mark the SD card detection GPIO active-low
Date: Mon, 7 Jan 2019 14:21:01 +0530 [thread overview]
Message-ID: <CANAwSgQjoXqbV2hDs4W3kR=7ULK0gkR24V6SiEJw2+mYsaNcVQ@mail.gmail.com> (raw)
In-Reply-To: <20181229125711.5205-2-martin.blumenstingl@googlemail.com>
Hi Martin,
On Sat, 29 Dec 2018 at 18:28, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device
> tree") SD cards are not detected anymore.
>
> The CD GPIO is "active low" on Odroid-C1. The MMC dt-bindings specify:
> "[...] using the "cd-inverted" property means, that the CD line is active
> high, i.e. it is high, when a card is inserted".
>
> Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and
> drop the "cd-inverted" property. This makes the definition consistent
> with the existing dt-bindings and fixes the check whether an SD card is
> inserted.
>
> Fixes: e03efbce6bebf5 ("ARM: dts: meson8b-odroidc1: add microSD support")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm/boot/dts/meson8b-odroidc1.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> index 58669abda259..070d69889f3e 100644
> --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> @@ -273,8 +273,7 @@
> cap-sd-highspeed;
> disable-wp;
>
> - cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
> - cd-inverted;
> + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
>
> vmmc-supply = <&tflash_vdd>;
> vqmmc-supply = <&tf_io>;
> --
> 2.20.1
>
Please add my on my Odroid c1+
Tested-by: Anand Moon <linux.amoon@gmail.com>
My Odroid C2 is also fails to bootup with out these changes.
Can you send patch to fix them as well.
Best Regards
-Anand
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>,
linux-gpio@vger.kernel.org, balbes-150@yandex.ru,
"Kevin Hilman" <khilman@baylibre.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-mmc@vger.kernel.org, bgolaszewski@baylibre.com,
"Guenter Roeck" <linux@roeck-us.net>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] ARM: dts: meson8b: odroidc1: mark the SD card detection GPIO active-low
Date: Mon, 7 Jan 2019 14:21:01 +0530 [thread overview]
Message-ID: <CANAwSgQjoXqbV2hDs4W3kR=7ULK0gkR24V6SiEJw2+mYsaNcVQ@mail.gmail.com> (raw)
In-Reply-To: <20181229125711.5205-2-martin.blumenstingl@googlemail.com>
Hi Martin,
On Sat, 29 Dec 2018 at 18:28, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device
> tree") SD cards are not detected anymore.
>
> The CD GPIO is "active low" on Odroid-C1. The MMC dt-bindings specify:
> "[...] using the "cd-inverted" property means, that the CD line is active
> high, i.e. it is high, when a card is inserted".
>
> Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and
> drop the "cd-inverted" property. This makes the definition consistent
> with the existing dt-bindings and fixes the check whether an SD card is
> inserted.
>
> Fixes: e03efbce6bebf5 ("ARM: dts: meson8b-odroidc1: add microSD support")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm/boot/dts/meson8b-odroidc1.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> index 58669abda259..070d69889f3e 100644
> --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> @@ -273,8 +273,7 @@
> cap-sd-highspeed;
> disable-wp;
>
> - cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;
> - cd-inverted;
> + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>;
>
> vmmc-supply = <&tflash_vdd>;
> vqmmc-supply = <&tf_io>;
> --
> 2.20.1
>
Please add my on my Odroid c1+
Tested-by: Anand Moon <linux.amoon@gmail.com>
My Odroid C2 is also fails to bootup with out these changes.
Can you send patch to fix them as well.
Best Regards
-Anand
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-01-07 8:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 12:57 [PATCH 0/3] ARM: dts: meson: fix SD card cd-gpio (pre v4.21-rc) Martin Blumenstingl
2018-12-29 12:57 ` Martin Blumenstingl
2018-12-29 12:57 ` Martin Blumenstingl
2018-12-29 12:57 ` [PATCH 1/3] ARM: dts: meson8b: odroidc1: mark the SD card detection GPIO active-low Martin Blumenstingl
2018-12-29 12:57 ` Martin Blumenstingl
2018-12-29 12:57 ` Martin Blumenstingl
2018-12-30 19:54 ` Linus Walleij
2018-12-30 19:54 ` Linus Walleij
2018-12-30 19:54 ` Linus Walleij
2019-01-07 8:51 ` Anand Moon [this message]
2019-01-07 8:51 ` Anand Moon
2019-01-07 8:51 ` Anand Moon
2019-01-08 22:02 ` Martin Blumenstingl
2019-01-08 22:02 ` Martin Blumenstingl
2019-01-08 22:02 ` Martin Blumenstingl
2018-12-29 12:57 ` [PATCH 2/3] ARM: dts: meson8b: ec100: " Martin Blumenstingl
2018-12-29 12:57 ` Martin Blumenstingl
2018-12-29 12:57 ` Martin Blumenstingl
2018-12-30 19:54 ` Linus Walleij
2018-12-30 19:54 ` Linus Walleij
2018-12-30 19:54 ` Linus Walleij
2018-12-29 12:57 ` [PATCH 3/3] ARM: dts: meson8m2: mxiii-plus: " Martin Blumenstingl
2018-12-29 12:57 ` Martin Blumenstingl
2018-12-29 12:57 ` Martin Blumenstingl
2018-12-30 19:54 ` Linus Walleij
2018-12-30 19:54 ` Linus Walleij
2018-12-30 19:54 ` Linus Walleij
2018-12-29 14:29 ` [PATCH 0/3] ARM: dts: meson: fix SD card cd-gpio (pre v4.21-rc) Martin Blumenstingl
2018-12-29 14:29 ` Martin Blumenstingl
2018-12-29 14:29 ` Martin Blumenstingl
2019-01-11 1:18 ` Kevin Hilman
2019-01-11 1:18 ` Kevin Hilman
2019-01-11 1:18 ` Kevin Hilman
2018-12-30 19:57 ` Linus Walleij
2018-12-30 19:57 ` Linus Walleij
2018-12-30 19:57 ` Linus Walleij
2018-12-31 11:03 ` Martin Blumenstingl
2018-12-31 11:03 ` Martin Blumenstingl
2018-12-31 11:03 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANAwSgQjoXqbV2hDs4W3kR=7ULK0gkR24V6SiEJw2+mYsaNcVQ@mail.gmail.com' \
--to=linux.amoon@gmail.com \
--cc=balbes-150@yandex.ru \
--cc=bgolaszewski@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linus.luessing@c0d3.blue \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.