From: Anand Moon <linux.amoon@gmail.com> To: Robin Murphy <robin.murphy@arm.com> Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Heiko Stuebner <heiko@sntech.de>, Jagan Teki <jagan@amarulasolutions.com>, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, Daniel Schultz <d.schultz@phytec.de>, devicetree <devicetree@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-rockchip@lists.infradead.org, Linux Kernel <linux-kernel@vger.kernel.org> Subject: Re: [RFCv1 0/8] RK3399 clean shutdown issue Date: Mon, 9 Dec 2019 20:26:42 +0530 [thread overview] Message-ID: <CANAwSgTPrP5FS3xb7SadZ+BwASWQxfO8rBmno8ZW0JzAxcqWKA@mail.gmail.com> (raw) In-Reply-To: <724aa7db-3838-16f9-d344-1789ae2a5746@arm.com> Hi Robin, On Mon, 9 Dec 2019 at 18:59, Robin Murphy <robin.murphy@arm.com> wrote: > > On 06/12/2019 6:45 pm, Anand Moon wrote: > > Most of the RK3399 SBC boards do not perform clean > > shutdown and clean reboot. > > FWIW reboot problems on RK3399 have been tracked down to issues in > upstream ATF, and are unrelated to the PMIC. Yes I am aware of this changes. But, I have tired to study *RK808 datasheet V1.4* [0] below section *5.2.3 Power Channel Control/Monitor Registers* for clean reboot I was going to try disable some bit in below into reboot handle in the future patch. DCDC_EN_REG SLEEP_SET_OFF_REG1 SLEEP_SET_OFF_REG2 DCDC_UV_STS_REG I was going see if this helps to do clean reboot. further more use this in suspend/resume operation. [0] http://rockchip.fr/RK808%20datasheet%20V1.4.pdf But I feed that their is some more issue with related to mmc or PCIe not able to cleanly release the resources while reboot which caused then to disable after reboot. > > > These patches try to help resolve the issue with proper > > shutdown by turning off the PMIC. > > As mentioned elsewhere[1], although this is what the BSP kernel seems to > do, and in practice it's unlikely to matter for the majority of devboard > users like you and me, I still feel a bit uncomfortable with this > solution for systems using ATF as in principle the secure world might > want to know about orderly shutdowns, and this effectively makes every > shutdown an unexpected power loss from secure software's point of view. > > Robin. > > [1] > http://lists.infradead.org/pipermail/linux-rockchip/2019-December/028183.html > Yes I have follow the mailing list and I read this thread. I am not aware of ATF complete architecture. -Anand
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com> To: Robin Murphy <robin.murphy@arm.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, Daniel Schultz <d.schultz@phytec.de>, Heiko Stuebner <heiko@sntech.de>, Linux Kernel <linux-kernel@vger.kernel.org>, linux-rockchip@lists.infradead.org, Rob Herring <robh+dt@kernel.org>, Jagan Teki <jagan@amarulasolutions.com>, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [RFCv1 0/8] RK3399 clean shutdown issue Date: Mon, 9 Dec 2019 20:26:42 +0530 [thread overview] Message-ID: <CANAwSgTPrP5FS3xb7SadZ+BwASWQxfO8rBmno8ZW0JzAxcqWKA@mail.gmail.com> (raw) In-Reply-To: <724aa7db-3838-16f9-d344-1789ae2a5746@arm.com> Hi Robin, On Mon, 9 Dec 2019 at 18:59, Robin Murphy <robin.murphy@arm.com> wrote: > > On 06/12/2019 6:45 pm, Anand Moon wrote: > > Most of the RK3399 SBC boards do not perform clean > > shutdown and clean reboot. > > FWIW reboot problems on RK3399 have been tracked down to issues in > upstream ATF, and are unrelated to the PMIC. Yes I am aware of this changes. But, I have tired to study *RK808 datasheet V1.4* [0] below section *5.2.3 Power Channel Control/Monitor Registers* for clean reboot I was going to try disable some bit in below into reboot handle in the future patch. DCDC_EN_REG SLEEP_SET_OFF_REG1 SLEEP_SET_OFF_REG2 DCDC_UV_STS_REG I was going see if this helps to do clean reboot. further more use this in suspend/resume operation. [0] http://rockchip.fr/RK808%20datasheet%20V1.4.pdf But I feed that their is some more issue with related to mmc or PCIe not able to cleanly release the resources while reboot which caused then to disable after reboot. > > > These patches try to help resolve the issue with proper > > shutdown by turning off the PMIC. > > As mentioned elsewhere[1], although this is what the BSP kernel seems to > do, and in practice it's unlikely to matter for the majority of devboard > users like you and me, I still feel a bit uncomfortable with this > solution for systems using ATF as in principle the secure world might > want to know about orderly shutdowns, and this effectively makes every > shutdown an unexpected power loss from secure software's point of view. > > Robin. > > [1] > http://lists.infradead.org/pipermail/linux-rockchip/2019-December/028183.html > Yes I have follow the mailing list and I read this thread. I am not aware of ATF complete architecture. -Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-09 14:56 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-06 18:45 [RFCv1 0/8] RK3399 clean shutdown issue Anand Moon 2019-12-06 18:45 ` Anand Moon 2019-12-06 18:45 ` [RFCv1 1/8] mfd: rk808: Refactor shutdown functions Anand Moon 2019-12-06 18:45 ` Anand Moon 2019-12-06 18:45 ` Anand Moon 2019-12-16 11:11 ` Lee Jones 2019-12-16 11:11 ` Lee Jones 2019-12-06 18:45 ` [RFCv1 2/8] mfd: rk808: use syscore for RK805 PMIC shutdown Anand Moon 2019-12-06 18:45 ` Anand Moon 2019-12-09 13:34 ` Robin Murphy 2019-12-09 13:34 ` Robin Murphy 2019-12-09 15:38 ` Anand Moon 2019-12-09 15:38 ` Anand Moon 2019-12-06 18:45 ` [RFCv1 3/8] mfd: rk808: use syscore for RK808 " Anand Moon 2019-12-06 18:45 ` Anand Moon 2019-12-06 18:45 ` [RFCv1 4/8] mfd: rk808: use syscore for RK818 " Anand Moon 2019-12-06 18:45 ` Anand Moon 2019-12-06 18:45 ` [RFCv1 5/8] mfd: rk808: cleanup unused function pointer Anand Moon 2019-12-06 18:45 ` Anand Moon 2019-12-06 18:45 ` [RFCv1 6/8] mfd: rk808: use common syscore for all PMCI for clean shutdown Anand Moon 2019-12-06 18:45 ` Anand Moon 2019-12-06 18:45 ` [RFCv1 7/8] arm64: rockchip: drop unused field from rk8xx i2c node Anand Moon 2019-12-06 18:45 ` Anand Moon 2019-12-06 18:45 ` [RFCv1 8/8] arm: " Anand Moon 2019-12-06 18:45 ` Anand Moon 2019-12-06 22:32 ` [RFCv1 0/8] RK3399 clean shutdown issue Heiko Stuebner 2019-12-06 22:32 ` Heiko Stuebner 2019-12-07 5:07 ` Anand Moon 2019-12-07 5:07 ` Anand Moon 2019-12-07 11:45 ` Heiko Stuebner 2019-12-07 11:45 ` Heiko Stuebner 2019-12-09 13:29 ` Robin Murphy 2019-12-09 13:29 ` Robin Murphy 2019-12-09 13:37 ` Peter Geis 2019-12-09 13:37 ` Peter Geis 2019-12-09 13:53 ` Heiko Stübner 2019-12-09 13:53 ` Heiko Stübner 2019-12-09 13:58 ` Robin Murphy 2019-12-09 13:58 ` Robin Murphy 2019-12-09 14:51 ` Tobias Schramm 2019-12-09 14:51 ` Tobias Schramm 2019-12-09 14:56 ` Anand Moon [this message] 2019-12-09 14:56 ` Anand Moon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CANAwSgTPrP5FS3xb7SadZ+BwASWQxfO8rBmno8ZW0JzAxcqWKA@mail.gmail.com \ --to=linux.amoon@gmail.com \ --cc=d.schultz@phytec.de \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=jagan@amarulasolutions.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=manivannan.sadhasivam@linaro.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=robin.murphy@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.