From: Yanfei Zhang <zhangyanfei.yes@gmail.com> To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> Cc: zhangyanfei@cn.fujitsu.com, kexec@lists.infradead.org, heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org, lisa.mitchell@hp.com, kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com, vgoyal@redhat.com Subject: Re: [PATCH v2 15/20] kexec: fill note buffers by NT_VMCORE_PAD notes in page-size boundary Date: Fri, 8 Mar 2013 21:02:50 +0800 [thread overview] Message-ID: <CANBD6kFwTjKL9CqUzVSWFSRH6ibdQstCU5wTBkv4+=4HhPiG4Q@mail.gmail.com> (raw) In-Reply-To: <20130308.105519.82764856.d.hatayama@jp.fujitsu.com> 2013/3/8 HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>: > From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> > Subject: Re: [PATCH v2 15/20] kexec: fill note buffers by NT_VMCORE_PAD notes in page-size boundary > Date: Thu, 7 Mar 2013 18:11:30 +0800 > >> 于 2013年03月02日 16:37, HATAYAMA Daisuke 写道: >>> Fill both crash_notes and vmcoreinfo_note buffers by NT_VMCORE_PAD >>> note type to make them satisfy mmap()'s page-size boundary >>> requirement. >>> >>> So far, end of note segments has been marked by zero-filled elf >>> header. Instead, this patch writes NT_VMCORE_PAD note in the end of >>> note segments until the offset on page-size boundary. >> >> >> In the codes below, it seems that you assign name "VMCOREINFO" for >> note type NT_VMCORE_PAD, right? This is kind of wired, i think. This >> name has been used for NT_VMCORE_DEBUGINFO note already. Why not something >> like "VMCOREPAD" or "PAD"? >> > > It looks you are confusing or don't know name and type. The name is > namespace and in the namespace, there are multiple note types, each of > which has the corresponding data. In other words, data corresponding > to types differ if they belong to differnet name space even if > integers of the types are coincide with. Yes, I knew this. Just as the spec said " a program must recognize both the name and the type to recognize a descriptor.". But I cannot understand what your word "namespace" came from? I think you complicate simple things here. Only with a type, we cannot recognize a descriptor, because "multiple interpretations of a single type value may exist", So we should combine the name and the type together. If both the name and type of two descriptors are the same, we could say we have two same descriptors. If one of them (type or name) are different, we say the two descriptors are different and the two notes have different data. If I am wrong, please correct me. > > The "VMCOREINFO" name represents information exported from > /proc/vmcore that is used in kdump framework. In this sense, > NT_VMCORE_PAD that is specific for /proc/vmcore and kdump framework, > should belong to the "VMCOREINFO" name. I cannot understand the name explanation totally. Does the name really have this meaning? Is there any authentic document? I was always thinking we could feel free to name a name by ourselves! > > Thanks. > HATAYAMA, Daisuke > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Yanfei Zhang <zhangyanfei.yes@gmail.com> To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> Cc: heiko.carstens@de.ibm.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, lisa.mitchell@hp.com, kumagai-atsushi@mxc.nes.nec.co.jp, ebiederm@xmission.com, zhangyanfei@cn.fujitsu.com, akpm@linux-foundation.org, cpw@sgi.com, vgoyal@redhat.com Subject: Re: [PATCH v2 15/20] kexec: fill note buffers by NT_VMCORE_PAD notes in page-size boundary Date: Fri, 8 Mar 2013 21:02:50 +0800 [thread overview] Message-ID: <CANBD6kFwTjKL9CqUzVSWFSRH6ibdQstCU5wTBkv4+=4HhPiG4Q@mail.gmail.com> (raw) In-Reply-To: <20130308.105519.82764856.d.hatayama@jp.fujitsu.com> 2013/3/8 HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>: > From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> > Subject: Re: [PATCH v2 15/20] kexec: fill note buffers by NT_VMCORE_PAD notes in page-size boundary > Date: Thu, 7 Mar 2013 18:11:30 +0800 > >> 于 2013年03月02日 16:37, HATAYAMA Daisuke 写道: >>> Fill both crash_notes and vmcoreinfo_note buffers by NT_VMCORE_PAD >>> note type to make them satisfy mmap()'s page-size boundary >>> requirement. >>> >>> So far, end of note segments has been marked by zero-filled elf >>> header. Instead, this patch writes NT_VMCORE_PAD note in the end of >>> note segments until the offset on page-size boundary. >> >> >> In the codes below, it seems that you assign name "VMCOREINFO" for >> note type NT_VMCORE_PAD, right? This is kind of wired, i think. This >> name has been used for NT_VMCORE_DEBUGINFO note already. Why not something >> like "VMCOREPAD" or "PAD"? >> > > It looks you are confusing or don't know name and type. The name is > namespace and in the namespace, there are multiple note types, each of > which has the corresponding data. In other words, data corresponding > to types differ if they belong to differnet name space even if > integers of the types are coincide with. Yes, I knew this. Just as the spec said " a program must recognize both the name and the type to recognize a descriptor.". But I cannot understand what your word "namespace" came from? I think you complicate simple things here. Only with a type, we cannot recognize a descriptor, because "multiple interpretations of a single type value may exist", So we should combine the name and the type together. If both the name and type of two descriptors are the same, we could say we have two same descriptors. If one of them (type or name) are different, we say the two descriptors are different and the two notes have different data. If I am wrong, please correct me. > > The "VMCOREINFO" name represents information exported from > /proc/vmcore that is used in kdump framework. In this sense, > NT_VMCORE_PAD that is specific for /proc/vmcore and kdump framework, > should belong to the "VMCOREINFO" name. I cannot understand the name explanation totally. Does the name really have this meaning? Is there any authentic document? I was always thinking we could feel free to name a name by ourselves! > > Thanks. > HATAYAMA, Daisuke > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-03-08 13:02 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-02 8:35 [PATCH v2 00/20] kdump, vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke 2013-03-02 8:35 ` HATAYAMA Daisuke 2013-03-02 8:35 ` [PATCH v2 01/20] vmcore: refer to e_phoff member explicitly HATAYAMA Daisuke 2013-03-02 8:35 ` HATAYAMA Daisuke 2013-03-05 7:35 ` Zhang Yanfei 2013-03-05 7:35 ` Zhang Yanfei 2013-03-10 6:46 ` Zhang Yanfei 2013-03-10 6:46 ` Zhang Yanfei 2013-03-11 0:31 ` HATAYAMA Daisuke 2013-03-11 0:31 ` HATAYAMA Daisuke 2013-03-11 17:36 ` Vivek Goyal 2013-03-11 17:36 ` Vivek Goyal 2013-03-02 8:35 ` [PATCH v2 02/20] vmcore: rearrange program headers without assuming consequtive PT_NOTE entries HATAYAMA Daisuke 2013-03-02 8:35 ` HATAYAMA Daisuke 2013-03-05 8:36 ` Zhang Yanfei 2013-03-05 8:36 ` Zhang Yanfei 2013-03-05 9:02 ` HATAYAMA Daisuke 2013-03-05 9:02 ` HATAYAMA Daisuke 2013-03-05 9:35 ` Zhang Yanfei 2013-03-05 9:35 ` Zhang Yanfei 2013-03-02 8:36 ` [PATCH v2 03/20] vmcore, sysfs: export ELF note segment size instead of vmcoreinfo data size HATAYAMA Daisuke 2013-03-02 8:36 ` HATAYAMA Daisuke 2013-03-05 9:29 ` Zhang Yanfei 2013-03-05 9:29 ` Zhang Yanfei 2013-03-06 0:07 ` HATAYAMA Daisuke 2013-03-06 0:07 ` HATAYAMA Daisuke 2013-03-02 8:36 ` [PATCH v2 04/20] vmcore: allocate buffer for ELF headers on page-size alignment HATAYAMA Daisuke 2013-03-02 8:36 ` HATAYAMA Daisuke 2013-03-06 6:57 ` Zhang Yanfei 2013-03-06 6:57 ` Zhang Yanfei 2013-03-06 9:14 ` HATAYAMA Daisuke 2013-03-06 9:14 ` HATAYAMA Daisuke 2013-03-02 8:36 ` [PATCH v2 05/20] vmcore: round up buffer size of ELF headers by PAGE_SIZE HATAYAMA Daisuke 2013-03-02 8:36 ` HATAYAMA Daisuke 2013-03-06 15:51 ` Yanfei Zhang 2013-03-06 15:51 ` Yanfei Zhang 2013-03-02 8:36 ` [PATCH v2 06/20] vmcore, procfs: introduce a flag to distinguish objects copied in 2nd kernel HATAYAMA Daisuke 2013-03-02 8:36 ` HATAYAMA Daisuke 2013-03-06 15:55 ` Yanfei Zhang 2013-03-06 15:55 ` Yanfei Zhang 2013-03-02 8:36 ` [PATCH v2 07/20] vmcore: copy non page-size aligned head and tail pages " HATAYAMA Daisuke 2013-03-02 8:36 ` HATAYAMA Daisuke 2013-03-10 6:16 ` Zhang Yanfei 2013-03-10 6:16 ` Zhang Yanfei 2013-03-11 0:27 ` HATAYAMA Daisuke 2013-03-11 0:27 ` HATAYAMA Daisuke 2013-03-02 8:36 ` [PATCH v2 08/20] vmcore: modify vmcore clean-up function to free buffer on " HATAYAMA Daisuke 2013-03-02 8:36 ` HATAYAMA Daisuke 2013-03-02 8:36 ` [PATCH v2 09/20] vmcore: clean up read_vmcore() HATAYAMA Daisuke 2013-03-02 8:36 ` HATAYAMA Daisuke 2013-03-02 8:36 ` [PATCH v2 10/20] vmcore: read buffers for vmcore objects copied from old memory HATAYAMA Daisuke 2013-03-02 8:36 ` HATAYAMA Daisuke 2013-03-02 8:36 ` [PATCH v2 11/20] vmcore: allocate per-cpu crash_notes objects on page-size boundary HATAYAMA Daisuke 2013-03-02 8:36 ` HATAYAMA Daisuke 2013-03-02 8:36 ` [PATCH v2 12/20] kexec: allocate vmcoreinfo note buffer " HATAYAMA Daisuke 2013-03-02 8:36 ` HATAYAMA Daisuke 2013-03-02 8:37 ` [PATCH v2 13/20] kexec, elf: introduce NT_VMCORE_DEBUGINFO note type HATAYAMA Daisuke 2013-03-02 8:37 ` HATAYAMA Daisuke 2013-03-02 8:37 ` [PATCH v2 14/20] elf: introduce NT_VMCORE_PAD type HATAYAMA Daisuke 2013-03-02 8:37 ` HATAYAMA Daisuke 2013-03-02 8:37 ` [PATCH v2 15/20] kexec: fill note buffers by NT_VMCORE_PAD notes in page-size boundary HATAYAMA Daisuke 2013-03-02 8:37 ` HATAYAMA Daisuke 2013-03-07 10:11 ` Zhang Yanfei 2013-03-07 10:11 ` Zhang Yanfei 2013-03-08 1:55 ` HATAYAMA Daisuke 2013-03-08 1:55 ` HATAYAMA Daisuke 2013-03-08 13:02 ` Yanfei Zhang [this message] 2013-03-08 13:02 ` Yanfei Zhang 2013-03-09 3:46 ` HATAYAMA Daisuke 2013-03-09 3:46 ` HATAYAMA Daisuke 2013-03-10 2:33 ` Zhang Yanfei 2013-03-10 2:33 ` Zhang Yanfei 2013-03-02 8:37 ` [PATCH v2 16/20] vmcore: check NT_VMCORE_PAD as a mark indicating the end of ELF note buffer HATAYAMA Daisuke 2013-03-02 8:37 ` HATAYAMA Daisuke 2013-03-02 8:37 ` [PATCH v2 17/20] vmcore: check if vmcore objects satify mmap()'s page-size boundary requirement HATAYAMA Daisuke 2013-03-02 8:37 ` HATAYAMA Daisuke 2013-03-02 8:37 ` [PATCH v2 18/20] vmcore: round-up offset of vmcore object in page-size boundary HATAYAMA Daisuke 2013-03-02 8:37 ` HATAYAMA Daisuke 2013-03-02 8:37 ` [PATCH v2 19/20] vmcore: count holes generated by round-up operation for vmcore size HATAYAMA Daisuke 2013-03-02 8:37 ` HATAYAMA Daisuke 2013-03-02 8:37 ` [PATCH v2 20/20] vmcore: introduce mmap_vmcore() HATAYAMA Daisuke 2013-03-02 8:37 ` HATAYAMA Daisuke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CANBD6kFwTjKL9CqUzVSWFSRH6ibdQstCU5wTBkv4+=4HhPiG4Q@mail.gmail.com' \ --to=zhangyanfei.yes@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=cpw@sgi.com \ --cc=d.hatayama@jp.fujitsu.com \ --cc=ebiederm@xmission.com \ --cc=heiko.carstens@de.ibm.com \ --cc=kexec@lists.infradead.org \ --cc=kumagai-atsushi@mxc.nes.nec.co.jp \ --cc=linux-kernel@vger.kernel.org \ --cc=lisa.mitchell@hp.com \ --cc=vgoyal@redhat.com \ --cc=zhangyanfei@cn.fujitsu.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.