From: Markus Mayer <code@mmayer.net>
To: "Rafał Miłecki" <rafal@milecki.pl>
Cc: Markus Mayer <code@mmayer.net>, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Doug Berger <opendmb@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
Power Management List <linux-pm@vger.kernel.org>,
Device Tree List <devicetree@vger.kernel.org>,
ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Markus Mayer <mmayer@broadcom.com>
Subject: Re: [PATCH 1/2] Documentation: devicetree: add binding for Broadcom STB AVS TMON
Date: Tue, 6 Jun 2017 10:07:08 -0700 [thread overview]
Message-ID: <CANEuBv6y+FD86oH7hHctjrt=5Oh_4_iitgNHLppMOPt=D5yXig@mail.gmail.com> (raw)
In-Reply-To: <e5da2edfae3bd593fd7819db1d7e2337@milecki.pl>
On 6 June 2017 at 05:21, Rafał Miłecki <rafal@milecki.pl> wrote:
> On 2017-06-05 23:09, Markus Mayer wrote:
>>
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/thermal/brcm,avs-tmon.txt
>> @@ -0,0 +1,20 @@
>> +* Broadcom STB thermal management
>> +
>> +Thermal management core, provided by the AVS TMON hardware block.
>> +
>> +Required properties:
>> +- compatible: must be one of "brcm,avs-tmon" or "brcm,avs-tmon-bcm7445"
>
>
> Is the "one of" correct here? I'm not native English but it sounds like
> setting both is a wrong thing.
You are right. It should not say "one of". I'll fix the wording.
>> +- reg: address range for the AVS TMON registers
>> +- interrupts: temperature monitor interrupt, for high/low threshold
>> triggers
>> +- interrupt-names: should be "tmon"
>> +- interrupt-parent: the parent interrupt controller
>> +
>> +Example:
>> +
>> + thermal@f04d1500 {
>> + compatible = "brcm,avs-tmon-bcm7445", "brcm,avs-tmon";
>
>
> Yet here you use both bindings.
WARNING: multiple messages have this Message-ID (diff)
From: code@mmayer.net (Markus Mayer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] Documentation: devicetree: add binding for Broadcom STB AVS TMON
Date: Tue, 6 Jun 2017 10:07:08 -0700 [thread overview]
Message-ID: <CANEuBv6y+FD86oH7hHctjrt=5Oh_4_iitgNHLppMOPt=D5yXig@mail.gmail.com> (raw)
In-Reply-To: <e5da2edfae3bd593fd7819db1d7e2337@milecki.pl>
On 6 June 2017 at 05:21, Rafa? Mi?ecki <rafal@milecki.pl> wrote:
> On 2017-06-05 23:09, Markus Mayer wrote:
>>
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/thermal/brcm,avs-tmon.txt
>> @@ -0,0 +1,20 @@
>> +* Broadcom STB thermal management
>> +
>> +Thermal management core, provided by the AVS TMON hardware block.
>> +
>> +Required properties:
>> +- compatible: must be one of "brcm,avs-tmon" or "brcm,avs-tmon-bcm7445"
>
>
> Is the "one of" correct here? I'm not native English but it sounds like
> setting both is a wrong thing.
You are right. It should not say "one of". I'll fix the wording.
>> +- reg: address range for the AVS TMON registers
>> +- interrupts: temperature monitor interrupt, for high/low threshold
>> triggers
>> +- interrupt-names: should be "tmon"
>> +- interrupt-parent: the parent interrupt controller
>> +
>> +Example:
>> +
>> + thermal at f04d1500 {
>> + compatible = "brcm,avs-tmon-bcm7445", "brcm,avs-tmon";
>
>
> Yet here you use both bindings.
next prev parent reply other threads:[~2017-06-06 17:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 21:09 [PATCH 0/2] thermal: add brcmstb AVS TMON driver Markus Mayer
2017-06-05 21:09 ` Markus Mayer
2017-06-05 21:09 ` Markus Mayer
2017-06-05 21:09 ` [PATCH 1/2] Documentation: devicetree: add binding for Broadcom STB AVS TMON Markus Mayer
2017-06-05 21:09 ` Markus Mayer
2017-06-06 12:21 ` Rafał Miłecki
2017-06-06 12:21 ` Rafał Miłecki
2017-06-06 12:21 ` Rafał Miłecki
2017-06-06 17:07 ` Markus Mayer [this message]
2017-06-06 17:07 ` Markus Mayer
2017-06-05 21:09 ` [PATCH 2/2] thermal: add brcmstb AVS TMON driver Markus Mayer
2017-06-05 21:09 ` Markus Mayer
2017-06-05 21:09 ` Markus Mayer
2017-06-06 7:50 ` [PATCH] thermal: fix platform_no_drv_owner.cocci warnings kbuild test robot
2017-06-06 7:50 ` kbuild test robot
2017-06-06 7:50 ` kbuild test robot
2017-06-06 7:50 ` [PATCH 2/2] thermal: add brcmstb AVS TMON driver kbuild test robot
2017-06-06 7:50 ` kbuild test robot
2017-06-06 7:50 ` kbuild test robot
2017-06-06 12:27 ` Rafał Miłecki
2017-06-06 12:27 ` Rafał Miłecki
2017-06-06 12:27 ` Rafał Miłecki
2017-06-09 23:07 ` Markus Mayer
2017-06-09 23:07 ` Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANEuBv6y+FD86oH7hHctjrt=5Oh_4_iitgNHLppMOPt=D5yXig@mail.gmail.com' \
--to=code@mmayer.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mmayer@broadcom.com \
--cc=opendmb@gmail.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.