From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Adrian Hunter <adrian.hunter@intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH V8 23/23] perf tools: adding coresight etm PMU record capabilities Date: Wed, 3 Feb 2016 09:11:57 -0700 [thread overview] Message-ID: <CANLsYkwtT7VbLJaW+jsC+X0151znDsu6rLio4f5Fg-dyY2xJtQ@mail.gmail.com> (raw) In-Reply-To: <20160202164129.GE32488@kernel.org> On 2 February 2016 at 09:41, Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Em Tue, Feb 02, 2016 at 09:20:51AM -0700, Mathieu Poirier escreveu: >> [...] >> >> >>> > >> >>> > Looks OK, apart from adding linux/coresight-pmu.h to the manifest, but I >> >>> > mentioned that on another patch. >> >>> > >> >>> > However there is no decoder, which begs the question, is there anything you >> >>> > can actually do with the perf.data file? Might be a bit confusing for users >> >>> > if they can capture traces but not use perf tools on the resulting perf.data >> >>> > file? >> >>> >> >>> We are working on a decoding library in parallel to this work. >> >> >> >> Would be nice to be able to get both in the same patch kit, no? So that >> >> one can both record and process the traces, verifying it all works. >> > >> > We are still a few weeks away from being in a position where the >> > community can start playing with the decoding library. I can hold off >> > on the "perf tools" patches when I queue the kernel side of the work >> > for 4.6 but since you and Adrian have already reviewed the work it >> > would be nice to have that part included as well. >> > >> > We've been playing with the perf.data files for a couple of months now >> > and things look at the right place. This isn't surprising since we >> > are using the same framework as X86. >> > >> > I think the generation of the perf.data file should be coupled with >> > the submission of the kernel driver but would also respect a diverging >> > point of view. Simply let me know what you prefer and I will adjust >> > V9 accordingly. >> >> Arnaldo, >> >> I'm preparing V9 at this time - what's your view on the above? > > I'd say go with something we can test, i.e. if we generate a perf.data > file we can't then process to figure out if what was inserted is right, > how can we decide if it is ok? Very well - I'll hold off on the perf tools patches for now. We can make a submission of all the user space components when things are in a working order. Mathieu > > Otherwise please describe how you test it, preferably by having this in > the commit log, i.e. if you decide that using plain 'perf report -D' is > enough, state that and show the output, etc. > > - Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: mathieu.poirier@linaro.org (Mathieu Poirier) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V8 23/23] perf tools: adding coresight etm PMU record capabilities Date: Wed, 3 Feb 2016 09:11:57 -0700 [thread overview] Message-ID: <CANLsYkwtT7VbLJaW+jsC+X0151znDsu6rLio4f5Fg-dyY2xJtQ@mail.gmail.com> (raw) In-Reply-To: <20160202164129.GE32488@kernel.org> On 2 February 2016 at 09:41, Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Em Tue, Feb 02, 2016 at 09:20:51AM -0700, Mathieu Poirier escreveu: >> [...] >> >> >>> > >> >>> > Looks OK, apart from adding linux/coresight-pmu.h to the manifest, but I >> >>> > mentioned that on another patch. >> >>> > >> >>> > However there is no decoder, which begs the question, is there anything you >> >>> > can actually do with the perf.data file? Might be a bit confusing for users >> >>> > if they can capture traces but not use perf tools on the resulting perf.data >> >>> > file? >> >>> >> >>> We are working on a decoding library in parallel to this work. >> >> >> >> Would be nice to be able to get both in the same patch kit, no? So that >> >> one can both record and process the traces, verifying it all works. >> > >> > We are still a few weeks away from being in a position where the >> > community can start playing with the decoding library. I can hold off >> > on the "perf tools" patches when I queue the kernel side of the work >> > for 4.6 but since you and Adrian have already reviewed the work it >> > would be nice to have that part included as well. >> > >> > We've been playing with the perf.data files for a couple of months now >> > and things look at the right place. This isn't surprising since we >> > are using the same framework as X86. >> > >> > I think the generation of the perf.data file should be coupled with >> > the submission of the kernel driver but would also respect a diverging >> > point of view. Simply let me know what you prefer and I will adjust >> > V9 accordingly. >> >> Arnaldo, >> >> I'm preparing V9 at this time - what's your view on the above? > > I'd say go with something we can test, i.e. if we generate a perf.data > file we can't then process to figure out if what was inserted is right, > how can we decide if it is ok? Very well - I'll hold off on the perf tools patches for now. We can make a submission of all the user space components when things are in a working order. Mathieu > > Otherwise please describe how you test it, preferably by having this in > the commit log, i.e. if you decide that using plain 'perf report -D' is > enough, state that and show the output, etc. > > - Arnaldo
next prev parent reply other threads:[~2016-02-03 16:12 UTC|newest] Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-14 21:45 [PATCH V8 00/23] Coresight integration with perf Mathieu Poirier 2016-01-14 21:45 ` Mathieu Poirier 2016-01-14 21:45 ` [PATCH V8 01/23] coresight: associating path with session rather than tracer Mathieu Poirier 2016-01-14 21:45 ` Mathieu Poirier 2016-01-14 21:45 ` [PATCH V8 02/23] coresight: add API to get sink from path Mathieu Poirier 2016-01-14 21:45 ` Mathieu Poirier 2016-01-14 21:45 ` [PATCH V8 03/23] coresight: moving PM runtime operations to core framework Mathieu Poirier 2016-01-14 21:45 ` Mathieu Poirier 2016-01-14 21:45 ` [PATCH V8 04/23] coresight: etm3x: moving etm_readl/writel to header file Mathieu Poirier 2016-01-14 21:45 ` Mathieu Poirier 2016-01-14 21:45 ` [PATCH V8 05/23] coresight: etm3x: moving sysFS entries to dedicated file Mathieu Poirier 2016-01-14 21:45 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 06/23] coresight: etm3x: unlocking tracers in default arch init Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 07/23] coresight: etm3x: splitting struct etm_drvdata Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 08/23] coresight: etm3x: adding operation mode for etm_enable() Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 09/23] coresight: etm3x: set progbit to stop trace collection Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 10/23] coresight: etm3x: changing default trace configuration Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 11/23] coresight: etm3x: consolidating initial config Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 12/23] coresight: etm3x: implementing user/kernel mode tracing Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 13/23] coresight: etm3x: implementing perf_enable/disable() API Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 14/23] coresight: etb10: moving to local atomic operations Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 15/23] coresight: etb10: adding operation mode for sink->enable() Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 16/23] coresight: etb10: implementing AUX API Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-26 15:53 ` Alexander Shishkin 2016-01-26 15:53 ` Alexander Shishkin 2016-01-27 20:55 ` Mathieu Poirier 2016-01-27 20:55 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 17/23] coresight: updating documentation to reflect integration with perf Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 18/23] coresight: etm-perf: new PMU driver for ETM tracers Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-26 15:27 ` Alexander Shishkin 2016-01-26 15:27 ` Alexander Shishkin 2016-01-27 18:33 ` Mathieu Poirier 2016-01-27 18:33 ` Mathieu Poirier 2016-01-28 15:42 ` Alexander Shishkin 2016-01-28 15:42 ` Alexander Shishkin 2016-01-28 21:12 ` Mathieu Poirier 2016-01-28 21:12 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 19/23] coresight: introducing a global trace ID function Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 20/23] perf tools: making function set_max_cpu_num() non static Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-25 20:46 ` Mathieu Poirier 2016-01-25 20:46 ` Mathieu Poirier 2016-01-25 21:12 ` Arnaldo Carvalho de Melo 2016-01-25 21:12 ` Arnaldo Carvalho de Melo 2016-01-25 21:29 ` Arnaldo Carvalho de Melo 2016-01-25 21:29 ` Arnaldo Carvalho de Melo 2016-01-26 17:08 ` Mathieu Poirier 2016-01-26 17:08 ` Mathieu Poirier 2016-01-26 18:51 ` Arnaldo Carvalho de Melo 2016-01-26 18:51 ` Arnaldo Carvalho de Melo 2016-01-27 16:24 ` Mathieu Poirier 2016-01-27 16:24 ` Mathieu Poirier 2016-02-03 10:15 ` [tip:perf/core] perf cpumap: Auto initialize cpu__max_{node,cpu} tip-bot for Arnaldo Carvalho de Melo 2016-01-14 21:46 ` [PATCH V8 21/23] perf tools: adding perf_evlist to *info_priv_size() Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-25 20:48 ` Mathieu Poirier 2016-01-25 20:48 ` Mathieu Poirier 2016-01-25 21:08 ` Arnaldo Carvalho de Melo 2016-01-25 21:08 ` Arnaldo Carvalho de Melo 2016-01-26 14:27 ` Adrian Hunter 2016-01-26 14:27 ` Adrian Hunter 2016-01-26 14:33 ` Arnaldo Carvalho de Melo 2016-01-26 14:33 ` Arnaldo Carvalho de Melo 2016-01-29 10:14 ` Adrian Hunter 2016-01-29 10:14 ` Adrian Hunter 2016-02-03 10:17 ` [tip:perf/core] perf auxtrace: Add perf_evlist pointer " tip-bot for Mathieu Poirier 2016-01-14 21:46 ` [PATCH V8 22/23] perf tools: making coresight PMU listable Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-25 20:49 ` Mathieu Poirier 2016-01-25 20:49 ` Mathieu Poirier 2016-01-25 21:10 ` Arnaldo Carvalho de Melo 2016-01-25 21:10 ` Arnaldo Carvalho de Melo 2016-01-29 10:24 ` Adrian Hunter 2016-01-29 10:24 ` Adrian Hunter 2016-01-14 21:46 ` [PATCH V8 23/23] perf tools: adding coresight etm PMU record capabilities Mathieu Poirier 2016-01-14 21:46 ` Mathieu Poirier 2016-01-25 20:51 ` Mathieu Poirier 2016-01-25 20:51 ` Mathieu Poirier 2016-01-25 21:10 ` Arnaldo Carvalho de Melo 2016-01-25 21:10 ` Arnaldo Carvalho de Melo 2016-01-29 10:34 ` Adrian Hunter 2016-01-29 10:34 ` Adrian Hunter 2016-01-29 17:37 ` Mathieu Poirier 2016-01-29 17:37 ` Mathieu Poirier 2016-01-29 21:12 ` Arnaldo Carvalho de Melo 2016-01-29 21:12 ` Arnaldo Carvalho de Melo 2016-01-29 22:24 ` Mathieu Poirier 2016-01-29 22:24 ` Mathieu Poirier 2016-02-02 16:20 ` Mathieu Poirier 2016-02-02 16:20 ` Mathieu Poirier 2016-02-02 16:41 ` Arnaldo Carvalho de Melo 2016-02-02 16:41 ` Arnaldo Carvalho de Melo 2016-02-03 16:11 ` Mathieu Poirier [this message] 2016-02-03 16:11 ` Mathieu Poirier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CANLsYkwtT7VbLJaW+jsC+X0151znDsu6rLio4f5Fg-dyY2xJtQ@mail.gmail.com \ --to=mathieu.poirier@linaro.org \ --cc=acme@kernel.org \ --cc=adrian.hunter@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.