From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Leo Yan <leo.yan@linaro.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Mike Leach <mike.leach@linaro.org>, Rob Herring <robh+dt@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, devicetree@vger.kernel.org, David Brown <david.brown@linaro.org>, Mark Rutland <mark.rutland@arm.com>, Rajendra Nayak <rnayak@codeaurora.org>, Vivek Gautam <vivek.gautam@codeaurora.org>, Sibi Sankar <sibis@codeaurora.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Marc Gonzalez <marc.w.gonzalez@free.fr> Subject: Re: [PATCHv8 3/5] arm64: dts: qcom: msm8996: Add Coresight support Date: Thu, 18 Jul 2019 09:31:00 -0600 [thread overview] Message-ID: <CANLsYkx9X36OJmczNK1255y8fKJfkyVq1zyQUDihqMewcU6Kxw@mail.gmail.com> (raw) In-Reply-To: <f28d9c8f-017c-c990-2f00-0ef5a62f3b40@codeaurora.org> On Wed, 17 Jul 2019 at 23:47, Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> wrote: > > Hi Mathieu, > > On 7/17/2019 10:30 PM, Mathieu Poirier wrote: > > On Fri, Jul 12, 2019 at 07:46:25PM +0530, Sai Prakash Ranjan wrote: > >> From: Vivek Gautam <vivek.gautam@codeaurora.org> > >> > >> Enable coresight support by adding device nodes for the > >> available source, sinks and channel blocks on msm8996. > >> > >> This also adds coresight cpu debug nodes. > >> > >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > >> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > >> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > >> Acked-By: Suzuki K Poulose <suzuki.poulose@arm.com> > >> --- > >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 434 ++++++++++++++++++++++++++ > >> 1 file changed, 434 insertions(+) > >> > > > > We've gone trhough 8 iteration of this set and I'm still finding checkpatch > > problems, and I'm not referring to lines over 80 characters. > > > > I only get below 2 checkpatch warnings: > > If you are talking about the below one, then it was not added manually. > It was taken automatically when I pulled in the v7. Should I be > resending this patch for this? That depends if you want David and Andy to pickup your patches - I am sure they'll point out exactly the same thing. > > $ ./scripts/checkpatch.pl -g 2fa725fbc09306f1a95befc62715a708b4c0fad0 > WARNING: 'Acked-by:' is the preferred signature form > #14: > Acked-By: Suzuki K Poulose <suzuki.poulose@arm.com> > > WARNING: line over 80 characters > #154: FILE: arch/arm64/boot/dts/qcom/msm8996.dtsi:763: > + compatible = "arm,coresight-dynamic-replicator", > "arm,primecell"; > > total: 0 errors, 2 warnings, 440 lines checked > > > -Sai > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Rajendra Nayak <rnayak@codeaurora.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Marc Gonzalez <marc.w.gonzalez@free.fr>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, David Brown <david.brown@linaro.org>, Rob Herring <robh+dt@kernel.org>, Sibi Sankar <sibis@codeaurora.org>, Vivek Gautam <vivek.gautam@codeaurora.org>, Leo Yan <leo.yan@linaro.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Mike Leach <mike.leach@linaro.org> Subject: Re: [PATCHv8 3/5] arm64: dts: qcom: msm8996: Add Coresight support Date: Thu, 18 Jul 2019 09:31:00 -0600 [thread overview] Message-ID: <CANLsYkx9X36OJmczNK1255y8fKJfkyVq1zyQUDihqMewcU6Kxw@mail.gmail.com> (raw) In-Reply-To: <f28d9c8f-017c-c990-2f00-0ef5a62f3b40@codeaurora.org> On Wed, 17 Jul 2019 at 23:47, Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> wrote: > > Hi Mathieu, > > On 7/17/2019 10:30 PM, Mathieu Poirier wrote: > > On Fri, Jul 12, 2019 at 07:46:25PM +0530, Sai Prakash Ranjan wrote: > >> From: Vivek Gautam <vivek.gautam@codeaurora.org> > >> > >> Enable coresight support by adding device nodes for the > >> available source, sinks and channel blocks on msm8996. > >> > >> This also adds coresight cpu debug nodes. > >> > >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > >> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > >> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > >> Acked-By: Suzuki K Poulose <suzuki.poulose@arm.com> > >> --- > >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 434 ++++++++++++++++++++++++++ > >> 1 file changed, 434 insertions(+) > >> > > > > We've gone trhough 8 iteration of this set and I'm still finding checkpatch > > problems, and I'm not referring to lines over 80 characters. > > > > I only get below 2 checkpatch warnings: > > If you are talking about the below one, then it was not added manually. > It was taken automatically when I pulled in the v7. Should I be > resending this patch for this? That depends if you want David and Andy to pickup your patches - I am sure they'll point out exactly the same thing. > > $ ./scripts/checkpatch.pl -g 2fa725fbc09306f1a95befc62715a708b4c0fad0 > WARNING: 'Acked-by:' is the preferred signature form > #14: > Acked-By: Suzuki K Poulose <suzuki.poulose@arm.com> > > WARNING: line over 80 characters > #154: FILE: arch/arm64/boot/dts/qcom/msm8996.dtsi:763: > + compatible = "arm,coresight-dynamic-replicator", > "arm,primecell"; > > total: 0 errors, 2 warnings, 440 lines checked > > > -Sai > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-18 15:31 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-12 14:16 [PATCHv8 0/5] Add coresight support for SDM845, MSM8998 and MSM8996 Sai Prakash Ranjan 2019-07-12 14:16 ` Sai Prakash Ranjan 2019-07-12 14:16 ` [PATCHv8 1/5] arm64: dts: qcom: sdm845: Add Coresight support Sai Prakash Ranjan 2019-07-12 14:16 ` Sai Prakash Ranjan 2019-07-12 16:44 ` Suzuki K Poulose 2019-07-12 16:44 ` Suzuki K Poulose 2019-07-12 16:49 ` saiprakash.ranjan 2019-07-12 16:49 ` saiprakash.ranjan 2019-07-19 9:46 ` Suzuki K Poulose 2019-07-19 9:46 ` Suzuki K Poulose 2019-07-19 10:28 ` Sai Prakash Ranjan 2019-07-19 10:28 ` Sai Prakash Ranjan 2019-07-12 14:16 ` [PATCHv8 2/5] arm64: dts: qcom: msm8998: " Sai Prakash Ranjan 2019-07-12 14:16 ` Sai Prakash Ranjan 2019-07-18 8:28 ` Suzuki K Poulose 2019-07-18 8:28 ` Suzuki K Poulose 2019-07-18 9:14 ` Sai Prakash Ranjan 2019-07-18 9:14 ` Sai Prakash Ranjan 2019-07-18 9:37 ` Suzuki K Poulose 2019-07-18 9:37 ` Suzuki K Poulose 2019-07-18 9:53 ` Sai Prakash Ranjan 2019-07-18 9:53 ` Sai Prakash Ranjan 2019-07-12 14:16 ` [PATCHv8 3/5] arm64: dts: qcom: msm8996: " Sai Prakash Ranjan 2019-07-12 14:16 ` Sai Prakash Ranjan 2019-07-17 17:00 ` Mathieu Poirier 2019-07-17 17:00 ` Mathieu Poirier 2019-07-18 5:47 ` Sai Prakash Ranjan 2019-07-18 5:47 ` Sai Prakash Ranjan 2019-07-18 15:31 ` Mathieu Poirier [this message] 2019-07-18 15:31 ` Mathieu Poirier 2019-07-18 15:48 ` Bjorn Andersson 2019-07-18 15:48 ` Bjorn Andersson 2019-07-12 14:16 ` [PATCHv8 4/5] coresight: etm4x: Add ETM PIDs for SDM845 and MSM8996 Sai Prakash Ranjan 2019-07-12 14:16 ` Sai Prakash Ranjan 2019-07-17 17:40 ` Mathieu Poirier 2019-07-17 17:40 ` Mathieu Poirier 2019-07-12 14:16 ` [PATCHv8 5/5] coresight: cpu-debug: Add support for Qualcomm Kryo Sai Prakash Ranjan 2019-07-12 14:16 ` Sai Prakash Ranjan 2019-07-17 16:56 ` Mathieu Poirier 2019-07-17 16:56 ` Mathieu Poirier 2019-07-21 14:35 ` Leo Yan 2019-07-21 14:35 ` Leo Yan 2019-07-22 5:48 ` Sai Prakash Ranjan 2019-07-22 5:48 ` Sai Prakash Ranjan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CANLsYkx9X36OJmczNK1255y8fKJfkyVq1zyQUDihqMewcU6Kxw@mail.gmail.com \ --to=mathieu.poirier@linaro.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=bjorn.andersson@linaro.org \ --cc=david.brown@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.w.gonzalez@free.fr \ --cc=mark.rutland@arm.com \ --cc=mike.leach@linaro.org \ --cc=rnayak@codeaurora.org \ --cc=robh+dt@kernel.org \ --cc=saiprakash.ranjan@codeaurora.org \ --cc=sibis@codeaurora.org \ --cc=suzuki.poulose@arm.com \ --cc=vivek.gautam@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.