From: Mathieu Poirier <mathieu.poirier@linaro.org> To: brueckner@linux.ibm.com Cc: Peter Zijlstra <peterz@infradead.org>, Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, Will Deacon <will.deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, ast@kernel.org, Greg KH <gregkh@linuxfoundation.org>, "H. Peter Anvin" <hpa@zytor.com>, linux-s390@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 4/6] perf/aux: Make perf_event accessible to setup_aux() Date: Tue, 3 Jul 2018 11:37:17 -0600 [thread overview] Message-ID: <CANLsYkxHws7JRCU9EfGsK3wQxugP5w8aVTTja=fBRn1=TqETMA@mail.gmail.com> (raw) In-Reply-To: <20180703073142.GA4581@linux.ibm.com> On Tue, 3 Jul 2018 at 01:31, Hendrik Brueckner <brueckner@linux.ibm.com> wrote: > > On Mon, Jul 02, 2018 at 04:33:28PM -0600, Mathieu Poirier wrote: > > It can be advantagous to have access to all the information conveyed by > > a perf_event when setting up the AUX buffer, as it is the case when > > dealing with PMU specific driver configuration communicated to the kernel > > using an ioctl() call. > > > > As such simply replace the cpu information by the complete perf_event > > structure and change all affected customers. > > > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > --- > > arch/s390/kernel/perf_cpum_sf.c | 4 ++-- > > arch/x86/events/intel/bts.c | 4 +++- > > arch/x86/events/intel/pt.c | 5 +++-- > > drivers/hwtracing/coresight/coresight-etm-perf.c | 6 +++--- > > drivers/perf/arm_spe_pmu.c | 6 +++--- > > include/linux/perf_event.h | 2 +- > > kernel/events/ring_buffer.c | 2 +- > > 7 files changed, 16 insertions(+), 13 deletions(-) > > > > diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c > > index 0292d68e7dde..e06daaa08894 100644 > > --- a/arch/s390/kernel/perf_cpum_sf.c > > +++ b/arch/s390/kernel/perf_cpum_sf.c > > @@ -1601,8 +1601,8 @@ static void aux_buffer_free(void *data) > > * > > * Return the private AUX buffer structure if success or NULL if fails. > > */ > > -static void *aux_buffer_setup(int cpu, void **pages, int nr_pages, > > - bool snapshot) > > +static void *aux_buffer_setup(struct perf_event *event, void **pages, > > + int nr_pages, bool snapshot); > > Please remove the trailing semi-colon (;) in the function definition causing > the kbuild error. Also, it would be great if you also could update the > function comment and replace the @cpu by the @event. Had I realised it was just as easy to compile for s390 as it is for ARM64, I would have done so ahead of time. Well done on that front. All fixed now. Thanks, Mathieu > > Many thanks. >
WARNING: multiple messages have this Message-ID (diff)
From: mathieu.poirier@linaro.org (Mathieu Poirier) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/6] perf/aux: Make perf_event accessible to setup_aux() Date: Tue, 3 Jul 2018 11:37:17 -0600 [thread overview] Message-ID: <CANLsYkxHws7JRCU9EfGsK3wQxugP5w8aVTTja=fBRn1=TqETMA@mail.gmail.com> (raw) In-Reply-To: <20180703073142.GA4581@linux.ibm.com> On Tue, 3 Jul 2018 at 01:31, Hendrik Brueckner <brueckner@linux.ibm.com> wrote: > > On Mon, Jul 02, 2018 at 04:33:28PM -0600, Mathieu Poirier wrote: > > It can be advantagous to have access to all the information conveyed by > > a perf_event when setting up the AUX buffer, as it is the case when > > dealing with PMU specific driver configuration communicated to the kernel > > using an ioctl() call. > > > > As such simply replace the cpu information by the complete perf_event > > structure and change all affected customers. > > > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > --- > > arch/s390/kernel/perf_cpum_sf.c | 4 ++-- > > arch/x86/events/intel/bts.c | 4 +++- > > arch/x86/events/intel/pt.c | 5 +++-- > > drivers/hwtracing/coresight/coresight-etm-perf.c | 6 +++--- > > drivers/perf/arm_spe_pmu.c | 6 +++--- > > include/linux/perf_event.h | 2 +- > > kernel/events/ring_buffer.c | 2 +- > > 7 files changed, 16 insertions(+), 13 deletions(-) > > > > diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c > > index 0292d68e7dde..e06daaa08894 100644 > > --- a/arch/s390/kernel/perf_cpum_sf.c > > +++ b/arch/s390/kernel/perf_cpum_sf.c > > @@ -1601,8 +1601,8 @@ static void aux_buffer_free(void *data) > > * > > * Return the private AUX buffer structure if success or NULL if fails. > > */ > > -static void *aux_buffer_setup(int cpu, void **pages, int nr_pages, > > - bool snapshot) > > +static void *aux_buffer_setup(struct perf_event *event, void **pages, > > + int nr_pages, bool snapshot); > > Please remove the trailing semi-colon (;) in the function definition causing > the kbuild error. Also, it would be great if you also could update the > function comment and replace the @cpu by the @event. Had I realised it was just as easy to compile for s390 as it is for ARM64, I would have done so ahead of time. Well done on that front. All fixed now. Thanks, Mathieu > > Many thanks. >
next prev parent reply other threads:[~2018-07-03 17:37 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-02 22:33 [PATCH 0/6] perf: Add ioctl for PMU driver configuration Mathieu Poirier 2018-07-02 22:33 ` Mathieu Poirier 2018-07-02 22:33 ` [PATCH 1/6] perf tools: Use ioctl to communicate driver configuration to kernel Mathieu Poirier 2018-07-02 22:33 ` Mathieu Poirier 2018-07-02 22:33 ` [PATCH 2/6] perf tools: Make perf_evsel accessible to PMU driver configuration code Mathieu Poirier 2018-07-02 22:33 ` Mathieu Poirier 2018-07-02 22:33 ` [PATCH 3/6] perf tools: Use ioctl function to send sink configuration to kernel Mathieu Poirier 2018-07-02 22:33 ` Mathieu Poirier 2018-07-02 22:33 ` [PATCH 4/6] perf/aux: Make perf_event accessible to setup_aux() Mathieu Poirier 2018-07-02 22:33 ` Mathieu Poirier 2018-07-03 2:05 ` kbuild test robot 2018-07-03 2:05 ` kbuild test robot 2018-07-03 7:31 ` Hendrik Brueckner 2018-07-03 7:31 ` Hendrik Brueckner 2018-07-03 17:37 ` Mathieu Poirier [this message] 2018-07-03 17:37 ` Mathieu Poirier 2018-07-03 9:27 ` Alexander Shishkin 2018-07-03 9:27 ` Alexander Shishkin 2018-07-02 22:33 ` [PATCH 5/6] perf/core: Use ioctl to communicate driver configuration to kernel Mathieu Poirier 2018-07-02 22:33 ` Mathieu Poirier 2018-07-03 10:03 ` Alexander Shishkin 2018-07-03 10:03 ` Alexander Shishkin 2018-07-03 10:56 ` Alexander Shishkin 2018-07-03 10:56 ` Alexander Shishkin 2018-07-03 22:00 ` Mathieu Poirier 2018-07-03 22:00 ` Mathieu Poirier 2018-07-04 10:34 ` Alexander Shishkin 2018-07-04 10:34 ` Alexander Shishkin 2018-07-04 21:39 ` Mathieu Poirier 2018-07-04 21:39 ` Mathieu Poirier 2018-07-03 20:30 ` Mathieu Poirier 2018-07-03 20:30 ` Mathieu Poirier 2018-07-04 10:51 ` Alexander Shishkin 2018-07-04 10:51 ` Alexander Shishkin 2018-07-03 22:03 ` Mathieu Poirier 2018-07-03 22:03 ` Mathieu Poirier 2018-07-03 13:40 ` Jiri Olsa 2018-07-03 13:40 ` Jiri Olsa 2018-07-03 17:47 ` Mathieu Poirier 2018-07-03 17:47 ` Mathieu Poirier 2018-07-03 13:41 ` Jiri Olsa 2018-07-03 13:41 ` Jiri Olsa 2018-07-02 22:33 ` [PATCH 6/6] coresight: Use PMU driver configuration for sink selection Mathieu Poirier 2018-07-02 22:33 ` Mathieu Poirier 2019-02-05 23:24 [PATCH 0/6] coresight: next v5.0-rc5 Mathieu Poirier 2019-02-05 23:24 ` [PATCH 4/6] perf/aux: Make perf_event accessible to setup_aux() Mathieu Poirier 2019-02-05 23:24 ` Mathieu Poirier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CANLsYkxHws7JRCU9EfGsK3wQxugP5w8aVTTja=fBRn1=TqETMA@mail.gmail.com' \ --to=mathieu.poirier@linaro.org \ --cc=acme@kernel.org \ --cc=adrian.hunter@intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=ast@kernel.org \ --cc=brueckner@linux.ibm.com \ --cc=gregkh@linuxfoundation.org \ --cc=heiko.carstens@de.ibm.com \ --cc=hpa@zytor.com \ --cc=jolsa@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=schwidefsky@de.ibm.com \ --cc=tglx@linutronix.de \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.