* Vexpress TC2 no longer booting on v4.12-rc1 @ 2017-06-02 22:16 ` Mathieu Poirier 0 siblings, 0 replies; 12+ messages in thread From: Mathieu Poirier @ 2017-06-02 22:16 UTC (permalink / raw) To: Russell King - ARM Linux, marc.zyngier, Catalin Marinas, Christoffer Dall, Ard Biesheuvel Cc: kvm, linux-arm-kernel, kvmarm Good afternoon Russell and friends, I noticed that my vexpress-TC2 platform stopped booting when moving to kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and ended up on [1], hence this email. Since CONFIG_ARM_VIRT_EXT is selected by default I removed the "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and the system sprung up to life again. Compiler: arm-linux-gnueabi-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 Kernel command line: console=ttyAMA0,38400 loglevel=8 root=/dev/sda2 rootwait U-boot: ## Flattened Device Tree blob at 82000000 Booting using the fdt blob at 0x82000000 Loading Ramdisk to 9fcea000, end 9feea6d1 ... OK Loading Device Tree to 9fce2000, end 9fce9ad8 ... OK I'm not sure what else you need at this time - simply get back to me with what I'm missing and I'll be happy to provided. I'm also offering to test patches. Many thanks, Mathieu [1]. 9da5ac236de6 ARM: soft-reboot into same mode that we entered the kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Vexpress TC2 no longer booting on v4.12-rc1 @ 2017-06-02 22:16 ` Mathieu Poirier 0 siblings, 0 replies; 12+ messages in thread From: Mathieu Poirier @ 2017-06-02 22:16 UTC (permalink / raw) To: linux-arm-kernel Good afternoon Russell and friends, I noticed that my vexpress-TC2 platform stopped booting when moving to kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and ended up on [1], hence this email. Since CONFIG_ARM_VIRT_EXT is selected by default I removed the "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and the system sprung up to life again. Compiler: arm-linux-gnueabi-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 Kernel command line: console=ttyAMA0,38400 loglevel=8 root=/dev/sda2 rootwait U-boot: ## Flattened Device Tree blob at 82000000 Booting using the fdt blob at 0x82000000 Loading Ramdisk to 9fcea000, end 9feea6d1 ... OK Loading Device Tree to 9fce2000, end 9fce9ad8 ... OK I'm not sure what else you need at this time - simply get back to me with what I'm missing and I'll be happy to provided. I'm also offering to test patches. Many thanks, Mathieu [1]. 9da5ac236de6 ARM: soft-reboot into same mode that we entered the kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Vexpress TC2 no longer booting on v4.12-rc1 2017-06-02 22:16 ` Mathieu Poirier @ 2017-06-02 22:24 ` Russell King - ARM Linux -1 siblings, 0 replies; 12+ messages in thread From: Russell King - ARM Linux @ 2017-06-02 22:24 UTC (permalink / raw) To: Mathieu Poirier Cc: Christoffer Dall, kvm, Ard Biesheuvel, marc.zyngier, Catalin Marinas, kvmarm, linux-arm-kernel On Fri, Jun 02, 2017 at 04:16:59PM -0600, Mathieu Poirier wrote: > Good afternoon Russell and friends, > > I noticed that my vexpress-TC2 platform stopped booting when moving to > kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked > properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and > ended up on [1], hence this email. > > Since CONFIG_ARM_VIRT_EXT is selected by default I removed the > "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and > the system sprung up to life again. Hmm, this doesn't make much sense. The code in last hunk of the patch you refer to should only get run during system shutdown, not during system boot, so I think something else is going on... Please could you test again, this time rather than removing the #ifdef, add two "mov r0, r0" there? (So replacing the two instructions that removing the ifdef would have exposed.) Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Vexpress TC2 no longer booting on v4.12-rc1 @ 2017-06-02 22:24 ` Russell King - ARM Linux 0 siblings, 0 replies; 12+ messages in thread From: Russell King - ARM Linux @ 2017-06-02 22:24 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jun 02, 2017 at 04:16:59PM -0600, Mathieu Poirier wrote: > Good afternoon Russell and friends, > > I noticed that my vexpress-TC2 platform stopped booting when moving to > kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked > properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and > ended up on [1], hence this email. > > Since CONFIG_ARM_VIRT_EXT is selected by default I removed the > "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and > the system sprung up to life again. Hmm, this doesn't make much sense. The code in last hunk of the patch you refer to should only get run during system shutdown, not during system boot, so I think something else is going on... Please could you test again, this time rather than removing the #ifdef, add two "mov r0, r0" there? (So replacing the two instructions that removing the ifdef would have exposed.) Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Vexpress TC2 no longer booting on v4.12-rc1 2017-06-02 22:24 ` Russell King - ARM Linux @ 2017-06-05 1:47 ` Mathieu Poirier -1 siblings, 0 replies; 12+ messages in thread From: Mathieu Poirier @ 2017-06-05 1:47 UTC (permalink / raw) To: Russell King - ARM Linux Cc: Christoffer Dall, kvm, Ard Biesheuvel, marc.zyngier, Catalin Marinas, kvmarm, linux-arm-kernel On 2 June 2017 at 16:24, Russell King - ARM Linux <linux@armlinux.org.uk> wrote: > On Fri, Jun 02, 2017 at 04:16:59PM -0600, Mathieu Poirier wrote: >> Good afternoon Russell and friends, >> >> I noticed that my vexpress-TC2 platform stopped booting when moving to >> kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked >> properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and >> ended up on [1], hence this email. >> >> Since CONFIG_ARM_VIRT_EXT is selected by default I removed the >> "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and >> the system sprung up to life again. > > Hmm, this doesn't make much sense. The code in last hunk of the patch > you refer to should only get run during system shutdown, not during > system boot, so I think something else is going on... > > Please could you test again, this time rather than removing the #ifdef, > add two "mov r0, r0" there? (So replacing the two instructions that > removing the ifdef would have exposed.) That works - by replacing the original code with a couple of "mov r0, r0" the system is able to boot again. > > Thanks. > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Vexpress TC2 no longer booting on v4.12-rc1 @ 2017-06-05 1:47 ` Mathieu Poirier 0 siblings, 0 replies; 12+ messages in thread From: Mathieu Poirier @ 2017-06-05 1:47 UTC (permalink / raw) To: linux-arm-kernel On 2 June 2017 at 16:24, Russell King - ARM Linux <linux@armlinux.org.uk> wrote: > On Fri, Jun 02, 2017 at 04:16:59PM -0600, Mathieu Poirier wrote: >> Good afternoon Russell and friends, >> >> I noticed that my vexpress-TC2 platform stopped booting when moving to >> kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked >> properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and >> ended up on [1], hence this email. >> >> Since CONFIG_ARM_VIRT_EXT is selected by default I removed the >> "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and >> the system sprung up to life again. > > Hmm, this doesn't make much sense. The code in last hunk of the patch > you refer to should only get run during system shutdown, not during > system boot, so I think something else is going on... > > Please could you test again, this time rather than removing the #ifdef, > add two "mov r0, r0" there? (So replacing the two instructions that > removing the ifdef would have exposed.) That works - by replacing the original code with a couple of "mov r0, r0" the system is able to boot again. > > Thanks. > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Vexpress TC2 no longer booting on v4.12-rc1 2017-06-05 1:47 ` Mathieu Poirier @ 2017-06-05 7:43 ` Marc Zyngier -1 siblings, 0 replies; 12+ messages in thread From: Marc Zyngier @ 2017-06-05 7:43 UTC (permalink / raw) To: Mathieu Poirier, Russell King - ARM Linux Cc: Christoffer Dall, kvm, Ard Biesheuvel, Catalin Marinas, kvmarm, linux-arm-kernel Hi Mathieu, On 05/06/17 02:47, Mathieu Poirier wrote: > On 2 June 2017 at 16:24, Russell King - ARM Linux <linux@armlinux.org.uk> wrote: >> On Fri, Jun 02, 2017 at 04:16:59PM -0600, Mathieu Poirier wrote: >>> Good afternoon Russell and friends, >>> >>> I noticed that my vexpress-TC2 platform stopped booting when moving to >>> kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked >>> properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and >>> ended up on [1], hence this email. >>> >>> Since CONFIG_ARM_VIRT_EXT is selected by default I removed the >>> "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and >>> the system sprung up to life again. >> >> Hmm, this doesn't make much sense. The code in last hunk of the patch >> you refer to should only get run during system shutdown, not during >> system boot, so I think something else is going on... >> >> Please could you test again, this time rather than removing the #ifdef, >> add two "mov r0, r0" there? (So replacing the two instructions that >> removing the ifdef would have exposed.) > > That works - by replacing the original code with a couple of "mov r0, > r0" the system is able to boot again. That's quite peculiar. It would tend to indicate that something resets a CPU behind our back, leading to all kind of ugly things. Grepping around, my bet is on MCPM, which seems to do all kind of horrible things. Can you give the following hack a go? diff --git a/arch/arm/common/mcpm_entry.c b/arch/arm/common/mcpm_entry.c index cf062472e07b..d8b6b688e938 100644 --- a/arch/arm/common/mcpm_entry.c +++ b/arch/arm/common/mcpm_entry.c @@ -300,7 +300,7 @@ void mcpm_cpu_power_down(void) * on the CPU. */ phys_reset = (phys_reset_t)(unsigned long)__pa_symbol(cpu_reset); - phys_reset(__pa_symbol(mcpm_entry_point)); + phys_reset(__pa_symbol(mcpm_entry_point), is_hyp_mode_available()); /* should never get here */ BUG(); @@ -389,7 +389,7 @@ static int __init nocache_trampoline(unsigned long _arg) __mcpm_cpu_down(cpu, cluster); phys_reset = (phys_reset_t)(unsigned long)__pa_symbol(cpu_reset); - phys_reset(__pa_symbol(mcpm_entry_point)); + phys_reset(__pa_symbol(mcpm_entry_point), is_hyp_mode_available()); BUG(); } Can you let me know if that helps? If it does, we can then think of cleaning up the dangerous duplication of functionality... Thanks, M. -- Jazz is not dead. It just smells funny... ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Vexpress TC2 no longer booting on v4.12-rc1 @ 2017-06-05 7:43 ` Marc Zyngier 0 siblings, 0 replies; 12+ messages in thread From: Marc Zyngier @ 2017-06-05 7:43 UTC (permalink / raw) To: linux-arm-kernel Hi Mathieu, On 05/06/17 02:47, Mathieu Poirier wrote: > On 2 June 2017 at 16:24, Russell King - ARM Linux <linux@armlinux.org.uk> wrote: >> On Fri, Jun 02, 2017 at 04:16:59PM -0600, Mathieu Poirier wrote: >>> Good afternoon Russell and friends, >>> >>> I noticed that my vexpress-TC2 platform stopped booting when moving to >>> kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked >>> properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and >>> ended up on [1], hence this email. >>> >>> Since CONFIG_ARM_VIRT_EXT is selected by default I removed the >>> "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and >>> the system sprung up to life again. >> >> Hmm, this doesn't make much sense. The code in last hunk of the patch >> you refer to should only get run during system shutdown, not during >> system boot, so I think something else is going on... >> >> Please could you test again, this time rather than removing the #ifdef, >> add two "mov r0, r0" there? (So replacing the two instructions that >> removing the ifdef would have exposed.) > > That works - by replacing the original code with a couple of "mov r0, > r0" the system is able to boot again. That's quite peculiar. It would tend to indicate that something resets a CPU behind our back, leading to all kind of ugly things. Grepping around, my bet is on MCPM, which seems to do all kind of horrible things. Can you give the following hack a go? diff --git a/arch/arm/common/mcpm_entry.c b/arch/arm/common/mcpm_entry.c index cf062472e07b..d8b6b688e938 100644 --- a/arch/arm/common/mcpm_entry.c +++ b/arch/arm/common/mcpm_entry.c @@ -300,7 +300,7 @@ void mcpm_cpu_power_down(void) * on the CPU. */ phys_reset = (phys_reset_t)(unsigned long)__pa_symbol(cpu_reset); - phys_reset(__pa_symbol(mcpm_entry_point)); + phys_reset(__pa_symbol(mcpm_entry_point), is_hyp_mode_available()); /* should never get here */ BUG(); @@ -389,7 +389,7 @@ static int __init nocache_trampoline(unsigned long _arg) __mcpm_cpu_down(cpu, cluster); phys_reset = (phys_reset_t)(unsigned long)__pa_symbol(cpu_reset); - phys_reset(__pa_symbol(mcpm_entry_point)); + phys_reset(__pa_symbol(mcpm_entry_point), is_hyp_mode_available()); BUG(); } Can you let me know if that helps? If it does, we can then think of cleaning up the dangerous duplication of functionality... Thanks, M. -- Jazz is not dead. It just smells funny... ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: Vexpress TC2 no longer booting on v4.12-rc1 2017-06-02 22:16 ` Mathieu Poirier @ 2017-06-05 9:18 ` Sudeep Holla -1 siblings, 0 replies; 12+ messages in thread From: Sudeep Holla @ 2017-06-05 9:18 UTC (permalink / raw) To: Mathieu Poirier Cc: Christoffer Dall, Russell King - ARM Linux, kvm, Ard Biesheuvel, marc.zyngier, Catalin Marinas, Sudeep Holla, kvmarm, linux-arm-kernel On 02/06/17 23:16, Mathieu Poirier wrote: > Good afternoon Russell and friends, > > I noticed that my vexpress-TC2 platform stopped booting when moving to > kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked > properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and > ended up on [1], hence this email. > > Since CONFIG_ARM_VIRT_EXT is selected by default I removed the > "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and > the system sprung up to life again. > > Compiler: arm-linux-gnueabi-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) > 5.4.0 20160609 > Kernel command line: console=ttyAMA0,38400 loglevel=8 root=/dev/sda2 rootwait > U-boot: > ## Flattened Device Tree blob at 82000000 > Booting using the fdt blob at 0x82000000 > Loading Ramdisk to 9fcea000, end 9feea6d1 ... OK > Loading Device Tree to 9fce2000, end 9fce9ad8 ... OK > > I'm not sure what else you need at this time - simply get back to me > with what I'm missing and I'll be happy to provided. I'm also > offering to test patches. > Fixed[1] and must be queued in rmk's tree[2]. -- Regards, Sudeep [1] https://www.spinics.net/lists/arm-kernel/msg581877.html [2] http://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8675 ^ permalink raw reply [flat|nested] 12+ messages in thread
* Vexpress TC2 no longer booting on v4.12-rc1 @ 2017-06-05 9:18 ` Sudeep Holla 0 siblings, 0 replies; 12+ messages in thread From: Sudeep Holla @ 2017-06-05 9:18 UTC (permalink / raw) To: linux-arm-kernel On 02/06/17 23:16, Mathieu Poirier wrote: > Good afternoon Russell and friends, > > I noticed that my vexpress-TC2 platform stopped booting when moving to > kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked > properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and > ended up on [1], hence this email. > > Since CONFIG_ARM_VIRT_EXT is selected by default I removed the > "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and > the system sprung up to life again. > > Compiler: arm-linux-gnueabi-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) > 5.4.0 20160609 > Kernel command line: console=ttyAMA0,38400 loglevel=8 root=/dev/sda2 rootwait > U-boot: > ## Flattened Device Tree blob at 82000000 > Booting using the fdt blob at 0x82000000 > Loading Ramdisk to 9fcea000, end 9feea6d1 ... OK > Loading Device Tree to 9fce2000, end 9fce9ad8 ... OK > > I'm not sure what else you need at this time - simply get back to me > with what I'm missing and I'll be happy to provided. I'm also > offering to test patches. > Fixed[1] and must be queued in rmk's tree[2]. -- Regards, Sudeep [1] https://www.spinics.net/lists/arm-kernel/msg581877.html [2] http://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8675 ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Vexpress TC2 no longer booting on v4.12-rc1 2017-06-05 9:18 ` Sudeep Holla @ 2017-06-05 9:27 ` Marc Zyngier -1 siblings, 0 replies; 12+ messages in thread From: Marc Zyngier @ 2017-06-05 9:27 UTC (permalink / raw) To: Sudeep Holla, Mathieu Poirier Cc: Russell King - ARM Linux, Catalin Marinas, Christoffer Dall, Ard Biesheuvel, linux-arm-kernel, kvm, kvmarm On 05/06/17 10:18, Sudeep Holla wrote: > > > On 02/06/17 23:16, Mathieu Poirier wrote: >> Good afternoon Russell and friends, >> >> I noticed that my vexpress-TC2 platform stopped booting when moving to >> kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked >> properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and >> ended up on [1], hence this email. >> >> Since CONFIG_ARM_VIRT_EXT is selected by default I removed the >> "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and >> the system sprung up to life again. >> >> Compiler: arm-linux-gnueabi-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) >> 5.4.0 20160609 >> Kernel command line: console=ttyAMA0,38400 loglevel=8 root=/dev/sda2 rootwait >> U-boot: >> ## Flattened Device Tree blob at 82000000 >> Booting using the fdt blob at 0x82000000 >> Loading Ramdisk to 9fcea000, end 9feea6d1 ... OK >> Loading Device Tree to 9fce2000, end 9fce9ad8 ... OK >> >> I'm not sure what else you need at this time - simply get back to me >> with what I'm missing and I'll be happy to provided. I'm also >> offering to test patches. >> > > Fixed[1] and must be queued in rmk's tree[2]. Ah, brilliant. Thanks Sudeep. M. -- Jazz is not dead. It just smells funny... ^ permalink raw reply [flat|nested] 12+ messages in thread
* Vexpress TC2 no longer booting on v4.12-rc1 @ 2017-06-05 9:27 ` Marc Zyngier 0 siblings, 0 replies; 12+ messages in thread From: Marc Zyngier @ 2017-06-05 9:27 UTC (permalink / raw) To: linux-arm-kernel On 05/06/17 10:18, Sudeep Holla wrote: > > > On 02/06/17 23:16, Mathieu Poirier wrote: >> Good afternoon Russell and friends, >> >> I noticed that my vexpress-TC2 platform stopped booting when moving to >> kernel v4.12-rc1 (same with -rc2 and 3). The last time things worked >> properly was on v4.11. I did a bisect between v4.11 and v4.12-rc1 and >> ended up on [1], hence this email. >> >> Since CONFIG_ARM_VIRT_EXT is selected by default I removed the >> "#ifdef CONFIG_ARM_VIRT_EXT" section in the last hunk of the patch and >> the system sprung up to life again. >> >> Compiler: arm-linux-gnueabi-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.4) >> 5.4.0 20160609 >> Kernel command line: console=ttyAMA0,38400 loglevel=8 root=/dev/sda2 rootwait >> U-boot: >> ## Flattened Device Tree blob at 82000000 >> Booting using the fdt blob at 0x82000000 >> Loading Ramdisk to 9fcea000, end 9feea6d1 ... OK >> Loading Device Tree to 9fce2000, end 9fce9ad8 ... OK >> >> I'm not sure what else you need at this time - simply get back to me >> with what I'm missing and I'll be happy to provided. I'm also >> offering to test patches. >> > > Fixed[1] and must be queued in rmk's tree[2]. Ah, brilliant. Thanks Sudeep. M. -- Jazz is not dead. It just smells funny... ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-06-05 9:27 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-06-02 22:16 Vexpress TC2 no longer booting on v4.12-rc1 Mathieu Poirier 2017-06-02 22:16 ` Mathieu Poirier 2017-06-02 22:24 ` Russell King - ARM Linux 2017-06-02 22:24 ` Russell King - ARM Linux 2017-06-05 1:47 ` Mathieu Poirier 2017-06-05 1:47 ` Mathieu Poirier 2017-06-05 7:43 ` Marc Zyngier 2017-06-05 7:43 ` Marc Zyngier 2017-06-05 9:18 ` Sudeep Holla 2017-06-05 9:18 ` Sudeep Holla 2017-06-05 9:27 ` Marc Zyngier 2017-06-05 9:27 ` Marc Zyngier
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.