All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] coresight: Fix check in coresight_tmc_etr_buf_insert_barrier_packet
Date: Wed, 6 Jun 2018 13:10:29 -0600	[thread overview]
Message-ID: <CANLsYkyhJFrNtc7PDY0XNQoiHW8sHW+kJiaUPoWqPwCZM-R_Tw@mail.gmail.com> (raw)
In-Reply-To: <1527851302-5843-1-git-send-email-suzuki.poulose@arm.com>

On 1 June 2018 at 05:08, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
> We request for "CORESIGHT_BARRIER_PKT_SIZE" length and we should
> be happy when we get that size.
>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
>
> Mathieu,
>
> Please could you pull this patch, if you are happy with it ?
> This fixes a problem in the ETR buf series, which I just
> noticed while testing the part2 of the series.

I will pick up the change - you will see it being queued when the
first rc comes out.

>
> Suzuki
> ---
>  drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> index e2bcef3..c736250 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> @@ -862,7 +862,7 @@ tmc_etr_buf_insert_barrier_packet(struct etr_buf *etr_buf, u64 offset)
>
>         len = tmc_etr_buf_get_data(etr_buf, offset,
>                                    CORESIGHT_BARRIER_PKT_SIZE, &bufp);
> -       if (WARN_ON(len <= CORESIGHT_BARRIER_PKT_SIZE))
> +       if (WARN_ON(len < CORESIGHT_BARRIER_PKT_SIZE))
>                 return -EINVAL;
>         coresight_insert_barrier_packet(bufp);
>         return offset + CORESIGHT_BARRIER_PKT_SIZE;
> --
> 2.7.4
>

WARNING: multiple messages have this Message-ID (diff)
From: mathieu.poirier@linaro.org (Mathieu Poirier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] coresight: Fix check in coresight_tmc_etr_buf_insert_barrier_packet
Date: Wed, 6 Jun 2018 13:10:29 -0600	[thread overview]
Message-ID: <CANLsYkyhJFrNtc7PDY0XNQoiHW8sHW+kJiaUPoWqPwCZM-R_Tw@mail.gmail.com> (raw)
In-Reply-To: <1527851302-5843-1-git-send-email-suzuki.poulose@arm.com>

On 1 June 2018 at 05:08, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
> We request for "CORESIGHT_BARRIER_PKT_SIZE" length and we should
> be happy when we get that size.
>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
>
> Mathieu,
>
> Please could you pull this patch, if you are happy with it ?
> This fixes a problem in the ETR buf series, which I just
> noticed while testing the part2 of the series.

I will pick up the change - you will see it being queued when the
first rc comes out.

>
> Suzuki
> ---
>  drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> index e2bcef3..c736250 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> @@ -862,7 +862,7 @@ tmc_etr_buf_insert_barrier_packet(struct etr_buf *etr_buf, u64 offset)
>
>         len = tmc_etr_buf_get_data(etr_buf, offset,
>                                    CORESIGHT_BARRIER_PKT_SIZE, &bufp);
> -       if (WARN_ON(len <= CORESIGHT_BARRIER_PKT_SIZE))
> +       if (WARN_ON(len < CORESIGHT_BARRIER_PKT_SIZE))
>                 return -EINVAL;
>         coresight_insert_barrier_packet(bufp);
>         return offset + CORESIGHT_BARRIER_PKT_SIZE;
> --
> 2.7.4
>

  reply	other threads:[~2018-06-06 19:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 11:08 [PATCH] coresight: Fix check in coresight_tmc_etr_buf_insert_barrier_packet Suzuki K Poulose
2018-06-01 11:08 ` Suzuki K Poulose
2018-06-06 19:10 ` Mathieu Poirier [this message]
2018-06-06 19:10   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANLsYkyhJFrNtc7PDY0XNQoiHW8sHW+kJiaUPoWqPwCZM-R_Tw@mail.gmail.com \
    --to=mathieu.poirier@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.