From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> Cc: Igor Lubashev <ilubashe@akamai.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>, Alexey Budankov <alexey.budankov@linux.intel.com>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Namhyung Kim <namhyung@kernel.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, James Morris <jmorris@namei.org> Subject: Re: [PATCH v3 4/4] perf: Use CAP_SYS_ADMIN instead of euid==0 with ftrace Date: Tue, 13 Aug 2019 10:35:26 -0600 [thread overview] Message-ID: <CANLsYkynrTs4TouDs2=beEigOh6Ptatga_-WjE-FdC1ecKWyWg@mail.gmail.com> (raw) In-Reply-To: <20190813132349.GB12299@kernel.org> Hi Arnaldo, On Tue, 13 Aug 2019 at 07:23, Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote: > > Em Mon, Aug 12, 2019 at 03:42:17PM -0600, Mathieu Poirier escreveu: > > On Mon, 12 Aug 2019 at 14:29, Arnaldo Carvalho de Melo > > <arnaldo.melo@gmail.com> wrote: > > > > > > Em Mon, Aug 12, 2019 at 05:27:06PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > Em Mon, Aug 12, 2019 at 05:22:51PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > > Em Wed, Aug 07, 2019 at 10:44:17AM -0400, Igor Lubashev escreveu: > > > > > > @@ -281,7 +283,7 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) > > > > > > .events = POLLIN, > > > > > > }; > > > > > > > > > > > > - if (geteuid() != 0) { > > > > > > + if (!perf_cap__capable(CAP_SYS_ADMIN)) { > > > > > > pr_err("ftrace only works for root!\n"); > > > > > > > > > > I guess we should update the error message too? > > > > > > > > > > > > > I.e. I applied this as a follow up patch: > > > > > > > > diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c > > > > index 01a5bb58eb04..ba8b65c2f9dc 100644 > > > > --- a/tools/perf/builtin-ftrace.c > > > > +++ b/tools/perf/builtin-ftrace.c > > > > @@ -284,7 +284,12 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) > > > > }; > > > > > > > > if (!perf_cap__capable(CAP_SYS_ADMIN)) { > > > > - pr_err("ftrace only works for root!\n"); > > > > + pr_err("ftrace only works for %s!\n", > > > > +#ifdef HAVE_LIBCAP_SUPPORT > > > > + "users with the SYS_ADMIN capability" > > > > +#else > > > > + "root" > > > > +#endif > > > > > > ); > > > > > > :-) > > > > > > > return -1; > > > > } > > > > > > > > > > I've pushed the whole set to my tmp.perf/cap branch, please chec > > > > Please hold on before moving further - I'm getting a segmentation > > fault on ARM64 that I'm still trying to figure out. > > This is just sitting in my tmp branch, and in my local perf/core branch, > so that I can test it with the containers, etc. > > Is this related to the following fix? That is the first thing I thought about but no, it has nothing to do with it. Patch 3/4 is where the problem shows up. The code in the patch is fine, it is the repercussion it has on other part that needs to be investigated. Right now I see that kmap->ref_reloc_sym is NULL here [1] when tracing with anything else than the 'u' option. I am currently investigating the problem. Igor, please see if you can reproduce on QEMU or an ARM64 based platform. [1] https://elixir.bootlin.com/linux/v5.3-rc4/source/tools/perf/util/event.c#L945 > > commit 3e70008a6021fffd2cd1614734603ea970773060 > Author: Leo Yan <leo.yan@linaro.org> > Date: Fri Aug 9 18:47:52 2019 +0800 > > perf trace: Fix segmentation fault when access syscall info on arm64 > > 'perf trace' reports the segmentation fault as below on Arm64: > > # perf trace -e string -e augmented_raw_syscalls.c > LLVM: dumping tools/perf/examples/bpf/augmented_raw_syscalls.o > perf: Segmentation fault > Obtained 12 stack frames. > perf(sighandler_dump_stack+0x47) [0xaaaaac96ac87] > linux-vdso.so.1(+0x5b7) [0xffffadbeb5b7] > /lib/aarch64-linux-gnu/libc.so.6(strlen+0x10) [0xfffface7d5d0] > /lib/aarch64-linux-gnu/libc.so.6(_IO_vfprintf+0x1ac7) [0xfffface49f97] > /lib/aarch64-linux-gnu/libc.so.6(__vsnprintf_chk+0xc7) [0xffffacedfbe7] > perf(scnprintf+0x97) [0xaaaaac9ca3ff] > perf(+0x997bb) [0xaaaaac8e37bb] > perf(cmd_trace+0x28e7) [0xaaaaac8ec09f] > perf(+0xd4a13) [0xaaaaac91ea13] > perf(main+0x62f) [0xaaaaac8a147f] > /lib/aarch64-linux-gnu/libc.so.6(__libc_start_main+0xe3) [0xfffface22d23] > perf(+0x57723) [0xaaaaac8a1723] > Segmentation fault > > This issue is introduced by commit 30a910d7d3e0 ("perf trace: > Preallocate the syscall table"), it allocates trace->syscalls.table[] > array and the element count is 'trace->sctbl->syscalls.nr_entries'; but > on Arm64, the system call number is not continuously used; e.g. the > syscall maximum id is 436 but the real entries is only 281. > >
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>, Peter Zijlstra <peterz@infradead.org>, Alexey Budankov <alexey.budankov@linux.intel.com>, Igor Lubashev <ilubashe@akamai.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, James Morris <jmorris@namei.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Ingo Molnar <mingo@redhat.com>, Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 4/4] perf: Use CAP_SYS_ADMIN instead of euid==0 with ftrace Date: Tue, 13 Aug 2019 10:35:26 -0600 [thread overview] Message-ID: <CANLsYkynrTs4TouDs2=beEigOh6Ptatga_-WjE-FdC1ecKWyWg@mail.gmail.com> (raw) In-Reply-To: <20190813132349.GB12299@kernel.org> Hi Arnaldo, On Tue, 13 Aug 2019 at 07:23, Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote: > > Em Mon, Aug 12, 2019 at 03:42:17PM -0600, Mathieu Poirier escreveu: > > On Mon, 12 Aug 2019 at 14:29, Arnaldo Carvalho de Melo > > <arnaldo.melo@gmail.com> wrote: > > > > > > Em Mon, Aug 12, 2019 at 05:27:06PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > Em Mon, Aug 12, 2019 at 05:22:51PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > > Em Wed, Aug 07, 2019 at 10:44:17AM -0400, Igor Lubashev escreveu: > > > > > > @@ -281,7 +283,7 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) > > > > > > .events = POLLIN, > > > > > > }; > > > > > > > > > > > > - if (geteuid() != 0) { > > > > > > + if (!perf_cap__capable(CAP_SYS_ADMIN)) { > > > > > > pr_err("ftrace only works for root!\n"); > > > > > > > > > > I guess we should update the error message too? > > > > > > > > > > > > > I.e. I applied this as a follow up patch: > > > > > > > > diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c > > > > index 01a5bb58eb04..ba8b65c2f9dc 100644 > > > > --- a/tools/perf/builtin-ftrace.c > > > > +++ b/tools/perf/builtin-ftrace.c > > > > @@ -284,7 +284,12 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv) > > > > }; > > > > > > > > if (!perf_cap__capable(CAP_SYS_ADMIN)) { > > > > - pr_err("ftrace only works for root!\n"); > > > > + pr_err("ftrace only works for %s!\n", > > > > +#ifdef HAVE_LIBCAP_SUPPORT > > > > + "users with the SYS_ADMIN capability" > > > > +#else > > > > + "root" > > > > +#endif > > > > > > ); > > > > > > :-) > > > > > > > return -1; > > > > } > > > > > > > > > > I've pushed the whole set to my tmp.perf/cap branch, please chec > > > > Please hold on before moving further - I'm getting a segmentation > > fault on ARM64 that I'm still trying to figure out. > > This is just sitting in my tmp branch, and in my local perf/core branch, > so that I can test it with the containers, etc. > > Is this related to the following fix? That is the first thing I thought about but no, it has nothing to do with it. Patch 3/4 is where the problem shows up. The code in the patch is fine, it is the repercussion it has on other part that needs to be investigated. Right now I see that kmap->ref_reloc_sym is NULL here [1] when tracing with anything else than the 'u' option. I am currently investigating the problem. Igor, please see if you can reproduce on QEMU or an ARM64 based platform. [1] https://elixir.bootlin.com/linux/v5.3-rc4/source/tools/perf/util/event.c#L945 > > commit 3e70008a6021fffd2cd1614734603ea970773060 > Author: Leo Yan <leo.yan@linaro.org> > Date: Fri Aug 9 18:47:52 2019 +0800 > > perf trace: Fix segmentation fault when access syscall info on arm64 > > 'perf trace' reports the segmentation fault as below on Arm64: > > # perf trace -e string -e augmented_raw_syscalls.c > LLVM: dumping tools/perf/examples/bpf/augmented_raw_syscalls.o > perf: Segmentation fault > Obtained 12 stack frames. > perf(sighandler_dump_stack+0x47) [0xaaaaac96ac87] > linux-vdso.so.1(+0x5b7) [0xffffadbeb5b7] > /lib/aarch64-linux-gnu/libc.so.6(strlen+0x10) [0xfffface7d5d0] > /lib/aarch64-linux-gnu/libc.so.6(_IO_vfprintf+0x1ac7) [0xfffface49f97] > /lib/aarch64-linux-gnu/libc.so.6(__vsnprintf_chk+0xc7) [0xffffacedfbe7] > perf(scnprintf+0x97) [0xaaaaac9ca3ff] > perf(+0x997bb) [0xaaaaac8e37bb] > perf(cmd_trace+0x28e7) [0xaaaaac8ec09f] > perf(+0xd4a13) [0xaaaaac91ea13] > perf(main+0x62f) [0xaaaaac8a147f] > /lib/aarch64-linux-gnu/libc.so.6(__libc_start_main+0xe3) [0xfffface22d23] > perf(+0x57723) [0xaaaaac8a1723] > Segmentation fault > > This issue is introduced by commit 30a910d7d3e0 ("perf trace: > Preallocate the syscall table"), it allocates trace->syscalls.table[] > array and the element count is 'trace->sctbl->syscalls.nr_entries'; but > on Arm64, the system call number is not continuously used; e.g. the > syscall maximum id is 436 but the real entries is only 281. > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-13 16:35 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-07 14:44 [PATCH v3 0/4] perf: Use capabilities instead of uid and euid Igor Lubashev 2019-08-07 14:44 ` Igor Lubashev 2019-08-07 14:44 ` [PATCH v3 1/4] perf: Add capability-related utilities Igor Lubashev 2019-08-07 14:44 ` Igor Lubashev 2019-08-12 19:43 ` Arnaldo Carvalho de Melo 2019-08-12 19:43 ` Arnaldo Carvalho de Melo 2019-08-15 9:24 ` [tip:perf/core] tools build: Add capability-related feature detection tip-bot for Igor Lubashev 2019-08-15 9:25 ` [tip:perf/core] perf tools: Add helpers to use capabilities if present tip-bot for Igor Lubashev 2019-08-07 14:44 ` [PATCH v3 2/4] perf: Use CAP_SYS_ADMIN with perf_event_paranoid checks Igor Lubashev 2019-08-07 14:44 ` Igor Lubashev 2019-08-12 20:01 ` Arnaldo Carvalho de Melo 2019-08-12 20:01 ` Arnaldo Carvalho de Melo 2019-08-12 20:15 ` Arnaldo Carvalho de Melo 2019-08-12 20:15 ` Arnaldo Carvalho de Melo 2019-08-12 22:33 ` Lubashev, Igor 2019-08-12 22:33 ` Lubashev, Igor 2019-08-13 13:20 ` Arnaldo Carvalho de Melo 2019-08-13 13:20 ` Arnaldo Carvalho de Melo 2019-08-07 14:44 ` [PATCH v3 3/4] perf: Use CAP_SYSLOG with kptr_restrict checks Igor Lubashev 2019-08-07 14:44 ` Igor Lubashev 2019-08-14 18:04 ` Mathieu Poirier 2019-08-14 18:04 ` Mathieu Poirier 2019-08-14 18:48 ` Arnaldo Carvalho de Melo 2019-08-14 18:48 ` Arnaldo Carvalho de Melo 2019-08-14 18:52 ` Arnaldo Carvalho de Melo 2019-08-14 18:52 ` Arnaldo Carvalho de Melo 2019-08-14 20:02 ` Lubashev, Igor 2019-08-14 20:02 ` Lubashev, Igor 2019-08-15 15:01 ` Mathieu Poirier 2019-08-15 15:01 ` Mathieu Poirier 2019-08-15 20:16 ` Mathieu Poirier 2019-08-15 20:16 ` Mathieu Poirier 2019-08-15 21:42 ` Arnaldo Carvalho de Melo 2019-08-15 21:42 ` Arnaldo Carvalho de Melo 2019-08-19 16:51 ` Mathieu Poirier 2019-08-19 16:51 ` Mathieu Poirier 2019-08-19 22:22 ` Lubashev, Igor 2019-08-19 22:22 ` Lubashev, Igor 2019-08-20 16:57 ` Mathieu Poirier 2019-08-20 16:57 ` Mathieu Poirier 2019-08-20 17:13 ` Arnaldo Carvalho de Melo 2019-08-20 17:13 ` Arnaldo Carvalho de Melo 2019-08-27 1:58 ` Lubashev, Igor 2019-08-27 1:58 ` Lubashev, Igor 2019-08-15 22:27 ` Lubashev, Igor 2019-08-15 22:27 ` Lubashev, Igor 2019-08-07 14:44 ` [PATCH v3 4/4] perf: Use CAP_SYS_ADMIN instead of euid==0 with ftrace Igor Lubashev 2019-08-07 14:44 ` Igor Lubashev 2019-08-12 20:22 ` Arnaldo Carvalho de Melo 2019-08-12 20:22 ` Arnaldo Carvalho de Melo 2019-08-12 20:27 ` Arnaldo Carvalho de Melo 2019-08-12 20:27 ` Arnaldo Carvalho de Melo 2019-08-12 20:29 ` Arnaldo Carvalho de Melo 2019-08-12 20:29 ` Arnaldo Carvalho de Melo 2019-08-12 21:42 ` Mathieu Poirier 2019-08-12 21:42 ` Mathieu Poirier 2019-08-13 13:23 ` Arnaldo Carvalho de Melo 2019-08-13 13:23 ` Arnaldo Carvalho de Melo 2019-08-13 16:35 ` Mathieu Poirier [this message] 2019-08-13 16:35 ` Mathieu Poirier 2019-08-15 9:27 ` [tip:perf/core] perf ftrace: Use CAP_SYS_ADMIN instead of euid==0 tip-bot for Igor Lubashev 2019-08-12 9:13 ` [PATCH v3 0/4] perf: Use capabilities instead of uid and euid Jiri Olsa 2019-08-12 9:13 ` Jiri Olsa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CANLsYkynrTs4TouDs2=beEigOh6Ptatga_-WjE-FdC1ecKWyWg@mail.gmail.com' \ --to=mathieu.poirier@linaro.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=alexey.budankov@linux.intel.com \ --cc=arnaldo.melo@gmail.com \ --cc=ilubashe@akamai.com \ --cc=jmorris@namei.org \ --cc=jolsa@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=suzuki.poulose@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.