From: Tyler Baker <tyler.baker@linaro.org> To: Andy Lutomirski <luto@amacapital.net> Cc: Shuah Khan <shuahkh@osg.samsung.com>, Kevin Hilman <khilman@kernel.org>, John Stultz <john.stultz@linaro.org>, Darren Hart <dvhart@infradead.org>, David Herrmann <dh.herrmann@gmail.com>, Michael Ellerman <mpe@ellerman.id.au>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building Date: Mon, 20 Apr 2015 19:51:50 -0700 [thread overview] Message-ID: <CANMBJr5NaSF1wE-o2WfhdBNdMXxNcD=Qhxiy7iXN9y1shRMx3g@mail.gmail.com> (raw) In-Reply-To: <CALCETrW6fBRe2RC5x9S+_U5xQxCZ=w=Ao-85EuTqZj2W4qevOQ@mail.gmail.com> On 20 April 2015 at 16:47, Andy Lutomirski <luto@amacapital.net> wrote: > On Mon, Apr 20, 2015 at 4:34 PM, Tyler Baker <tyler.baker@linaro.org> wrote: >> On 20 April 2015 at 16:22, Andy Lutomirski <luto@amacapital.net> wrote: >>> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote: >>>> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64. >>>> >>>> Cc: Andy Lutomirski <luto@amacapital.net> >>>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org> >>>> --- >>>> tools/testing/selftests/x86/Makefile | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile >>>> index be93945..a5ca38b 100644 >>>> --- a/tools/testing/selftests/x86/Makefile >>>> +++ b/tools/testing/selftests/x86/Makefile >>>> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64) >>>> >>>> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall >>>> >>>> +all: >>>> + >>> >>> This... >>> >>>> UNAME_M := $(shell uname -m) >>>> >>>> +ifeq ($(CROSS_COMPILE),) >>>> # Always build 32-bit tests >>>> all: all_32 >>>> - >>>> # If we're on a 64-bit host, build 64-bit tests as well >>>> ifeq ($(UNAME_M),x86_64) >>>> all: all_64 >>>> endif >>>> +else >>>> +# No dependency on all when cross building >>>> +all: >>> >>> ...is redundant with this. If you delete the "else" and "all:" here, then: >> >> Ok, I will remove these bits from this patch. However, the else will >> need to be added back in the next patch of the series to override the >> default behavior of EMIT_TESTS and INSTALL_RULE if that you are ok >> with that. > > I'm fine with that, unless you or Shuah want to fix lib.mk. I will send a follow up series to address this issue. > > --Andy Tyler
WARNING: multiple messages have this Message-ID (diff)
From: tyler.baker@linaro.org (Tyler Baker) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building Date: Mon, 20 Apr 2015 19:51:50 -0700 [thread overview] Message-ID: <CANMBJr5NaSF1wE-o2WfhdBNdMXxNcD=Qhxiy7iXN9y1shRMx3g@mail.gmail.com> (raw) In-Reply-To: <CALCETrW6fBRe2RC5x9S+_U5xQxCZ=w=Ao-85EuTqZj2W4qevOQ@mail.gmail.com> On 20 April 2015 at 16:47, Andy Lutomirski <luto@amacapital.net> wrote: > On Mon, Apr 20, 2015 at 4:34 PM, Tyler Baker <tyler.baker@linaro.org> wrote: >> On 20 April 2015 at 16:22, Andy Lutomirski <luto@amacapital.net> wrote: >>> On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@linaro.org> wrote: >>>> If the CROSS_COMPILE is set remove all's dependency on all_32 and all_64. >>>> >>>> Cc: Andy Lutomirski <luto@amacapital.net> >>>> Signed-off-by: Tyler Baker <tyler.baker@linaro.org> >>>> --- >>>> tools/testing/selftests/x86/Makefile | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile >>>> index be93945..a5ca38b 100644 >>>> --- a/tools/testing/selftests/x86/Makefile >>>> +++ b/tools/testing/selftests/x86/Makefile >>>> @@ -7,15 +7,21 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64) >>>> >>>> CFLAGS := -O2 -g -std=gnu99 -pthread -Wall >>>> >>>> +all: >>>> + >>> >>> This... >>> >>>> UNAME_M := $(shell uname -m) >>>> >>>> +ifeq ($(CROSS_COMPILE),) >>>> # Always build 32-bit tests >>>> all: all_32 >>>> - >>>> # If we're on a 64-bit host, build 64-bit tests as well >>>> ifeq ($(UNAME_M),x86_64) >>>> all: all_64 >>>> endif >>>> +else >>>> +# No dependency on all when cross building >>>> +all: >>> >>> ...is redundant with this. If you delete the "else" and "all:" here, then: >> >> Ok, I will remove these bits from this patch. However, the else will >> need to be added back in the next patch of the series to override the >> default behavior of EMIT_TESTS and INSTALL_RULE if that you are ok >> with that. > > I'm fine with that, unless you or Shuah want to fix lib.mk. I will send a follow up series to address this issue. > > --Andy Tyler
next prev parent reply other threads:[~2015-04-21 2:51 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-20 23:15 [PATCH v3 6/8] selftest/x86: have no dependency on all when cross building Tyler Baker 2015-04-20 23:15 ` Tyler Baker 2015-04-20 23:22 ` Andy Lutomirski 2015-04-20 23:22 ` Andy Lutomirski 2015-04-20 23:34 ` Tyler Baker 2015-04-20 23:34 ` Tyler Baker 2015-04-20 23:47 ` Andy Lutomirski 2015-04-20 23:47 ` Andy Lutomirski 2015-04-21 2:51 ` Tyler Baker [this message] 2015-04-21 2:51 ` Tyler Baker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CANMBJr5NaSF1wE-o2WfhdBNdMXxNcD=Qhxiy7iXN9y1shRMx3g@mail.gmail.com' \ --to=tyler.baker@linaro.org \ --cc=dh.herrmann@gmail.com \ --cc=dvhart@infradead.org \ --cc=john.stultz@linaro.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@amacapital.net \ --cc=mpe@ellerman.id.au \ --cc=shuahkh@osg.samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.