[drm-drm-misc:drm-misc-next 2/3] drivers/gpu/drm/panfrost/panfrost_drv.c:662:12: sparse: sparse: symbol 'default_supplies' was not declared. Should it be static?

[drm-drm-misc:drm-misc-next 2/3] drivers/gpu/drm/panfrost/panfrost_drv.c:662:12: sparse: sparse: symbol 'default_supplies' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

tree:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
head:   506629c868d0b1d641fc3afa491ddbd85fa1bdc3
commit: 3e1399bccf5163c59f41298b4faf768e199f4322 [2/3] drm/panfrost: Add support for multiple regulators
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-173-ge0787745-dirty
        git checkout 3e1399bccf5163c59f41298b4faf768e199f4322
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/panfrost/panfrost_drv.c:662:12: sparse: sparse: symbol 'default_supplies' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[RFC PATCH drm-drm-misc] drm/panfrost: default_supplies[] can be static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]


Fixes: 3e1399bccf51 ("drm/panfrost: Add support for multiple regulators")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 panfrost_drv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
index 4d08507526239..3e521627b5fbb 100644
--- a/drivers/gpu/drm/panfrost/panfrost_drv.c
+++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
@@ -659,7 +659,7 @@ static int panfrost_remove(struct platform_device *pdev)
 	return 0;
 }
 
-const char * const default_supplies[] = { "mali" };
+static const char * const default_supplies[] = { "mali" };
 static const struct panfrost_compatible default_data = {
 	.num_supplies = ARRAY_SIZE(default_supplies),
 	.supply_names = default_supplies,

Re: [RFC PATCH drm-drm-misc] drm/panfrost: default_supplies[] can be static

[Nicolas Boichat]

[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]

On Thu, Feb 27, 2020 at 9:42 AM kbuild test robot <lkp@intel.com> wrote:
>
>
> Fixes: 3e1399bccf51 ("drm/panfrost: Add support for multiple regulators")
> Signed-off-by: kbuild test robot <lkp@intel.com>

Looks right, sorry about that. Thanks!

Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

> ---
>  panfrost_drv.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 4d08507526239..3e521627b5fbb 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -659,7 +659,7 @@ static int panfrost_remove(struct platform_device *pdev)
>         return 0;
>  }
>
> -const char * const default_supplies[] = { "mali" };
> +static const char * const default_supplies[] = { "mali" };
>  static const struct panfrost_compatible default_data = {
>         .num_supplies = ARRAY_SIZE(default_supplies),
>         .supply_names = default_supplies,

Re: [RFC PATCH drm-drm-misc] drm/panfrost: default_supplies[] can be static

[Rob Herring]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

On Wed, Feb 26, 2020 at 7:42 PM kbuild test robot <lkp@intel.com> wrote:
>
>
> Fixes: 3e1399bccf51 ("drm/panfrost: Add support for multiple regulators")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>  panfrost_drv.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

One suggestion, it would be helpful if these went to the relevant list(s) too.

Rob