[PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
@ 2020-05-28  2:55 ` wuxy
  0 siblings, 0 replies; 13+ messages in thread
From: wuxy @ 2020-05-28  2:55 UTC (permalink / raw)
  To: akpm, linux-mm, linux-kernel, drinkcat, linux-mtd, stlin2; +Cc: wuxy

From: wuxy <wuxy@bitland.corp-partner.google.com>

Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
flash IDs in kukui series,this patch can support the new flash IDs.

TEST=boot to shell,get the spi information from 'dmesg'.

Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
Signed-off-by: ST Lin <stlin2@winbond.com>

This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
The original patch is invalid,so re-submit a new patch for this.
---
 drivers/mtd/spi-nor/winbond.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 17deabad57e1..cda4f8847bd6 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
 			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
 			    SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+	{ "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+	{ "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+	{ "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
 };
 
 /**
-- 
2.20.1




^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
@ 2020-05-28  2:55 ` wuxy
  0 siblings, 0 replies; 13+ messages in thread
From: wuxy @ 2020-05-28  2:55 UTC (permalink / raw)
  To: akpm, linux-mm, linux-kernel, drinkcat, linux-mtd, stlin2; +Cc: wuxy

From: wuxy <wuxy@bitland.corp-partner.google.com>

Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
flash IDs in kukui series,this patch can support the new flash IDs.

TEST=boot to shell,get the spi information from 'dmesg'.

Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
Signed-off-by: ST Lin <stlin2@winbond.com>

This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
The original patch is invalid,so re-submit a new patch for this.
---
 drivers/mtd/spi-nor/winbond.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 17deabad57e1..cda4f8847bd6 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
 			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
 			    SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+	{ "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+	{ "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+	{ "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
 };
 
 /**
-- 
2.20.1




______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
  2020-05-28  2:55 ` wuxy
@ 2020-05-28  3:06   ` Nicolas Boichat
  -1 siblings, 0 replies; 13+ messages in thread
From: Nicolas Boichat @ 2020-05-28  3:06 UTC (permalink / raw)
  To: wuxy; +Cc: lkml, linux-mtd, stlin2, wuxy

On Thu, May 28, 2020 at 10:55 AM <wuxy@bitland.com.cn> wrote:
>
> From: wuxy <wuxy@bitland.corp-partner.google.com>
>
> Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
> flash IDs in kukui series,this patch can support the new flash IDs.
>
> TEST=boot to shell,get the spi information from 'dmesg'.

TEST= is Chromium OS specific, you can drop this line.

>
> Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
> Signed-off-by: ST Lin <stlin2@winbond.com>

Tested-by: Nicolas Boichat <drinkcat@chromium.org>

>
> This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> The original patch is invalid,so re-submit a new patch for this.

This belongs below the ---, but I guess the maintainer can help you with that.

> ---
>  drivers/mtd/spi-nor/winbond.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 17deabad57e1..cda4f8847bd6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
>                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> +       { "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
>  };
>
>  /**
> --
> 2.20.1
>
>
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
@ 2020-05-28  3:06   ` Nicolas Boichat
  0 siblings, 0 replies; 13+ messages in thread
From: Nicolas Boichat @ 2020-05-28  3:06 UTC (permalink / raw)
  To: wuxy; +Cc: wuxy, linux-mtd, lkml, stlin2

On Thu, May 28, 2020 at 10:55 AM <wuxy@bitland.com.cn> wrote:
>
> From: wuxy <wuxy@bitland.corp-partner.google.com>
>
> Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
> flash IDs in kukui series,this patch can support the new flash IDs.
>
> TEST=boot to shell,get the spi information from 'dmesg'.

TEST= is Chromium OS specific, you can drop this line.

>
> Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
> Signed-off-by: ST Lin <stlin2@winbond.com>

Tested-by: Nicolas Boichat <drinkcat@chromium.org>

>
> This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> The original patch is invalid,so re-submit a new patch for this.

This belongs below the ---, but I guess the maintainer can help you with that.

> ---
>  drivers/mtd/spi-nor/winbond.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 17deabad57e1..cda4f8847bd6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
>                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> +       { "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
>  };
>
>  /**
> --
> 2.20.1
>
>
>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 13+ messages in thread

[parent not found: <tencent_353523967C92024E04C83463@qq.com>]

* Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
       [not found]   ` <tencent_353523967C92024E04C83463@qq.com>
@ 2020-05-28  3:18       ` Nicolas Boichat
  0 siblings, 0 replies; 13+ messages in thread
From: Nicolas Boichat @ 2020-05-28  3:18 UTC (permalink / raw)
  To: 吴兴育B01779; +Cc: lkml, linux-mtd, stlin2, wuxy

On Thu, May 28, 2020 at 11:16 AM 吴兴育B01779 <wuxy@bitland.com.cn> wrote:
>
>
> >
> > This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> > The original patch is invalid,so re-submit a new patch for this.
>
> This belongs below the ---, but I guess the maintainer can help you with that.
> --->This --- is automatically generated, it looks like I can't move it to below  ---

Sure, but you can always edit the message before you send it
(--annotate parameter of git send-email).

>
> ------------------ Original ------------------
> From:  "Nicolas Boichat"<drinkcat@chromium.org>;
> Date:  Thu, May 28, 2020 11:06 AM
> To:  "wuxy"<wuxy@bitland.com.cn>;
> Cc:  "lkml"<linux-kernel@vger.kernel.org>; "linux-mtd"<linux-mtd@lists.infradead.org>; "stlin2"<stlin2@winbond.com>; "wuxy"<wuxy@bitland.corp-partner.google.com>;
> Subject:  Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
>
> On Thu, May 28, 2020 at 10:55 AM <wuxy@bitland.com.cn> wrote:
> >
> > From: wuxy <wuxy@bitland.corp-partner.google.com>
> >
> > Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
> > flash IDs in kukui series,this patch can support the new flash IDs.
> >
> > TEST=boot to shell,get the spi information from 'dmesg'.
>
> TEST= is Chromium OS specific, you can drop this line.
>
> >
> > Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
> > Signed-off-by: ST Lin <stlin2@winbond.com>
>
> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
>
> >
> > This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> > The original patch is invalid,so re-submit a new patch for this.
>
> This belongs below the ---, but I guess the maintainer can help you with that.
>
> > ---
> >  drivers/mtd/spi-nor/winbond.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> > index 17deabad57e1..cda4f8847bd6 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
> >                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> >         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> >                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> > +       { "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
> > +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> > +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> > +       { "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
> > +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> > +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> > +       { "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
> > +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> > +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> >  };
> >
> >  /**
> > --
> > 2.20.1
> >
> >
> >

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
@ 2020-05-28  3:18       ` Nicolas Boichat
  0 siblings, 0 replies; 13+ messages in thread
From: Nicolas Boichat @ 2020-05-28  3:18 UTC (permalink / raw)
  To: 吴兴育B01779; +Cc: wuxy, linux-mtd, lkml, stlin2

On Thu, May 28, 2020 at 11:16 AM 吴兴育B01779 <wuxy@bitland.com.cn> wrote:
>
>
> >
> > This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> > The original patch is invalid,so re-submit a new patch for this.
>
> This belongs below the ---, but I guess the maintainer can help you with that.
> --->This --- is automatically generated, it looks like I can't move it to below  ---

Sure, but you can always edit the message before you send it
(--annotate parameter of git send-email).

>
> ------------------ Original ------------------
> From:  "Nicolas Boichat"<drinkcat@chromium.org>;
> Date:  Thu, May 28, 2020 11:06 AM
> To:  "wuxy"<wuxy@bitland.com.cn>;
> Cc:  "lkml"<linux-kernel@vger.kernel.org>; "linux-mtd"<linux-mtd@lists.infradead.org>; "stlin2"<stlin2@winbond.com>; "wuxy"<wuxy@bitland.corp-partner.google.com>;
> Subject:  Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
>
> On Thu, May 28, 2020 at 10:55 AM <wuxy@bitland.com.cn> wrote:
> >
> > From: wuxy <wuxy@bitland.corp-partner.google.com>
> >
> > Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
> > flash IDs in kukui series,this patch can support the new flash IDs.
> >
> > TEST=boot to shell,get the spi information from 'dmesg'.
>
> TEST= is Chromium OS specific, you can drop this line.
>
> >
> > Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
> > Signed-off-by: ST Lin <stlin2@winbond.com>
>
> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
>
> >
> > This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> > The original patch is invalid,so re-submit a new patch for this.
>
> This belongs below the ---, but I guess the maintainer can help you with that.
>
> > ---
> >  drivers/mtd/spi-nor/winbond.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> > index 17deabad57e1..cda4f8847bd6 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
> >                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> >         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> >                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> > +       { "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
> > +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> > +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> > +       { "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
> > +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> > +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> > +       { "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
> > +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> > +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> >  };
> >
> >  /**
> > --
> > 2.20.1
> >
> >
> >

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
@ 2020-05-28  3:36 ` wuxy
  0 siblings, 0 replies; 13+ messages in thread
From: wuxy @ 2020-05-28  3:36 UTC (permalink / raw)
  To: tudor.ambarus, miquel.raynal, linux-kernel, drinkcat, linux-mtd,
	stlin2, vigneshr
  Cc: wuxy

From: wuxy <wuxy@bitland.corp-partner.google.com>

Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
flash IDs in kukui series,this patch can support the new flash IDs.

Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
Signed-off-by: ST Lin <stlin2@winbond.com>
Test-by: Nicolas Boichat <drinkcat@chromium.org>

---
This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
The original patch is invalid,so re-submit a new patch for this.
 drivers/mtd/spi-nor/winbond.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 17deabad57e1..cda4f8847bd6 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
 			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
 			    SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+	{ "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+	{ "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+	{ "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
 };
 
 /**
-- 
2.20.1




^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
@ 2020-05-28  3:36 ` wuxy
  0 siblings, 0 replies; 13+ messages in thread
From: wuxy @ 2020-05-28  3:36 UTC (permalink / raw)
  To: tudor.ambarus, miquel.raynal, linux-kernel, drinkcat, linux-mtd,
	stlin2, vigneshr
  Cc: wuxy

From: wuxy <wuxy@bitland.corp-partner.google.com>

Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
flash IDs in kukui series,this patch can support the new flash IDs.

Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
Signed-off-by: ST Lin <stlin2@winbond.com>
Test-by: Nicolas Boichat <drinkcat@chromium.org>

---
This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
The original patch is invalid,so re-submit a new patch for this.
 drivers/mtd/spi-nor/winbond.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 17deabad57e1..cda4f8847bd6 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
 			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
 			    SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+	{ "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+	{ "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+	{ "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
 };
 
 /**
-- 
2.20.1




______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
  2020-05-28  3:36 ` wuxy
@ 2020-07-01  8:41   ` Tudor.Ambarus
  -1 siblings, 0 replies; 13+ messages in thread
From: Tudor.Ambarus @ 2020-07-01  8:41 UTC (permalink / raw)
  To: wuxy, miquel.raynal, linux-kernel, drinkcat, linux-mtd, stlin2, vigneshr
  Cc: wuxy

On 5/28/20 6:36 AM, wuxy@bitland.com.cn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: wuxy <wuxy@bitland.corp-partner.google.com>
> 
> Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
> flash IDs in kukui series,this patch can support the new flash IDs.

Which flashes were tested?

One should do a read, dump the content, erase, dump content to check that
erase was fine, write a random generated file, read back and compare.

I see that you added the locking flags too. Were the locking ops tested?

We don't add flashes or caps that are not tested, please specify in the
commit message what was tested.

> 
> Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
> Signed-off-by: ST Lin <stlin2@winbond.com>
> Test-by: Nicolas Boichat <drinkcat@chromium.org>
> 
> ---
> This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> The original patch is invalid,so re-submit a new patch for this.
>  drivers/mtd/spi-nor/winbond.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 17deabad57e1..cda4f8847bd6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
>                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> +       { "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,

We don't really care about the Package Type, it does not change the flash
caps, we can drop "xx" from the name. Also, the manufacturer can introduce
new flashes with different temperature ranges without changing the
flash caps, so we should drop the "I" from the name too.

The flash name would become w25q64jwm

> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,

w25q128jwm

> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,

w25q256jwm

> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },

w25q256jwm has 4 block protection bits, locking was not tested for this flash.

Cheers,
ta

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
@ 2020-07-01  8:41   ` Tudor.Ambarus
  0 siblings, 0 replies; 13+ messages in thread
From: Tudor.Ambarus @ 2020-07-01  8:41 UTC (permalink / raw)
  To: wuxy, miquel.raynal, linux-kernel, drinkcat, linux-mtd, stlin2, vigneshr
  Cc: wuxy

On 5/28/20 6:36 AM, wuxy@bitland.com.cn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: wuxy <wuxy@bitland.corp-partner.google.com>
> 
> Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
> flash IDs in kukui series,this patch can support the new flash IDs.

Which flashes were tested?

One should do a read, dump the content, erase, dump content to check that
erase was fine, write a random generated file, read back and compare.

I see that you added the locking flags too. Were the locking ops tested?

We don't add flashes or caps that are not tested, please specify in the
commit message what was tested.

> 
> Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
> Signed-off-by: ST Lin <stlin2@winbond.com>
> Test-by: Nicolas Boichat <drinkcat@chromium.org>
> 
> ---
> This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> The original patch is invalid,so re-submit a new patch for this.
>  drivers/mtd/spi-nor/winbond.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 17deabad57e1..cda4f8847bd6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
>                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> +       { "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,

We don't really care about the Package Type, it does not change the flash
caps, we can drop "xx" from the name. Also, the manufacturer can introduce
new flashes with different temperature ranges without changing the
flash caps, so we should drop the "I" from the name too.

The flash name would become w25q64jwm

> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,

w25q128jwm

> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,

w25q256jwm

> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },

w25q256jwm has 4 block protection bits, locking was not tested for this flash.

Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
@ 2020-04-26  3:24 wuxy
  2020-05-28  0:45   ` Nicolas Boichat
  0 siblings, 1 reply; 13+ messages in thread
From: wuxy @ 2020-04-26  3:24 UTC (permalink / raw)
  To: drinkcat, akpm, linux-mm, linux-kernel; +Cc: wuxy

From: wuxy <wuxy@bitland.corp-partner.google.com>

Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
flash ID in kukui series,this patch can support the new flash IDs.
This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
The original patch is invalid,so re-submit a new patch for this.

TEST=boot to shell,get the spi information from 'dmesg'.

Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
---
 drivers/mtd/spi-nor/winbond.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 17deabad57e1..cda4f8847bd6 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
 			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
 			    SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+	{ "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+	{ "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+	{ "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
 };
 
 /**
-- 
2.20.1




^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
  2020-04-26  3:24 wuxy
@ 2020-05-28  0:45   ` Nicolas Boichat
  0 siblings, 0 replies; 13+ messages in thread
From: Nicolas Boichat @ 2020-05-28  0:45 UTC (permalink / raw)
  To: wuxy; +Cc: Andrew Morton, linux-mm, lkml, wuxy

Hi,

First, you need to cc linux-mtd@lists.infradead.org, make sure to use
the get_maintainer.pl script to get the cc list (you're cc-ing mm
people here, but you should cc mtd folks instead).

On Sun, Apr 26, 2020 at 11:24 AM <wuxy@bitland.com.cn> wrote:
>
> From: wuxy <wuxy@bitland.corp-partner.google.com>
>
> Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
> flash ID in kukui series,this patch can support the new flash IDs.
> This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> The original patch is invalid,so re-submit a new patch for this.

This is historical stuff, and does not belong in the commit message,
please move that below the ---.

Also, since you're merely rebasing/fixing a patch authored by ST Lin,
I'd keep the original author and signed off:
Signed-off-by: ST Lin <stlin2@winbond.com>

Thanks!

>
> TEST=boot to shell,get the spi information from 'dmesg'.
>
> Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
> ---
>  drivers/mtd/spi-nor/winbond.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 17deabad57e1..cda4f8847bd6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
>                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> +       { "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
>  };
>
>  /**
> --
> 2.20.1
>
>
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
@ 2020-05-28  0:45   ` Nicolas Boichat
  0 siblings, 0 replies; 13+ messages in thread
From: Nicolas Boichat @ 2020-05-28  0:45 UTC (permalink / raw)
  To: wuxy; +Cc: Andrew Morton, linux-mm, lkml, wuxy

Hi,

First, you need to cc linux-mtd@lists.infradead.org, make sure to use
the get_maintainer.pl script to get the cc list (you're cc-ing mm
people here, but you should cc mtd folks instead).

On Sun, Apr 26, 2020 at 11:24 AM <wuxy@bitland.com.cn> wrote:
>
> From: wuxy <wuxy@bitland.corp-partner.google.com>
>
> Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
> flash ID in kukui series,this patch can support the new flash IDs.
> This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> The original patch is invalid,so re-submit a new patch for this.

This is historical stuff, and does not belong in the commit message,
please move that below the ---.

Also, since you're merely rebasing/fixing a patch authored by ST Lin,
I'd keep the original author and signed off:
Signed-off-by: ST Lin <stlin2@winbond.com>

Thanks!

>
> TEST=boot to shell,get the spi information from 'dmesg'.
>
> Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
> ---
>  drivers/mtd/spi-nor/winbond.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 17deabad57e1..cda4f8847bd6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
>                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> +       { "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
>  };
>
>  /**
> --
> 2.20.1
>
>
>


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2020-07-01  8:42 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28  2:55 [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs wuxy
2020-05-28  2:55 ` wuxy
2020-05-28  3:06 ` Nicolas Boichat
2020-05-28  3:06   ` Nicolas Boichat
     [not found]   ` <tencent_353523967C92024E04C83463@qq.com>
2020-05-28  3:18     ` Nicolas Boichat
2020-05-28  3:18       ` Nicolas Boichat
  -- strict thread matches above, loose matches on Subject: below --
2020-05-28  3:36 wuxy
2020-05-28  3:36 ` wuxy
2020-07-01  8:41 ` Tudor.Ambarus
2020-07-01  8:41   ` Tudor.Ambarus
2020-04-26  3:24 wuxy
2020-05-28  0:45 ` Nicolas Boichat
2020-05-28  0:45   ` Nicolas Boichat

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.