* [PATCH] qemu: Fix build when x11 is not in distro features
@ 2022-03-09 1:18 Khem Raj
2022-03-09 6:11 ` [OE-core] " Alexander Kanavin
[not found] ` <16DAA19DB5E87A22.14238@lists.openembedded.org>
0 siblings, 2 replies; 6+ messages in thread
From: Khem Raj @ 2022-03-09 1:18 UTC (permalink / raw)
To: openembedded-core; +Cc: Khem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/recipes-devtools/qemu/qemu_6.2.0.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-devtools/qemu/qemu_6.2.0.bb b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
index 062ed32b015..c7eef0a9d5e 100644
--- a/meta/recipes-devtools/qemu/qemu_6.2.0.bb
+++ b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
@@ -6,6 +6,8 @@ DEPENDS = "glib-2.0 zlib pixman bison-native ninja-native meson-native"
DEPENDS:append:libc-musl = " libucontext"
+CFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '', '-DEGL_NO_X11=1', d)}"
+
RDEPENDS:${PN}:class-target += "bash"
EXTRA_OECONF:append:class-target = " --target-list=${@get_qemu_target_list(d)}"
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] qemu: Fix build when x11 is not in distro features
2022-03-09 1:18 [PATCH] qemu: Fix build when x11 is not in distro features Khem Raj
@ 2022-03-09 6:11 ` Alexander Kanavin
2022-03-09 16:37 ` Khem Raj
[not found] ` <16DAA19DB5E87A22.14238@lists.openembedded.org>
1 sibling, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2022-03-09 6:11 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
Why is this issue not seen on autobuilder’s no-x11 job?
Alex
On Wed 9. Mar 2022 at 2.18, Khem Raj <raj.khem@gmail.com> wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-devtools/qemu/qemu_6.2.0.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/qemu/qemu_6.2.0.bb
> b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
> index 062ed32b015..c7eef0a9d5e 100644
> --- a/meta/recipes-devtools/qemu/qemu_6.2.0.bb
> +++ b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
> @@ -6,6 +6,8 @@ DEPENDS = "glib-2.0 zlib pixman bison-native ninja-native
> meson-native"
>
> DEPENDS:append:libc-musl = " libucontext"
>
> +CFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '',
> '-DEGL_NO_X11=1', d)}"
> +
> RDEPENDS:${PN}:class-target += "bash"
>
> EXTRA_OECONF:append:class-target = "
> --target-list=${@get_qemu_target_list(d)}"
> --
> 2.35.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#162946):
> https://lists.openembedded.org/g/openembedded-core/message/162946
> Mute This Topic: https://lists.openembedded.org/mt/89652908/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
[-- Attachment #2: Type: text/html, Size: 2744 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] qemu: Fix build when x11 is not in distro features
[not found] ` <16DAA19DB5E87A22.14238@lists.openembedded.org>
@ 2022-03-09 6:38 ` Alexander Kanavin
2022-03-09 16:46 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2022-03-09 6:38 UTC (permalink / raw)
To: Khem Raj, openembedded-core; +Cc: alex.kanavin
[-- Attachment #1: Type: text/plain, Size: 1638 bytes --]
Also, what error specifically are you seeing? How is your build set up?
Alex
On Wed 9. Mar 2022 at 7.11, Alexander Kanavin via lists.openembedded.org
<alex.kanavin=gmail.com@lists.openembedded.org> wrote:
> Why is this issue not seen on autobuilder’s no-x11 job?
>
> Alex
>
> On Wed 9. Mar 2022 at 2.18, Khem Raj <raj.khem@gmail.com> wrote:
>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> meta/recipes-devtools/qemu/qemu_6.2.0.bb | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-devtools/qemu/qemu_6.2.0.bb
>> b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
>> index 062ed32b015..c7eef0a9d5e 100644
>> --- a/meta/recipes-devtools/qemu/qemu_6.2.0.bb
>> +++ b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
>> @@ -6,6 +6,8 @@ DEPENDS = "glib-2.0 zlib pixman bison-native ninja-native
>> meson-native"
>>
>> DEPENDS:append:libc-musl = " libucontext"
>>
>> +CFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '',
>> '-DEGL_NO_X11=1', d)}"
>> +
>> RDEPENDS:${PN}:class-target += "bash"
>>
>> EXTRA_OECONF:append:class-target = "
>> --target-list=${@get_qemu_target_list(d)}"
>> --
>> 2.35.1
>>
>>
>>
>>
>>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#162947):
> https://lists.openembedded.org/g/openembedded-core/message/162947
> Mute This Topic: https://lists.openembedded.org/mt/89652908/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
[-- Attachment #2: Type: text/html, Size: 3422 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] qemu: Fix build when x11 is not in distro features
2022-03-09 6:11 ` [OE-core] " Alexander Kanavin
@ 2022-03-09 16:37 ` Khem Raj
0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2022-03-09 16:37 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: Patches and discussions about the oe-core layer
On Tue, Mar 8, 2022 at 10:11 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> Why is this issue not seen on autobuilder’s no-x11 job?
>
perhaps AB's no-x11 job is still using mesa and not an alternative
stack like mali or sgx ddk
if so then here is why
https://git.openembedded.org/openembedded-core/tree/meta/recipes-graphics/mesa/mesa.inc#n30
> Alex
>
> On Wed 9. Mar 2022 at 2.18, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> meta/recipes-devtools/qemu/qemu_6.2.0.bb | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-devtools/qemu/qemu_6.2.0.bb b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
>> index 062ed32b015..c7eef0a9d5e 100644
>> --- a/meta/recipes-devtools/qemu/qemu_6.2.0.bb
>> +++ b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
>> @@ -6,6 +6,8 @@ DEPENDS = "glib-2.0 zlib pixman bison-native ninja-native meson-native"
>>
>> DEPENDS:append:libc-musl = " libucontext"
>>
>> +CFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '', '-DEGL_NO_X11=1', d)}"
>> +
>> RDEPENDS:${PN}:class-target += "bash"
>>
>> EXTRA_OECONF:append:class-target = " --target-list=${@get_qemu_target_list(d)}"
>> --
>> 2.35.1
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#162946): https://lists.openembedded.org/g/openembedded-core/message/162946
>> Mute This Topic: https://lists.openembedded.org/mt/89652908/1686489
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] qemu: Fix build when x11 is not in distro features
2022-03-09 6:38 ` Alexander Kanavin
@ 2022-03-09 16:46 ` Khem Raj
2022-03-09 16:56 ` Alexander Kanavin
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2022-03-09 16:46 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: Patches and discussions about the oe-core layer
On Tue, Mar 8, 2022 at 10:38 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> Also, what error specifically are you seeing? How is your build set up?
>
There is use of MESA_EGL_NO_X11_HEADERS which is now renamed in newer headers to
EGL_NO_X11 from mesa/khronos headers, however this define is
relatively new and 3D stacks do not have this adopted but apps
like qemu and bunch of others depend on it, I guess they assume mesa.
One can argue that its better to fix the 3D stacks to behave
like mesa but this means every BSP using these stacks will need to
carry such a fix.
https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/include/EGL/eglplatform.h
> Alex
>
> On Wed 9. Mar 2022 at 7.11, Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote:
>>
>> Why is this issue not seen on autobuilder’s no-x11 job?
>>
>> Alex
>>
>> On Wed 9. Mar 2022 at 2.18, Khem Raj <raj.khem@gmail.com> wrote:
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> meta/recipes-devtools/qemu/qemu_6.2.0.bb | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/recipes-devtools/qemu/qemu_6.2.0.bb b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
>>> index 062ed32b015..c7eef0a9d5e 100644
>>> --- a/meta/recipes-devtools/qemu/qemu_6.2.0.bb
>>> +++ b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
>>> @@ -6,6 +6,8 @@ DEPENDS = "glib-2.0 zlib pixman bison-native ninja-native meson-native"
>>>
>>> DEPENDS:append:libc-musl = " libucontext"
>>>
>>> +CFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '', '-DEGL_NO_X11=1', d)}"
>>> +
>>> RDEPENDS:${PN}:class-target += "bash"
>>>
>>> EXTRA_OECONF:append:class-target = " --target-list=${@get_qemu_target_list(d)}"
>>> --
>>> 2.35.1
>>>
>>>
>>>
>>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#162947): https://lists.openembedded.org/g/openembedded-core/message/162947
>> Mute This Topic: https://lists.openembedded.org/mt/89652908/1686489
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] qemu: Fix build when x11 is not in distro features
2022-03-09 16:46 ` Khem Raj
@ 2022-03-09 16:56 ` Alexander Kanavin
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Kanavin @ 2022-03-09 16:56 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
Can you add this to the commit message please?
Alex
On Wed, 9 Mar 2022 at 17:47, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Tue, Mar 8, 2022 at 10:38 PM Alexander Kanavin
> <alex.kanavin@gmail.com> wrote:
> >
> > Also, what error specifically are you seeing? How is your build set up?
> >
>
> There is use of MESA_EGL_NO_X11_HEADERS which is now renamed in newer headers to
> EGL_NO_X11 from mesa/khronos headers, however this define is
> relatively new and 3D stacks do not have this adopted but apps
> like qemu and bunch of others depend on it, I guess they assume mesa.
> One can argue that its better to fix the 3D stacks to behave
> like mesa but this means every BSP using these stacks will need to
> carry such a fix.
>
> https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/include/EGL/eglplatform.h
>
> > Alex
> >
> > On Wed 9. Mar 2022 at 7.11, Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote:
> >>
> >> Why is this issue not seen on autobuilder’s no-x11 job?
> >>
> >> Alex
> >>
> >> On Wed 9. Mar 2022 at 2.18, Khem Raj <raj.khem@gmail.com> wrote:
> >>>
> >>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >>> ---
> >>> meta/recipes-devtools/qemu/qemu_6.2.0.bb | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/meta/recipes-devtools/qemu/qemu_6.2.0.bb b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
> >>> index 062ed32b015..c7eef0a9d5e 100644
> >>> --- a/meta/recipes-devtools/qemu/qemu_6.2.0.bb
> >>> +++ b/meta/recipes-devtools/qemu/qemu_6.2.0.bb
> >>> @@ -6,6 +6,8 @@ DEPENDS = "glib-2.0 zlib pixman bison-native ninja-native meson-native"
> >>>
> >>> DEPENDS:append:libc-musl = " libucontext"
> >>>
> >>> +CFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '', '-DEGL_NO_X11=1', d)}"
> >>> +
> >>> RDEPENDS:${PN}:class-target += "bash"
> >>>
> >>> EXTRA_OECONF:append:class-target = " --target-list=${@get_qemu_target_list(d)}"
> >>> --
> >>> 2.35.1
> >>>
> >>>
> >>>
> >>>
> >>
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >> Links: You receive all messages sent to this group.
> >> View/Reply Online (#162947): https://lists.openembedded.org/g/openembedded-core/message/162947
> >> Mute This Topic: https://lists.openembedded.org/mt/89652908/1686489
> >> Group Owner: openembedded-core+owner@lists.openembedded.org
> >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-09 16:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-09 1:18 [PATCH] qemu: Fix build when x11 is not in distro features Khem Raj
2022-03-09 6:11 ` [OE-core] " Alexander Kanavin
2022-03-09 16:37 ` Khem Raj
[not found] ` <16DAA19DB5E87A22.14238@lists.openembedded.org>
2022-03-09 6:38 ` Alexander Kanavin
2022-03-09 16:46 ` Khem Raj
2022-03-09 16:56 ` Alexander Kanavin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.