All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-gnome][PATCH 1/1] libnma: allow building nor mipsn32
@ 2020-04-09 18:24 Joe Slater
  2020-04-09 18:48 ` [oe] " Alexander Kanavin
  0 siblings, 1 reply; 2+ messages in thread
From: Joe Slater @ 2020-04-09 18:24 UTC (permalink / raw)
  To: openembedded-devel; +Cc: joe.slater, randy.macleod

go introspection is not support for mipsn32, so we must not try to build
vapi support.  Using sed allows us to change the meson option, if it is
present, to be set correctly, and is more flexible than a patch would be.

Signed-off-by: Joe Slater <joe.slater@windriver.com>
---
 meta-gnome/recipes-connectivity/libnma/libnma_1.8.28.bb | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/meta-gnome/recipes-connectivity/libnma/libnma_1.8.28.bb b/meta-gnome/recipes-connectivity/libnma/libnma_1.8.28.bb
index 267baff..f0f0064 100644
--- a/meta-gnome/recipes-connectivity/libnma/libnma_1.8.28.bb
+++ b/meta-gnome/recipes-connectivity/libnma/libnma_1.8.28.bb
@@ -19,3 +19,10 @@ PACKAGECONFIG[iso_codes] = "-Diso_codes=true,-Diso_codes=false,iso-codes,iso-cod
 PACKAGECONFIG[mobile_broadband_provider_info] = "-Dmobile_broadband_provider_info=true,-Dmobile_broadband_provider_info=false,mobile-broadband-provider-info,mobile-broadband-provider-info"
 
 GTKDOC_MESON_OPTION = "gtk_doc"
+
+# go object introspection is not supported for mipsn32, so we must disable trying
+# to build vapi.
+#
+do_configure_prepend_mipsarchn32 () {
+    sed -i "/^option('vapi/ s!true!false!" ${S}/meson_options.txt
+}
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [oe] [meta-gnome][PATCH 1/1] libnma: allow building nor mipsn32
  2020-04-09 18:24 [meta-gnome][PATCH 1/1] libnma: allow building nor mipsn32 Joe Slater
@ 2020-04-09 18:48 ` Alexander Kanavin
  0 siblings, 0 replies; 2+ messages in thread
From: Alexander Kanavin @ 2020-04-09 18:48 UTC (permalink / raw)
  To: Joe Slater; +Cc: OpenEmbedded Devel List, Randy MacLeod

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

On Thu, 9 Apr 2020 at 20:25, Joe Slater <joe.slater@windriver.com> wrote:

> go introspection is not support for mipsn32, so we must not try to build
> vapi support.  Using sed allows us to change the meson option, if it is
> present, to be set correctly, and is more flexible than a patch would be.
> +
> +# go object introspection is not supported for mipsn32, so we must
> disable trying
> +# to build vapi.
> +#
> +do_configure_prepend_mipsarchn32 () {
> +    sed -i "/^option('vapi/ s!true!false!" ${S}/meson_options.txt
> +}
>

Wait, what? Why don't you set the option directly:
EXTRA_OEMESON_mipsarchn32_append = "-Dvapi=false"
instead of hacking the default value with sed?

Alex

[-- Attachment #2: Type: text/html, Size: 1083 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-09 18:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-09 18:24 [meta-gnome][PATCH 1/1] libnma: allow building nor mipsn32 Joe Slater
2020-04-09 18:48 ` [oe] " Alexander Kanavin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.