[PATCH 1/1] gtk-immodules-cache: add conditional delay_to_first_boot

[PATCH 1/1] gtk-immodules-cache: add conditional delay_to_first_boot

[Joe Slater]

We might not be able to execute target code using qemu, so
defer to first boot in that case.

Signed-off-by: Joe Slater <joe.slater@windriver.com>
---
 meta/classes/gtk-immodules-cache.bbclass | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/classes/gtk-immodules-cache.bbclass b/meta/classes/gtk-immodules-cache.bbclass
index 9bb0af8..3b8acb1 100644
--- a/meta/classes/gtk-immodules-cache.bbclass
+++ b/meta/classes/gtk-immodules-cache.bbclass
@@ -10,13 +10,16 @@ GTKIMMODULES_PACKAGES ?= "${PN}"
 
 gtk_immodule_cache_postinst() {
 if [ "x$D" != "x" ]; then
+    # allow for not being able to execute target code via qemu
     $INTERCEPT_DIR/postinst_intercept update_gtk_immodules_cache ${PKG} \
             mlprefix=${MLPREFIX} \
             binprefix=${MLPREFIX} \
             libdir=${libdir} \
             libexecdir=${libexecdir} \
             base_libdir=${base_libdir} \
-            bindir=${bindir}
+            bindir=${bindir} || \
+    $INTERCEPT_DIR/postinst_intercept delay_to_first_boot ${PKG} \
+            mlprefix=${MLPREFIX}
 else
     if [ ! -z `which gtk-query-immodules-2.0` ]; then
         gtk-query-immodules-2.0 > ${libdir}/gtk-2.0/2.10.0/immodules.cache
-- 
2.7.4

Re: [PATCH 1/1] gtk-immodules-cache: add conditional delay_to_first_boot

[Alexander Kanavin]

2018-06-26 20:51 GMT+02:00 Joe Slater <joe.slater@windriver.com>:
> -            bindir=${bindir}
> +            bindir=${bindir} || \
> +    $INTERCEPT_DIR/postinst_intercept delay_to_first_boot ${PKG} \
> +            mlprefix=${MLPREFIX}

Please read the postinst_intercept script. It does not actually
execute qemu at all, and so never fails due to non-working qemu. It
only requests such execution at the end of package installation
transaction. Also, if such later qemu execution does fail, then the
postinst does get deferred to first boot automatically. How did you
come up with this patch?

Alex

Re: [PATCH 1/1] gtk-immodules-cache: add conditional delay_to_first_boot

[Slater, Joseph]

Actually, it is a screw-up trying to deal with something that was already fixed.  At least it never gets executed.

Joe
________________________________________
From: Alexander Kanavin [alex.kanavin@gmail.com]
Sent: Tuesday, June 26, 2018 12:19 PM
To: Slater, Joseph
Cc: OE-core
Subject: Re: [OE-core] [oe-core][PATCH 1/1] gtk-immodules-cache: add conditional delay_to_first_boot

2018-06-26 20:51 GMT+02:00 Joe Slater <joe.slater@windriver.com>:
> -            bindir=${bindir}
> +            bindir=${bindir} || \
> +    $INTERCEPT_DIR/postinst_intercept delay_to_first_boot ${PKG} \
> +            mlprefix=${MLPREFIX}

Please read the postinst_intercept script. It does not actually
execute qemu at all, and so never fails due to non-working qemu. It
only requests such execution at the end of package installation
transaction. Also, if such later qemu execution does fail, then the
postinst does get deferred to first boot automatically. How did you
come up with this patch?

Alex