[PATCH] mklibs: drop support for

[PATCH] mklibs: drop support for

[Alexander Kanavin]

This is not enabled or tested by default, and has never been
ported to python 3 upstream[1], which means it doesn't work at all
with plain poky. If you need it, please put it in a separate layer
and/or modernize to work with py3.

https://salsa.debian.org/installer-team/mklibs/-/blob/master/src/mklibs

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
---
 meta-poky/conf/local.conf.sample          | 5 +----
 meta-poky/conf/local.conf.sample.extended | 9 ---------
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/meta-poky/conf/local.conf.sample b/meta-poky/conf/local.conf.sample
index 68e71b930b..e0ba9a35ef 100644
--- a/meta-poky/conf/local.conf.sample
+++ b/meta-poky/conf/local.conf.sample
@@ -148,11 +148,8 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks"
 # enable extra features. Some available options which can be included in this variable
 # are:
 #   - 'buildstats' collect build statistics
-#   - 'image-mklibs' to reduce shared library files size for an image
 #   - 'image-prelink' in order to prelink the filesystem image
-# NOTE: if listing mklibs & prelink both, then make sure mklibs is before prelink
-# NOTE: mklibs also needs to be explicitly enabled for a given image, see local.conf.extended
-USER_CLASSES ?= "buildstats image-mklibs image-prelink"
+USER_CLASSES ?= "buildstats image-prelink"
 
 #
 # Runtime testing of images
diff --git a/meta-poky/conf/local.conf.sample.extended b/meta-poky/conf/local.conf.sample.extended
index 62415a43ed..024bf14af5 100644
--- a/meta-poky/conf/local.conf.sample.extended
+++ b/meta-poky/conf/local.conf.sample.extended
@@ -115,15 +115,6 @@ DISTRO_FEATURES_remove = "x11"
 #
 # TCMODE ?= "external-sourcery"
 
-# mklibs library size optimization is more useful to smaller images,
-# and less useful for bigger images. Also mklibs library optimization
-# can break the ABI compatibility, so should not be applied to the
-# images which are to be extended or upgraded later.
-#This enabled mklibs library size optimization just for the specified image.
-#MKLIBS_OPTIMIZED_IMAGES ?= "core-image-minimal"
-#This enable mklibs library size optimization will be for all the images.
-#MKLIBS_OPTIMIZED_IMAGES ?= "all"
-
 # This value is currently used by pseudo to determine if the recipe should
 # build both the 32-bit and 64-bit wrapper libraries on a 64-bit build system.
 #
-- 
2.29.0

Re: [poky] [PATCH] mklibs: drop support for

[Khem Raj]

On 11/1/20 7:22 AM, Alexander Kanavin wrote:
> This is not enabled or tested by default, and has never been
> ported to python 3 upstream[1], which means it doesn't work at all
> with plain poky. If you need it, please put it in a separate layer
> and/or modernize to work with py3.
> 
> https://salsa.debian.org/installer-team/mklibs/-/blob/master/src/mklibs
> 

how about trying this patch to make it work with python3? Since we use 
mklibs as a feature highlight of tools that yocto can provide users, its 
perhaps good to keep it working.

https://uclibc.org/~kraj/0001-mklib-Port-to-use-python3.patch


> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> ---
>   meta-poky/conf/local.conf.sample          | 5 +----
>   meta-poky/conf/local.conf.sample.extended | 9 ---------
>   2 files changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/meta-poky/conf/local.conf.sample b/meta-poky/conf/local.conf.sample
> index 68e71b930b..e0ba9a35ef 100644
> --- a/meta-poky/conf/local.conf.sample
> +++ b/meta-poky/conf/local.conf.sample
> @@ -148,11 +148,8 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks"
>   # enable extra features. Some available options which can be included in this variable
>   # are:
>   #   - 'buildstats' collect build statistics
> -#   - 'image-mklibs' to reduce shared library files size for an image
>   #   - 'image-prelink' in order to prelink the filesystem image
> -# NOTE: if listing mklibs & prelink both, then make sure mklibs is before prelink
> -# NOTE: mklibs also needs to be explicitly enabled for a given image, see local.conf.extended
> -USER_CLASSES ?= "buildstats image-mklibs image-prelink"
> +USER_CLASSES ?= "buildstats image-prelink"
>   
>   #
>   # Runtime testing of images
> diff --git a/meta-poky/conf/local.conf.sample.extended b/meta-poky/conf/local.conf.sample.extended
> index 62415a43ed..024bf14af5 100644
> --- a/meta-poky/conf/local.conf.sample.extended
> +++ b/meta-poky/conf/local.conf.sample.extended
> @@ -115,15 +115,6 @@ DISTRO_FEATURES_remove = "x11"
>   #
>   # TCMODE ?= "external-sourcery"
>   
> -# mklibs library size optimization is more useful to smaller images,
> -# and less useful for bigger images. Also mklibs library optimization
> -# can break the ABI compatibility, so should not be applied to the
> -# images which are to be extended or upgraded later.
> -#This enabled mklibs library size optimization just for the specified image.
> -#MKLIBS_OPTIMIZED_IMAGES ?= "core-image-minimal"
> -#This enable mklibs library size optimization will be for all the images.
> -#MKLIBS_OPTIMIZED_IMAGES ?= "all"
> -
>   # This value is currently used by pseudo to determine if the recipe should
>   # build both the 32-bit and 64-bit wrapper libraries on a 64-bit build system.
>   #
> 
> 
> 
> 
> 

Re: [poky] [PATCH] mklibs: drop support for

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 3349 bytes --]

Apologies, but I have no interest in custom patching, or otherwise
maintaining mklibs - there is no evidence that anyone uses it, or if it
works at all (as it hasn't been tested on the AB in years, if ever), and so
it has to go. There's been no real work on it since at least 2015.

Alex

On Sun, 1 Nov 2020 at 19:07, Khem Raj <raj.khem@gmail.com> wrote:

>
>
> On 11/1/20 7:22 AM, Alexander Kanavin wrote:
> > This is not enabled or tested by default, and has never been
> > ported to python 3 upstream[1], which means it doesn't work at all
> > with plain poky. If you need it, please put it in a separate layer
> > and/or modernize to work with py3.
> >
> > https://salsa.debian.org/installer-team/mklibs/-/blob/master/src/mklibs
> >
>
> how about trying this patch to make it work with python3? Since we use
> mklibs as a feature highlight of tools that yocto can provide users, its
> perhaps good to keep it working.
>
> https://uclibc.org/~kraj/0001-mklib-Port-to-use-python3.patch
>
>
> > Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> > ---
> >   meta-poky/conf/local.conf.sample          | 5 +----
> >   meta-poky/conf/local.conf.sample.extended | 9 ---------
> >   2 files changed, 1 insertion(+), 13 deletions(-)
> >
> > diff --git a/meta-poky/conf/local.conf.sample
> b/meta-poky/conf/local.conf.sample
> > index 68e71b930b..e0ba9a35ef 100644
> > --- a/meta-poky/conf/local.conf.sample
> > +++ b/meta-poky/conf/local.conf.sample
> > @@ -148,11 +148,8 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks"
> >   # enable extra features. Some available options which can be included
> in this variable
> >   # are:
> >   #   - 'buildstats' collect build statistics
> > -#   - 'image-mklibs' to reduce shared library files size for an image
> >   #   - 'image-prelink' in order to prelink the filesystem image
> > -# NOTE: if listing mklibs & prelink both, then make sure mklibs is
> before prelink
> > -# NOTE: mklibs also needs to be explicitly enabled for a given image,
> see local.conf.extended
> > -USER_CLASSES ?= "buildstats image-mklibs image-prelink"
> > +USER_CLASSES ?= "buildstats image-prelink"
> >
> >   #
> >   # Runtime testing of images
> > diff --git a/meta-poky/conf/local.conf.sample.extended
> b/meta-poky/conf/local.conf.sample.extended
> > index 62415a43ed..024bf14af5 100644
> > --- a/meta-poky/conf/local.conf.sample.extended
> > +++ b/meta-poky/conf/local.conf.sample.extended
> > @@ -115,15 +115,6 @@ DISTRO_FEATURES_remove = "x11"
> >   #
> >   # TCMODE ?= "external-sourcery"
> >
> > -# mklibs library size optimization is more useful to smaller images,
> > -# and less useful for bigger images. Also mklibs library optimization
> > -# can break the ABI compatibility, so should not be applied to the
> > -# images which are to be extended or upgraded later.
> > -#This enabled mklibs library size optimization just for the specified
> image.
> > -#MKLIBS_OPTIMIZED_IMAGES ?= "core-image-minimal"
> > -#This enable mklibs library size optimization will be for all the
> images.
> > -#MKLIBS_OPTIMIZED_IMAGES ?= "all"
> > -
> >   # This value is currently used by pseudo to determine if the recipe
> should
> >   # build both the 32-bit and 64-bit wrapper libraries on a 64-bit build
> system.
> >   #
> >
> >
> >
> > 
> >
>

[-- Attachment #2: Type: text/html, Size: 4412 bytes --]

Re: [poky] [PATCH] mklibs: drop support for

[Khem Raj]

On Sun, Nov 1, 2020 at 10:22 AM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> Apologies, but I have no interest in custom patching, or otherwise maintaining mklibs - there is no evidence that anyone uses it, or if it works at all (as it hasn't been tested on the AB in years, if ever), and so it has to go. There's been no real work on it since at least 2015.

 It ok if you don't have interest but let's not delete it. I will send
a patch to h

>
> Alex
>
> On Sun, 1 Nov 2020 at 19:07, Khem Raj <raj.khem@gmail.com> wrote:
>>
>>
>>
>> On 11/1/20 7:22 AM, Alexander Kanavin wrote:
>> > This is not enabled or tested by default, and has never been
>> > ported to python 3 upstream[1], which means it doesn't work at all
>> > with plain poky. If you need it, please put it in a separate layer
>> > and/or modernize to work with py3.
>> >
>> > https://salsa.debian.org/installer-team/mklibs/-/blob/master/src/mklibs
>> >
>>
>> how about trying this patch to make it work with python3? Since we use
>> mklibs as a feature highlight of tools that yocto can provide users, its
>> perhaps good to keep it working.
>>
>> https://uclibc.org/~kraj/0001-mklib-Port-to-use-python3.patch
>>
>>
>> > Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
>> > ---
>> >   meta-poky/conf/local.conf.sample          | 5 +----
>> >   meta-poky/conf/local.conf.sample.extended | 9 ---------
>> >   2 files changed, 1 insertion(+), 13 deletions(-)
>> >
>> > diff --git a/meta-poky/conf/local.conf.sample b/meta-poky/conf/local.conf.sample
>> > index 68e71b930b..e0ba9a35ef 100644
>> > --- a/meta-poky/conf/local.conf.sample
>> > +++ b/meta-poky/conf/local.conf.sample
>> > @@ -148,11 +148,8 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks"
>> >   # enable extra features. Some available options which can be included in this variable
>> >   # are:
>> >   #   - 'buildstats' collect build statistics
>> > -#   - 'image-mklibs' to reduce shared library files size for an image
>> >   #   - 'image-prelink' in order to prelink the filesystem image
>> > -# NOTE: if listing mklibs & prelink both, then make sure mklibs is before prelink
>> > -# NOTE: mklibs also needs to be explicitly enabled for a given image, see local.conf.extended
>> > -USER_CLASSES ?= "buildstats image-mklibs image-prelink"
>> > +USER_CLASSES ?= "buildstats image-prelink"
>> >
>> >   #
>> >   # Runtime testing of images
>> > diff --git a/meta-poky/conf/local.conf.sample.extended b/meta-poky/conf/local.conf.sample.extended
>> > index 62415a43ed..024bf14af5 100644
>> > --- a/meta-poky/conf/local.conf.sample.extended
>> > +++ b/meta-poky/conf/local.conf.sample.extended
>> > @@ -115,15 +115,6 @@ DISTRO_FEATURES_remove = "x11"
>> >   #
>> >   # TCMODE ?= "external-sourcery"
>> >
>> > -# mklibs library size optimization is more useful to smaller images,
>> > -# and less useful for bigger images. Also mklibs library optimization
>> > -# can break the ABI compatibility, so should not be applied to the
>> > -# images which are to be extended or upgraded later.
>> > -#This enabled mklibs library size optimization just for the specified image.
>> > -#MKLIBS_OPTIMIZED_IMAGES ?= "core-image-minimal"
>> > -#This enable mklibs library size optimization will be for all the images.
>> > -#MKLIBS_OPTIMIZED_IMAGES ?= "all"
>> > -
>> >   # This value is currently used by pseudo to determine if the recipe should
>> >   # build both the 32-bit and 64-bit wrapper libraries on a 64-bit build system.
>> >   #
>> >
>> >
>> >
>> > 
>> >