[PATCHv2] meta/recipes-graphics/waffle: Add inherit setuptools

[PATCHv2] meta/recipes-graphics/waffle: Add inherit setuptools

[Aníbal Limón]

Fixes,

...
| Program python3 found: YES (/home/anibal.limon/linaro/oe-rpb-master/build-410c/tmp-rpb-glibc/work/aarch64-linaro-linux/waffle/1.6.0-r0/recipe-sysroot-native/usr/bin/python3-native/python3)
|
| meson.build:36:0: ERROR: <ExternalProgram 'python3' -> ['/home/anibal.limon/linaro/oe-rpb-master/build-410c/tmp-rpb-glibc/work/aarch64-linaro-linux/waffle/1.6.0-r0/recipe-sysroot-native/usr/bin/python3-native/python3']> is not a valid python or it is missing setuptools
|
| A full log can be found at /home/anibal.limon/linaro/oe-rpb-master/build-410c/tmp-rpb-glibc/work/aarch64-linaro-linux/waffle/1.6.0-r0/build/meson-logs/meson-log.txt
| WARNING: exit code 1 from a shell command.
...

Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>
---
 meta/recipes-graphics/waffle/waffle_1.6.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/waffle/waffle_1.6.0.bb b/meta/recipes-graphics/waffle/waffle_1.6.0.bb
index 52cb1df899..48caf207c3 100644
--- a/meta/recipes-graphics/waffle/waffle_1.6.0.bb
+++ b/meta/recipes-graphics/waffle/waffle_1.6.0.bb
@@ -9,7 +9,7 @@ SRC_URI[sha256sum] = "d9c899f710c50cfdd00f5f4cdfeaef0687d8497362239bdde93bed6c90
 
 UPSTREAM_CHECK_URI = "http://www.waffle-gl.org/releases.html"
 
-inherit meson features_check lib_package bash-completion
+inherit meson setuptools3 features_check lib_package bash-completion
 
 # This should be overridden per-machine to reflect the capabilities of the GL
 # stack.
-- 
2.24.0

Re: [PATCHv2] meta/recipes-graphics/waffle: Add inherit setuptools

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

On Wed, 4 Dec 2019 at 20:04, Aníbal Limón <anibal.limon@linaro.org> wrote:

> -inherit meson features_check lib_package bash-completion
> +inherit meson setuptools3 features_check lib_package bash-completion
>

I don't think you actually need setuptools3 here, just target python3
dependency is enough.

Alex

[-- Attachment #2: Type: text/html, Size: 631 bytes --]

Re: [PATCHv2] meta/recipes-graphics/waffle: Add inherit setuptools

[Anibal Limon]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

On Wed, 4 Dec 2019 at 13:15, Alexander Kanavin <alex.kanavin@gmail.com>
wrote:

> On Wed, 4 Dec 2019 at 20:04, Aníbal Limón <anibal.limon@linaro.org> wrote:
>
>> -inherit meson features_check lib_package bash-completion
>> +inherit meson setuptools3 features_check lib_package bash-completion
>>
>
> I don't think you actually need setuptools3 here, just target python3
> dependency is enough.
>

Actually doesn't need python3 it needs python3-native with setuptools, not
need to depend of python3 for the target.

Anibal


>
> Alex
>

[-- Attachment #2: Type: text/html, Size: 1416 bytes --]

Re: [PATCHv2] meta/recipes-graphics/waffle: Add inherit setuptools

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

But inheriting setuptools does bring in the target python as well, and it’s the target python that fixes the issue, not setuptools.

Alex

> On 4 Dec 2019, at 21.51, Anibal Limon <anibal.limon@linaro.org> wrote:
> 
> 
> 
>> On Wed, 4 Dec 2019 at 13:15, Alexander Kanavin <alex.kanavin@gmail.com> wrote:
>>> On Wed, 4 Dec 2019 at 20:04, Aníbal Limón <anibal.limon@linaro.org> wrote:
>> 
>>> -inherit meson features_check lib_package bash-completion
>>> +inherit meson setuptools3 features_check lib_package bash-completion
>> 
>> I don't think you actually need setuptools3 here, just target python3 dependency is enough.
> 
> Actually doesn't need python3 it needs python3-native with setuptools, not need to depend of python3 for the target.
> 
> Anibal
>  
>> 
>> Alex

[-- Attachment #2: Type: text/html, Size: 1943 bytes --]

Re: [PATCHv2] meta/recipes-graphics/waffle: Add inherit setuptools

[Khem Raj]

On Wed, Dec 4, 2019 at 2:07 PM Alexander Kanavin <alex.kanavin@gmail.com> wrote:
>
> But inheriting setuptools does bring in the target python as well, and it’s the target python that fixes the issue, not setuptools.

perhaps setuptools3-native in deps is enough.

>
> Alex
>
> On 4 Dec 2019, at 21.51, Anibal Limon <anibal.limon@linaro.org> wrote:
>
>
>
> On Wed, 4 Dec 2019 at 13:15, Alexander Kanavin <alex.kanavin@gmail.com> wrote:
>>
>> On Wed, 4 Dec 2019 at 20:04, Aníbal Limón <anibal.limon@linaro.org> wrote:
>>>
>>> -inherit meson features_check lib_package bash-completion
>>> +inherit meson setuptools3 features_check lib_package bash-completion
>>
>>
>> I don't think you actually need setuptools3 here, just target python3 dependency is enough.
>
>
> Actually doesn't need python3 it needs python3-native with setuptools, not need to depend of python3 for the target.
>
> Anibal
>
>>
>>
>> Alex