All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bmap-tools: update to latest git master
@ 2020-05-14 14:21 Diego
  2020-05-14 17:31 ` [OE-core] " Alexander Kanavin
       [not found] ` <160EF5579BF06DF2.15154@lists.openembedded.org>
  0 siblings, 2 replies; 5+ messages in thread
From: Diego @ 2020-05-14 14:21 UTC (permalink / raw)
  To: openembedded-core; +Cc: Diego Rondini

Update to latest revision of git master to include, among other
improvements, support for zstd compression format.

Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
---
 meta/recipes-support/bmap-tools/bmap-tools_3.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb b/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
index 7c4db85b32..694c5f09be 100644
--- a/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
+++ b/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
@@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 SRC_URI = "git://github.com/intel/${BPN}"
 
-SRCREV = "db7087b883bf52cbff063ad17a41cc1cbb85104d"
+SRCREV = "a17f0e3ff8669dd3b1c44a741ae4f8162155faed"
 S = "${WORKDIR}/git"
 PV .= "+git${SRCPV}"
 
-- 
2.21.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [OE-core] [PATCH] bmap-tools: update to latest git master
  2020-05-14 14:21 [PATCH] bmap-tools: update to latest git master Diego
@ 2020-05-14 17:31 ` Alexander Kanavin
  2020-05-14 20:59   ` Diego
       [not found] ` <160EF5579BF06DF2.15154@lists.openembedded.org>
  1 sibling, 1 reply; 5+ messages in thread
From: Alexander Kanavin @ 2020-05-14 17:31 UTC (permalink / raw)
  To: Diego; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

You can't generally update to a random development commit, especially if PV
stays the same. Please ask upstream to make a new release.

Alex

On Thu, 14 May 2020 at 16:22, Diego <diego.rondini@kynetics.com> wrote:

> Update to latest revision of git master to include, among other
> improvements, support for zstd compression format.
>
> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
> ---
>  meta/recipes-support/bmap-tools/bmap-tools_3.5.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
> b/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
> index 7c4db85b32..694c5f09be 100644
> --- a/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
> +++ b/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>
>  SRC_URI = "git://github.com/intel/${BPN}
> <http://github.com/intel/$%7BBPN%7D>"
>
> -SRCREV = "db7087b883bf52cbff063ad17a41cc1cbb85104d"
> +SRCREV = "a17f0e3ff8669dd3b1c44a741ae4f8162155faed"
>  S = "${WORKDIR}/git"
>  PV .= "+git${SRCPV}"
>
> --
> 2.21.3
>
> 
>

[-- Attachment #2: Type: text/html, Size: 2093 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [OE-core] [PATCH] bmap-tools: update to latest git master
       [not found] ` <160EF5579BF06DF2.15154@lists.openembedded.org>
@ 2020-05-14 17:35   ` Alexander Kanavin
  0 siblings, 0 replies; 5+ messages in thread
From: Alexander Kanavin @ 2020-05-14 17:35 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: Diego, OE-core

[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]

Another option is to backport the needed patch.

Alex

On Thu, 14 May 2020 at 19:31, Alexander Kanavin via lists.openembedded.org
<alex.kanavin=gmail.com@lists.openembedded.org> wrote:

> You can't generally update to a random development commit, especially if
> PV stays the same. Please ask upstream to make a new release.
>
> Alex
>
> On Thu, 14 May 2020 at 16:22, Diego <diego.rondini@kynetics.com> wrote:
>
>> Update to latest revision of git master to include, among other
>> improvements, support for zstd compression format.
>>
>> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
>> ---
>>  meta/recipes-support/bmap-tools/bmap-tools_3.5.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
>> b/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
>> index 7c4db85b32..694c5f09be 100644
>> --- a/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
>> +++ b/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
>> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>>
>>  SRC_URI = "git://github.com/intel/${BPN}
>> <http://github.com/intel/$%7BBPN%7D>"
>>
>> -SRCREV = "db7087b883bf52cbff063ad17a41cc1cbb85104d"
>> +SRCREV = "a17f0e3ff8669dd3b1c44a741ae4f8162155faed"
>>  S = "${WORKDIR}/git"
>>  PV .= "+git${SRCPV}"
>>
>> --
>> 2.21.3
>>
>>
>> 
>

[-- Attachment #2: Type: text/html, Size: 2676 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [OE-core] [PATCH] bmap-tools: update to latest git master
  2020-05-14 17:31 ` [OE-core] " Alexander Kanavin
@ 2020-05-14 20:59   ` Diego
  2020-05-14 21:19     ` Alexander Kanavin
  0 siblings, 1 reply; 5+ messages in thread
From: Diego @ 2020-05-14 20:59 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]

Hi Alexander,

On Thu, May 14, 2020 at 7:31 PM Alexander Kanavin <alex.kanavin@gmail.com>
wrote:

> You can't generally update to a random development commit, especially if
> PV stays the same. Please ask upstream to make a new release.
>
>
Thank you for your feedback, I understand your point.
The odd thing is that the situation is already broken, as what's in oe-core
master right now is not bmap-tools release 3.5, but some "random
development commit" in between 3.5 and current master:
http://git.openembedded.org/openembedded-core/commit/meta/recipes-support/bmap-tools?id=3fbee26af2f3263180f75652b5dd6e50adb1d8fe

https://github.com/intel/bmap-tools/commits/master
Release 3.5:
https://github.com/intel/bmap-tools/commit/14b411a65c371e273fe599bee9e52bd9f9b751e1
Commit in oe-core:
https://github.com/intel/bmap-tools/commit/db7087b883bf52cbff063ad17a41cc1cbb85104d

What do you suggest?

Thanks
Diego Rondini


> Alex
>
> On Thu, 14 May 2020 at 16:22, Diego <diego.rondini@kynetics.com> wrote:
>
>> Update to latest revision of git master to include, among other
>> improvements, support for zstd compression format.
>>
>> Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
>> ---
>>  meta/recipes-support/bmap-tools/bmap-tools_3.5.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
>> b/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
>> index 7c4db85b32..694c5f09be 100644
>> --- a/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
>> +++ b/meta/recipes-support/bmap-tools/bmap-tools_3.5.bb
>> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>>
>>  SRC_URI = "git://github.com/intel/${BPN}
>> <http://github.com/intel/$%7BBPN%7D>"
>>
>> -SRCREV = "db7087b883bf52cbff063ad17a41cc1cbb85104d"
>> +SRCREV = "a17f0e3ff8669dd3b1c44a741ae4f8162155faed"
>>  S = "${WORKDIR}/git"
>>  PV .= "+git${SRCPV}"
>>
>> --
>> 2.21.3
>>
>> 
>>
>

[-- Attachment #2: Type: text/html, Size: 3970 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [OE-core] [PATCH] bmap-tools: update to latest git master
  2020-05-14 20:59   ` Diego
@ 2020-05-14 21:19     ` Alexander Kanavin
  0 siblings, 0 replies; 5+ messages in thread
From: Alexander Kanavin @ 2020-05-14 21:19 UTC (permalink / raw)
  To: Diego Rondini; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

On Thu, 14 May 2020 at 22:59, Diego Rondini <diego.rondini@kynetics.com>
wrote:

> Hi Alexander,
>
> On Thu, May 14, 2020 at 7:31 PM Alexander Kanavin <alex.kanavin@gmail.com>
> wrote:
>
>> You can't generally update to a random development commit, especially if
>> PV stays the same. Please ask upstream to make a new release.
>>
>>
> Thank you for your feedback, I understand your point.
> The odd thing is that the situation is already broken, as what's in
> oe-core master right now is not bmap-tools release 3.5, but some "random
> development commit" in between 3.5 and current master:
>
> http://git.openembedded.org/openembedded-core/commit/meta/recipes-support/bmap-tools?id=3fbee26af2f3263180f75652b5dd6e50adb1d8fe
>
> https://github.com/intel/bmap-tools/commits/master
> Release 3.5:
>
> https://github.com/intel/bmap-tools/commit/14b411a65c371e273fe599bee9e52bd9f9b751e1
> Commit in oe-core:
>
> https://github.com/intel/bmap-tools/commit/db7087b883bf52cbff063ad17a41cc1cbb85104d
>
> What do you suggest?
>

Right - generally we need to trust that version updates don't do this, and
there's no easy way to detect this. The recipe already does:
PV .= "+git${SRCPV}"
which is the standard way to mark "random development commits", so I'd say
resubmit your patch with an explanation in the commit log
that you're merely bumping one development snapshot to a newer development
snapshot.

[-- Attachment #2: Type: text/html, Size: 2697 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-05-14 21:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-14 14:21 [PATCH] bmap-tools: update to latest git master Diego
2020-05-14 17:31 ` [OE-core] " Alexander Kanavin
2020-05-14 20:59   ` Diego
2020-05-14 21:19     ` Alexander Kanavin
     [not found] ` <160EF5579BF06DF2.15154@lists.openembedded.org>
2020-05-14 17:35   ` Alexander Kanavin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.