Re: [AUH] u-boot: upgrading to 2019.01 FAILED

Re: [AUH] u-boot: upgrading to 2019.01 FAILED

[Marek Vasut]

On 1/17/19 11:44 AM, auh@auh.yoctoproject.org wrote:
> Hello,
> 
> You are receiving this email because you are the maintainer
> of *u-boot* recipe and this is to let you know that the automatic attempt
> to upgrade the recipe to *2019.01* has Failed(do_compile).
> 
> Detailed error information:
> 
> do_compile failed
> 
> 
> 
> Next steps:
>     - apply the patch: git am 0001-u-boot-upgrade-2018.11-2019.01.patch
>     - check the changes to upstream patches and summarize them in the commit message,
>     - compile an image that contains the package
>     - perform some basic sanity tests
>     - amend the patch and sign it off: git commit -s --reset-author --amend
>     - send it to the appropriate mailing list
> 
> Alternatively, if you believe the recipe should not be upgraded at this time,
> you can fill RECIPE_NO_UPDATE_REASON in respective recipe file so that
> automatic upgrades would no longer be attempted.
> 
> Please review the attached files for further information and build/update failures.
> Any problem please file a bug at https://bugzilla.yoctoproject.org/enter_bug.cgi?product=Automated%20Update%20Handler

Can AUH be fixed please ?

-- 
Best regards,
Marek Vasut

Re: [AUH] u-boot: upgrading to 2019.01 FAILED

[Alexander Kanavin]

On Fri, 18 Jan 2019 at 08:10, Marek Vasut <marek.vasut@gmail.com> wrote:

> > Next steps:
> >     - apply the patch: git am 0001-u-boot-upgrade-2018.11-2019.01.patch
> >     - check the changes to upstream patches and summarize them in the commit message,
> >     - compile an image that contains the package
> >     - perform some basic sanity tests
> >     - amend the patch and sign it off: git commit -s --reset-author --amend
> >     - send it to the appropriate mailing list
> >
> > Alternatively, if you believe the recipe should not be upgraded at this time,
> > you can fill RECIPE_NO_UPDATE_REASON in respective recipe file so that
> > automatic upgrades would no longer be attempted.
> >
> > Please review the attached files for further information and build/update failures.
> > Any problem please file a bug at https://bugzilla.yoctoproject.org/enter_bug.cgi?product=Automated%20Update%20Handler
>
> Can AUH be fixed please ?

We have previously discussed this: fixing devtool to upgrade several
recipes in a single transaction is non-trivial as it operates on one
recipe at a time. Please try to accept that AUH is not perfect and
take these emails as a reminder to do the version update (which you
should, as the listed maintainer). The attached patch is actually
useful as a starting point, you only need to rename the other two .bb
files to complete the update.

Alex

Re: [AUH] u-boot: upgrading to 2019.01 FAILED

[Marek Vasut]

On 1/18/19 10:39 AM, Alexander Kanavin wrote:
> On Fri, 18 Jan 2019 at 08:10, Marek Vasut <marek.vasut@gmail.com> wrote:
> 
>>> Next steps:
>>>     - apply the patch: git am 0001-u-boot-upgrade-2018.11-2019.01.patch
>>>     - check the changes to upstream patches and summarize them in the commit message,
>>>     - compile an image that contains the package
>>>     - perform some basic sanity tests
>>>     - amend the patch and sign it off: git commit -s --reset-author --amend
>>>     - send it to the appropriate mailing list
>>>
>>> Alternatively, if you believe the recipe should not be upgraded at this time,
>>> you can fill RECIPE_NO_UPDATE_REASON in respective recipe file so that
>>> automatic upgrades would no longer be attempted.
>>>
>>> Please review the attached files for further information and build/update failures.
>>> Any problem please file a bug at https://bugzilla.yoctoproject.org/enter_bug.cgi?product=Automated%20Update%20Handler
>>
>> Can AUH be fixed please ?
> 
> We have previously discussed this: fixing devtool to upgrade several
> recipes in a single transaction is non-trivial as it operates on one
> recipe at a time.

Can you elaborate what needs to be done to fix this ?

> Please try to accept that AUH is not perfect and
> take these emails as a reminder to do the version update (which you
> should, as the listed maintainer).

This kind of automated update seems like a perfect simple manual task
for a computer to do, so I'd prefer not to waste my time on it. I'm not
happy with "accepting that tooling is sub-par and thus do stuff
manually", I'd much rather see the tooling fixed so it can be useful.

> The attached patch is actually
> useful as a starting point, you only need to rename the other two .bb
> files to complete the update.
-- 
Best regards,
Marek Vasut

Re: [AUH] u-boot: upgrading to 2019.01 FAILED

[Richard Purdie]

On Sat, 2019-01-19 at 08:01 +0100, Marek Vasut wrote:
> On 1/18/19 10:39 AM, Alexander Kanavin wrote:
> > On Fri, 18 Jan 2019 at 08:10, Marek Vasut <marek.vasut@gmail.com> wrote:
> > 
> > > > Next steps:
> > > >     - apply the patch: git am 0001-u-boot-upgrade-2018.11-2019.01.patch
> > > >     - check the changes to upstream patches and summarize them in the commit message,
> > > >     - compile an image that contains the package
> > > >     - perform some basic sanity tests
> > > >     - amend the patch and sign it off: git commit -s --reset-author --amend
> > > >     - send it to the appropriate mailing list
> > > > 
> > > > Alternatively, if you believe the recipe should not be upgraded at this time,
> > > > you can fill RECIPE_NO_UPDATE_REASON in respective recipe file so that
> > > > automatic upgrades would no longer be attempted.
> > > > 
> > > > Please review the attached files for further information and build/update failures.
> > > > Any problem please file a bug at https://bugzilla.yoctoproject.org/enter_bug.cgi?product=Automated%20Update%20Handler
> > > 
> > > Can AUH be fixed please ?
> > 
> > We have previously discussed this: fixing devtool to upgrade several
> > recipes in a single transaction is non-trivial as it operates on one
> > recipe at a time.
> 
> Can you elaborate what needs to be done to fix this ?
> 
> > Please try to accept that AUH is not perfect and
> > take these emails as a reminder to do the version update (which you
> > should, as the listed maintainer).
> 
> This kind of automated update seems like a perfect simple manual task
> for a computer to do, so I'd prefer not to waste my time on it. I'm not
> happy with "accepting that tooling is sub-par and thus do stuff
> manually", I'd much rather see the tooling fixed so it can be useful.

The nice thing here is the tooling is all open source. Patches to
improve it to handle this case would be very welcome!

Cheers,

Richard

Re: [AUH] u-boot: upgrading to 2019.01 FAILED

[Alexander Kanavin]

On Sat, 19 Jan 2019 at 08:03, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> Can AUH be fixed please ?
> >
> > We have previously discussed this: fixing devtool to upgrade several
> > recipes in a single transaction is non-trivial as it operates on one
> > recipe at a time.
>
> Can you elaborate what needs to be done to fix this ?

You would need to teach devtool, specifically 'devtool upgrade',
'devtool finish' and 'devtool reset' to operate on several recipes in
a single transaction. Particularly, the operations need to be atomic -
either they succeed for all recipes or fail for all. They shouldn't
leave some recipes in an updated state, and other not. This is rather
non-trivial, as devtool is designed throughout to handle only one
recipe per operation. Also, it would be something of a corner case, as
something like 99% of recipes don't share include files, and so don't
need this.

That said, we can still easily make things better by dropping ${PV}
from u-boot-common.inc. That way devtool would still update u-boot
recipes one by one, but it would be able to build the result, so
you'll know straight away where the issues are. Then just apply the
patches using 'git am --3way' as they would all make the same change
to SRCREV, squash into one (if you want) and send to oe-core. I'll
send the ${PV} fix in a moment.

Alex