From: "Maciej Żenczykowski" <maze@google.com>
To: Lorenzo Colitti <lorenzo@google.com>
Cc: Rocco Yue <rocco.yue@mediatek.com>,
dsahern@gmail.com, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, rocco.yue@gmail.com,
chao.song@mediatek.com, yanjie.jiang@mediatek.com,
kuohong.wang@mediatek.com, Zhuoliang.Zhang@mediatek.com,
markzzzsmith@gmail.com
Subject: Re: [PATCH net-next] ipv6: don't generate link-local addr in random or privacy mode
Date: Wed, 17 Nov 2021 01:50:54 -0800 [thread overview]
Message-ID: <CANP3RGdrhrSYOnRRq1r6Uq6a4hK90f_KsUW2VOYQGW0GHMv-oQ@mail.gmail.com> (raw)
In-Reply-To: <CAKD1Yr3CMPWMmNNU6YvpBiaXVttS9T8qGVgmddijYfLSfK-Rog@mail.gmail.com>
> Can't 4 be the same as 3? The same netlink message can configure both
> the addr_gen_mode and the token, no?
>
> It seems to me that the following should work, and would be much simpler.
>
> 1. Bring the interface down. All addresses are deleted.
> 2. Send a netlink request to set addr_gen_mode RANDOM_LL_TOKEN or
> PRIVACY_LL_TOKEN and set the token.
> 3. Bring the interface up. Autoconf runs. The link-local address is
> generated from the token. An RS is sent. When the RA is received, the
> global address is generated using RFC 7217 or randomly.
Could you simply manually add an ipv6 link local address to the
interface while it is down (ip -6 addr add fe80::..../64 dev X), then
bring the interface up (ip link set dev X up)...
All that would need to happen is the automatic link local generation
would need to be suppressed if there's already a link local ip
configured - which sounds like a good idea anyway, since why have two?
(btw. even a manually added link local ip will get deleted when the
interface gets brought back down)
WARNING: multiple messages have this Message-ID (diff)
From: "Maciej Żenczykowski" <maze@google.com>
To: Lorenzo Colitti <lorenzo@google.com>
Cc: Rocco Yue <rocco.yue@mediatek.com>,
dsahern@gmail.com, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, rocco.yue@gmail.com,
chao.song@mediatek.com, yanjie.jiang@mediatek.com,
kuohong.wang@mediatek.com, Zhuoliang.Zhang@mediatek.com,
markzzzsmith@gmail.com
Subject: Re: [PATCH net-next] ipv6: don't generate link-local addr in random or privacy mode
Date: Wed, 17 Nov 2021 01:50:54 -0800 [thread overview]
Message-ID: <CANP3RGdrhrSYOnRRq1r6Uq6a4hK90f_KsUW2VOYQGW0GHMv-oQ@mail.gmail.com> (raw)
In-Reply-To: <CAKD1Yr3CMPWMmNNU6YvpBiaXVttS9T8qGVgmddijYfLSfK-Rog@mail.gmail.com>
> Can't 4 be the same as 3? The same netlink message can configure both
> the addr_gen_mode and the token, no?
>
> It seems to me that the following should work, and would be much simpler.
>
> 1. Bring the interface down. All addresses are deleted.
> 2. Send a netlink request to set addr_gen_mode RANDOM_LL_TOKEN or
> PRIVACY_LL_TOKEN and set the token.
> 3. Bring the interface up. Autoconf runs. The link-local address is
> generated from the token. An RS is sent. When the RA is received, the
> global address is generated using RFC 7217 or randomly.
Could you simply manually add an ipv6 link local address to the
interface while it is down (ip -6 addr add fe80::..../64 dev X), then
bring the interface up (ip link set dev X up)...
All that would need to happen is the automatic link local generation
would need to be suppressed if there's already a link local ip
configured - which sounds like a good idea anyway, since why have two?
(btw. even a manually added link local ip will get deleted when the
interface gets brought back down)
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: "Maciej Żenczykowski" <maze@google.com>
To: Lorenzo Colitti <lorenzo@google.com>
Cc: Rocco Yue <rocco.yue@mediatek.com>,
dsahern@gmail.com, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, rocco.yue@gmail.com,
chao.song@mediatek.com, yanjie.jiang@mediatek.com,
kuohong.wang@mediatek.com, Zhuoliang.Zhang@mediatek.com,
markzzzsmith@gmail.com
Subject: Re: [PATCH net-next] ipv6: don't generate link-local addr in random or privacy mode
Date: Wed, 17 Nov 2021 01:50:54 -0800 [thread overview]
Message-ID: <CANP3RGdrhrSYOnRRq1r6Uq6a4hK90f_KsUW2VOYQGW0GHMv-oQ@mail.gmail.com> (raw)
In-Reply-To: <CAKD1Yr3CMPWMmNNU6YvpBiaXVttS9T8qGVgmddijYfLSfK-Rog@mail.gmail.com>
> Can't 4 be the same as 3? The same netlink message can configure both
> the addr_gen_mode and the token, no?
>
> It seems to me that the following should work, and would be much simpler.
>
> 1. Bring the interface down. All addresses are deleted.
> 2. Send a netlink request to set addr_gen_mode RANDOM_LL_TOKEN or
> PRIVACY_LL_TOKEN and set the token.
> 3. Bring the interface up. Autoconf runs. The link-local address is
> generated from the token. An RS is sent. When the RA is received, the
> global address is generated using RFC 7217 or randomly.
Could you simply manually add an ipv6 link local address to the
interface while it is down (ip -6 addr add fe80::..../64 dev X), then
bring the interface up (ip link set dev X up)...
All that would need to happen is the automatic link local generation
would need to be suppressed if there's already a link local ip
configured - which sounds like a good idea anyway, since why have two?
(btw. even a manually added link local ip will get deleted when the
interface gets brought back down)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-17 9:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 6:09 [PATCH net-next v2] ipv6: don't generate link-local addr in random or privacy mode Rocco Yue
2021-11-16 6:09 ` Rocco Yue
2021-11-16 6:09 ` Rocco Yue
2021-11-16 20:21 ` David Ahern
2021-11-16 20:21 ` David Ahern
2021-11-16 20:21 ` David Ahern
2021-11-17 3:34 ` Jakub Kicinski
2021-11-17 3:34 ` Jakub Kicinski
2021-11-17 3:34 ` Jakub Kicinski
2021-11-17 5:09 ` Lorenzo Colitti
2021-11-17 5:09 ` Lorenzo Colitti
2021-11-17 5:09 ` Lorenzo Colitti
2021-11-17 7:17 ` [PATCH net-next] " Rocco Yue
2021-11-17 7:17 ` Rocco Yue
2021-11-17 7:17 ` Rocco Yue
2021-11-17 8:36 ` Lorenzo Colitti
2021-11-17 8:36 ` Lorenzo Colitti
2021-11-17 8:36 ` Lorenzo Colitti
2021-11-17 9:50 ` Maciej Żenczykowski [this message]
2021-11-17 9:50 ` Maciej Żenczykowski
2021-11-17 9:50 ` Maciej Żenczykowski
-- strict thread matches above, loose matches on Subject: below --
2021-11-17 5:59 Rocco Yue
2021-11-17 5:59 ` Rocco Yue
2021-11-09 6:55 Rocco Yue
2021-11-09 6:55 ` Rocco Yue
2021-11-09 6:55 ` Rocco Yue
2021-11-13 8:46 ` Rocco Yue
2021-11-13 8:46 ` Rocco Yue
2021-11-13 8:46 ` Rocco Yue
2021-11-13 16:34 ` David Ahern
2021-11-13 16:34 ` David Ahern
2021-11-13 16:34 ` David Ahern
2021-11-16 2:21 ` Rocco Yue
2021-11-16 2:21 ` Rocco Yue
2021-11-16 2:21 ` Rocco Yue
2021-11-16 2:40 ` David Ahern
2021-11-16 2:40 ` David Ahern
2021-11-16 2:40 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANP3RGdrhrSYOnRRq1r6Uq6a4hK90f_KsUW2VOYQGW0GHMv-oQ@mail.gmail.com \
--to=maze@google.com \
--cc=Zhuoliang.Zhang@mediatek.com \
--cc=chao.song@mediatek.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@google.com \
--cc=markzzzsmith@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rocco.yue@gmail.com \
--cc=rocco.yue@mediatek.com \
--cc=yanjie.jiang@mediatek.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.