Re: [OE-core] [PATCH v4] gstreamer1.0-plugins-bad/ugly: use the GPL-2.0-or-later only when it is in use

[Jose Quaresma <quaresma.jose@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2439 bytes --]

Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia
segunda, 7/03/2022 à(s) 15:50:

> On Mon, 2022-03-07 at 15:33 +0000, Peter Kjellerstedt wrote:
> > >
> > > diff --git a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-ugly_1.20.0.bb b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-ugly_1.20.0.bb
> > > index 9b6f80aa89..577ba16af7 100644
> > > --- a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-ugly_1.20.0.bb
> > > +++ b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-ugly_1.20.0.bb
> > > @@ -1,4 +1,5 @@
> > >  require gstreamer1.0-plugins-common.inc
> > > +require gstreamer1.0-plugins-license.inc
> > >
> > >  DESCRIPTION = "'Ugly GStreamer plugins"
> > >  HOMEPAGE = "https://gstreamer.freedesktop.org/"
> > > @@ -8,7 +9,6 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
> > >
> > >
> file://tests/check/elements/xingmux.c;beginline=1;endline=21;md5=4c771b8af188724855cb99cadd390068"
> > >
> > >  LICENSE = "LGPL-2.1-or-later & GPL-2.0-or-later"
> > > -LICENSE_FLAGS = "commercial"
> >
> > I still think this is wrong. I.e., the commercial flag is not
> > related to a plugin using GPL or not, but rather the fact that it
> > is in ugly. E.g., the reason may be patent considerations and
> > can apply to any of the plugins regardless of license.
>

yes i'm making some confusion here with the commercial flag and the GPL
license, the reason is:

faad have commercial flag
https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb?id=c0a4a0355d1f37849f47d9f29c5c5dbd59806a3a

resindvd don't have commercial flag
https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-multimedia/libdvdread/libdvdread_6.1.2.bb?id=1dc583540355ab6af483b20b945cbd7c42984ccf
https://git.openembedded.org/meta-openembedded/tree/meta-multimedia/recipes-multimedia/libdvdnav/libdvdnav_6.1.1.bb?id=51f61a7899f40e9910baea12217ed8a27ac09f62

x265 have commercial flag
https://git.openembedded.org/meta-openembedded/tree/meta-multimedia/recipes-multimedia/x265/x265_3.2.1.bb?id=90683147fa6840b16816a75154dba89725ddb0a3

I will drop the LICENSE_FLAGS change from my patch and will send a v5.

jose

>
> >
>
> Agreed, that flag should be independent of whether GPL is there or not.
>
> Cheers,
>
> Richard
>
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 4472 bytes --]