[PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

[PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

[jay.shen.teoh]

From: Teoh Jay Shen <jay.shen.teoh@intel.com>

Add the following line to common_errors list.

  [drm] Cannot find any crtc or sizes

This message is not harmful, it extended the coverage for drm error message.

Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
---
 meta/lib/oeqa/runtime/cases/parselogs.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py b/meta/lib/oeqa/runtime/cases/parselogs.py
index 2b8893d842..96da0b4f5c 100644
--- a/meta/lib/oeqa/runtime/cases/parselogs.py
+++ b/meta/lib/oeqa/runtime/cases/parselogs.py
@@ -32,6 +32,7 @@ common_errors = [
     "Failed to load module \"fbdev\"",
     "Failed to load module fbdev",
     "Failed to load module glx",
+    "[drm] Cannot find any crtc or sizes",
     "[drm] Cannot find any crtc or sizes - going 1024x768",
     "_OSC failed (AE_NOT_FOUND); disabling ASPM",
     "Open ACPI failed (/var/run/acpid.socket) (No such file or directory)",
-- 
2.33.1

Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]

Teoh, Jay Shen <jay.shen.teoh@intel.com> escreveu no dia quarta, 27/10/2021
à(s) 10:12:

> From: Teoh Jay Shen <jay.shen.teoh@intel.com>
>
> Add the following line to common_errors list.
>
>   [drm] Cannot find any crtc or sizes
>
> This message is not harmful, it extended the coverage for drm error
> message.
>
> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
> ---
>  meta/lib/oeqa/runtime/cases/parselogs.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py
> b/meta/lib/oeqa/runtime/cases/parselogs.py
> index 2b8893d842..96da0b4f5c 100644
> --- a/meta/lib/oeqa/runtime/cases/parselogs.py
> +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
> @@ -32,6 +32,7 @@ common_errors = [
>      "Failed to load module \"fbdev\"",
>      "Failed to load module fbdev",
>      "Failed to load module glx",
> +    "[drm] Cannot find any crtc or sizes",
>      "[drm] Cannot find any crtc or sizes - going 1024x768",
>

I think this one ^ can be removed


>      "_OSC failed (AE_NOT_FOUND); disabling ASPM",
>      "Open ACPI failed (/var/run/acpid.socket) (No such file or
> directory)",
> --
> 2.33.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#157507):
> https://lists.openembedded.org/g/openembedded-core/message/157507
> Mute This Topic: https://lists.openembedded.org/mt/86623483/5052612
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 3026 bytes --]

Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

[Khem Raj]

On Wed, Oct 27, 2021 at 2:24 AM Jose Quaresma <quaresma.jose@gmail.com> wrote:
>
>
>
> Teoh, Jay Shen <jay.shen.teoh@intel.com> escreveu no dia quarta, 27/10/2021 à(s) 10:12:
>>
>> From: Teoh Jay Shen <jay.shen.teoh@intel.com>
>>
>> Add the following line to common_errors list.
>>
>>   [drm] Cannot find any crtc or sizes
>>
>> This message is not harmful, it extended the coverage for drm error message.
>>
>> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
>> ---
>>  meta/lib/oeqa/runtime/cases/parselogs.py | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py b/meta/lib/oeqa/runtime/cases/parselogs.py
>> index 2b8893d842..96da0b4f5c 100644
>> --- a/meta/lib/oeqa/runtime/cases/parselogs.py
>> +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
>> @@ -32,6 +32,7 @@ common_errors = [
>>      "Failed to load module \"fbdev\"",
>>      "Failed to load module fbdev",
>>      "Failed to load module glx",
>> +    "[drm] Cannot find any crtc or sizes",
>>      "[drm] Cannot find any crtc or sizes - going 1024x768",
>
>
> I think this one ^ can be removed

will the first entry cover the case when a fallback size is set ?

>
>>
>>      "_OSC failed (AE_NOT_FOUND); disabling ASPM",
>>      "Open ACPI failed (/var/run/acpid.socket) (No such file or directory)",
>> --
>> 2.33.1
>>
>>
>>
>>
>
>
> --
> Best regards,
>
> José Quaresma
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#157508): https://lists.openembedded.org/g/openembedded-core/message/157508
> Mute This Topic: https://lists.openembedded.org/mt/86623483/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 2282 bytes --]

Khem Raj <raj.khem@gmail.com> escreveu no dia quarta, 27/10/2021 à(s) 17:17:

> On Wed, Oct 27, 2021 at 2:24 AM Jose Quaresma <quaresma.jose@gmail.com>
> wrote:
> >
> >
> >
> > Teoh, Jay Shen <jay.shen.teoh@intel.com> escreveu no dia quarta,
> 27/10/2021 à(s) 10:12:
> >>
> >> From: Teoh Jay Shen <jay.shen.teoh@intel.com>
> >>
> >> Add the following line to common_errors list.
> >>
> >>   [drm] Cannot find any crtc or sizes
> >>
> >> This message is not harmful, it extended the coverage for drm error
> message.
> >>
> >> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
> >> ---
> >>  meta/lib/oeqa/runtime/cases/parselogs.py | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py
> b/meta/lib/oeqa/runtime/cases/parselogs.py
> >> index 2b8893d842..96da0b4f5c 100644
> >> --- a/meta/lib/oeqa/runtime/cases/parselogs.py
> >> +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
> >> @@ -32,6 +32,7 @@ common_errors = [
> >>      "Failed to load module \"fbdev\"",
> >>      "Failed to load module fbdev",
> >>      "Failed to load module glx",
> >> +    "[drm] Cannot find any crtc or sizes",
> >>      "[drm] Cannot find any crtc or sizes - going 1024x768",
> >
> >
> > I think this one ^ can be removed
>
> will the first entry cover the case when a fallback size is set ?
>

 I think yes, "[drm] Cannot find any crtc or sizes" is a substring of
"[drm] Cannot find any crtc or sizes - going 1024x768"


> >
> >>
> >>      "_OSC failed (AE_NOT_FOUND); disabling ASPM",
> >>      "Open ACPI failed (/var/run/acpid.socket) (No such file or
> directory)",
> >> --
> >> 2.33.1
> >>
> >>
> >>
> >>
> >
> >
> > --
> > Best regards,
> >
> > José Quaresma
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#157508):
> https://lists.openembedded.org/g/openembedded-core/message/157508
> > Mute This Topic: https://lists.openembedded.org/mt/86623483/1997914
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>


-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 4085 bytes --]

RE: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

[Teoh, Jay Shen]

> -----Original Message-----
> From: Khem Raj <raj.khem@gmail.com>
> Sent: Thursday, 28 October, 2021 12:17 AM
> To: Jose Quaresma <quaresma.jose@gmail.com>
> Cc: Teoh, Jay Shen <jay.shen.teoh@intel.com>; OE-core <openembedded-
> core@lists.openembedded.org>
> Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in
> common errors list
> 
> On Wed, Oct 27, 2021 at 2:24 AM Jose Quaresma <quaresma.jose@gmail.com>
> wrote:
> >
> >
> >
> > Teoh, Jay Shen <jay.shen.teoh@intel.com> escreveu no dia quarta,
> 27/10/2021 à(s) 10:12:
> >>
> >> From: Teoh Jay Shen <jay.shen.teoh@intel.com>
> >>
> >> Add the following line to common_errors list.
> >>
> >>   [drm] Cannot find any crtc or sizes
> >>
> >> This message is not harmful, it extended the coverage for drm error message.
> >>
> >> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
> >> ---
> >>  meta/lib/oeqa/runtime/cases/parselogs.py | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py
> b/meta/lib/oeqa/runtime/cases/parselogs.py
> >> index 2b8893d842..96da0b4f5c 100644
> >> --- a/meta/lib/oeqa/runtime/cases/parselogs.py
> >> +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
> >> @@ -32,6 +32,7 @@ common_errors = [
> >>      "Failed to load module \"fbdev\"",
> >>      "Failed to load module fbdev",
> >>      "Failed to load module glx",
> >> +    "[drm] Cannot find any crtc or sizes",
> >>      "[drm] Cannot find any crtc or sizes - going 1024x768",
> >
> >
> > I think this one ^ can be removed
> 
> will the first entry cover the case when a fallback size is set ?

In that case, it won't cover it. That's why I am adding a new line to expand the coverage
 
> 
> >
> >>
> >>      "_OSC failed (AE_NOT_FOUND); disabling ASPM",
> >>      "Open ACPI failed (/var/run/acpid.socket) (No such file or directory)",
> >> --
> >> 2.33.1
> >>
> >>
> >>
> >>
> >
> >
> > --
> > Best regards,
> >
> > José Quaresma
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#157508):
> https://lists.openembedded.org/g/openembedded-core/message/157508
> > Mute This Topic: https://lists.openembedded.org/mt/86623483/1997914
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
> [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >

Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 2786 bytes --]

But then you can remove the previous line, right?

Alex

On Thu, 28 Oct 2021 at 12:08, Teoh, Jay Shen <jay.shen.teoh@intel.com>
wrote:

>
>
> > -----Original Message-----
> > From: Khem Raj <raj.khem@gmail.com>
> > Sent: Thursday, 28 October, 2021 12:17 AM
> > To: Jose Quaresma <quaresma.jose@gmail.com>
> > Cc: Teoh, Jay Shen <jay.shen.teoh@intel.com>; OE-core <openembedded-
> > core@lists.openembedded.org>
> > Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm
> failure in
> > common errors list
> >
> > On Wed, Oct 27, 2021 at 2:24 AM Jose Quaresma <quaresma.jose@gmail.com>
> > wrote:
> > >
> > >
> > >
> > > Teoh, Jay Shen <jay.shen.teoh@intel.com> escreveu no dia quarta,
> > 27/10/2021 à(s) 10:12:
> > >>
> > >> From: Teoh Jay Shen <jay.shen.teoh@intel.com>
> > >>
> > >> Add the following line to common_errors list.
> > >>
> > >>   [drm] Cannot find any crtc or sizes
> > >>
> > >> This message is not harmful, it extended the coverage for drm error
> message.
> > >>
> > >> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
> > >> ---
> > >>  meta/lib/oeqa/runtime/cases/parselogs.py | 1 +
> > >>  1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py
> > b/meta/lib/oeqa/runtime/cases/parselogs.py
> > >> index 2b8893d842..96da0b4f5c 100644
> > >> --- a/meta/lib/oeqa/runtime/cases/parselogs.py
> > >> +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
> > >> @@ -32,6 +32,7 @@ common_errors = [
> > >>      "Failed to load module \"fbdev\"",
> > >>      "Failed to load module fbdev",
> > >>      "Failed to load module glx",
> > >> +    "[drm] Cannot find any crtc or sizes",
> > >>      "[drm] Cannot find any crtc or sizes - going 1024x768",
> > >
> > >
> > > I think this one ^ can be removed
> >
> > will the first entry cover the case when a fallback size is set ?
>
> In that case, it won't cover it. That's why I am adding a new line to
> expand the coverage
>
> >
> > >
> > >>
> > >>      "_OSC failed (AE_NOT_FOUND); disabling ASPM",
> > >>      "Open ACPI failed (/var/run/acpid.socket) (No such file or
> directory)",
> > >> --
> > >> 2.33.1
> > >>
> > >>
> > >>
> > >>
> > >
> > >
> > > --
> > > Best regards,
> > >
> > > José Quaresma
> > >
> > >
> > >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#157584):
> https://lists.openembedded.org/g/openembedded-core/message/157584
> Mute This Topic: https://lists.openembedded.org/mt/86623483/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 4804 bytes --]

RE: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

[Teoh, Jay Shen]

[-- Attachment #1: Type: text/plain, Size: 3627 bytes --]

"[drm] Cannot find any crtc or sizes",
"[drm] Cannot find any crtc or sizes - going 1024x768",

Both lines are covering difference case, the first line covers the case when no fallback size is set, and second line covers the case when fallback size is set.

Thanks,
Jay

From: Alexander Kanavin <alex.kanavin@gmail.com>
Sent: Thursday, 28 October, 2021 6:10 PM
To: Teoh, Jay Shen <jay.shen.teoh@intel.com>
Cc: Khem Raj <raj.khem@gmail.com>; Jose Quaresma <quaresma.jose@gmail.com>; OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

But then you can remove the previous line, right?

Alex

On Thu, 28 Oct 2021 at 12:08, Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>> wrote:


> -----Original Message-----
> From: Khem Raj <raj.khem@gmail.com<mailto:raj.khem@gmail.com>>
> Sent: Thursday, 28 October, 2021 12:17 AM
> To: Jose Quaresma <quaresma.jose@gmail.com<mailto:quaresma.jose@gmail.com>>
> Cc: Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>>; OE-core <openembedded-
> core@lists.openembedded.org<mailto:core@lists.openembedded.org>>
> Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in
> common errors list
>
> On Wed, Oct 27, 2021 at 2:24 AM Jose Quaresma <quaresma.jose@gmail.com<mailto:quaresma.jose@gmail.com>>
> wrote:
> >
> >
> >
> > Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>> escreveu no dia quarta,
> 27/10/2021 à(s) 10:12:
> >>
> >> From: Teoh Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>>
> >>
> >> Add the following line to common_errors list.
> >>
> >>   [drm] Cannot find any crtc or sizes
> >>
> >> This message is not harmful, it extended the coverage for drm error message.
> >>
> >> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>>
> >> ---
> >>  meta/lib/oeqa/runtime/cases/parselogs.py | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py
> b/meta/lib/oeqa/runtime/cases/parselogs.py
> >> index 2b8893d842..96da0b4f5c 100644
> >> --- a/meta/lib/oeqa/runtime/cases/parselogs.py
> >> +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
> >> @@ -32,6 +32,7 @@ common_errors = [
> >>      "Failed to load module \"fbdev\"",
> >>      "Failed to load module fbdev",
> >>      "Failed to load module glx",
> >> +    "[drm] Cannot find any crtc or sizes",
> >>      "[drm] Cannot find any crtc or sizes - going 1024x768",
> >
> >
> > I think this one ^ can be removed
>
> will the first entry cover the case when a fallback size is set ?

In that case, it won't cover it. That's why I am adding a new line to expand the coverage

>
> >
> >>
> >>      "_OSC failed (AE_NOT_FOUND); disabling ASPM",
> >>      "Open ACPI failed (/var/run/acpid.socket) (No such file or directory)",
> >> --
> >> 2.33.1
> >>
> >>
> >>
> >>
> >
> >
> > --
> > Best regards,
> >
> > José Quaresma
> >
> >
> >

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#157584): https://lists.openembedded.org/g/openembedded-core/message/157584
Mute This Topic: https://lists.openembedded.org/mt/86623483/1686489
Group Owner: openembedded-core+owner@lists.openembedded.org<mailto:openembedded-core%2Bowner@lists.openembedded.org>
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com<mailto:alex.kanavin@gmail.com>]
-=-=-=-=-=-=-=-=-=-=-=-

[-- Attachment #2: Type: text/html, Size: 8138 bytes --]

Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 3809 bytes --]

I think the whole line doesn't have to match, it's enough if the string is
in it somewhere. You can verify by making the message even shorter, and
checking that it still works.

Alex

On Thu, 28 Oct 2021 at 12:15, Teoh, Jay Shen <jay.shen.teoh@intel.com>
wrote:

> "[drm] Cannot find any crtc or sizes",
> "[drm] Cannot find any crtc or sizes - going 1024x768",
>
>
>
> Both lines are covering difference case, the first line covers the case
> when no fallback size is set, and second line covers the case when fallback
> size is set.
>
>
>
> Thanks,
>
> Jay
>
>
>
> *From:* Alexander Kanavin <alex.kanavin@gmail.com>
> *Sent:* Thursday, 28 October, 2021 6:10 PM
> *To:* Teoh, Jay Shen <jay.shen.teoh@intel.com>
> *Cc:* Khem Raj <raj.khem@gmail.com>; Jose Quaresma <
> quaresma.jose@gmail.com>; OE-core <
> openembedded-core@lists.openembedded.org>
> *Subject:* Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm
> failure in common errors list
>
>
>
> But then you can remove the previous line, right?
>
>
>
> Alex
>
>
>
> On Thu, 28 Oct 2021 at 12:08, Teoh, Jay Shen <jay.shen.teoh@intel.com>
> wrote:
>
>
>
> > -----Original Message-----
> > From: Khem Raj <raj.khem@gmail.com>
> > Sent: Thursday, 28 October, 2021 12:17 AM
> > To: Jose Quaresma <quaresma.jose@gmail.com>
> > Cc: Teoh, Jay Shen <jay.shen.teoh@intel.com>; OE-core <openembedded-
> > core@lists.openembedded.org>
> > Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm
> failure in
> > common errors list
> >
> > On Wed, Oct 27, 2021 at 2:24 AM Jose Quaresma <quaresma.jose@gmail.com>
> > wrote:
> > >
> > >
> > >
> > > Teoh, Jay Shen <jay.shen.teoh@intel.com> escreveu no dia quarta,
> > 27/10/2021 à(s) 10:12:
> > >>
> > >> From: Teoh Jay Shen <jay.shen.teoh@intel.com>
> > >>
> > >> Add the following line to common_errors list.
> > >>
> > >>   [drm] Cannot find any crtc or sizes
> > >>
> > >> This message is not harmful, it extended the coverage for drm error
> message.
> > >>
> > >> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com>
> > >> ---
> > >>  meta/lib/oeqa/runtime/cases/parselogs.py | 1 +
> > >>  1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py
> > b/meta/lib/oeqa/runtime/cases/parselogs.py
> > >> index 2b8893d842..96da0b4f5c 100644
> > >> --- a/meta/lib/oeqa/runtime/cases/parselogs.py
> > >> +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
> > >> @@ -32,6 +32,7 @@ common_errors = [
> > >>      "Failed to load module \"fbdev\"",
> > >>      "Failed to load module fbdev",
> > >>      "Failed to load module glx",
> > >> +    "[drm] Cannot find any crtc or sizes",
> > >>      "[drm] Cannot find any crtc or sizes - going 1024x768",
> > >
> > >
> > > I think this one ^ can be removed
> >
> > will the first entry cover the case when a fallback size is set ?
>
> In that case, it won't cover it. That's why I am adding a new line to
> expand the coverage
>
> >
> > >
> > >>
> > >>      "_OSC failed (AE_NOT_FOUND); disabling ASPM",
> > >>      "Open ACPI failed (/var/run/acpid.socket) (No such file or
> directory)",
> > >> --
> > >> 2.33.1
> > >>
> > >>
> > >>
> > >>
> > >
> > >
> > > --
> > > Best regards,
> > >
> > > José Quaresma
> > >
> > >
> > >
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#157587):
> https://lists.openembedded.org/g/openembedded-core/message/157587
> Mute This Topic: https://lists.openembedded.org/mt/86623483/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 7774 bytes --]

RE: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

[Teoh, Jay Shen]

[-- Attachment #1: Type: text/plain, Size: 4260 bytes --]

Hi Alex, you're right, sorry I get confused with the question just now. Yes, the entire string doesn't have to match, it's enough if the string is part of the error message. I will go ahead and send out a v2 patch.

Thanks,
Jay

From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Alexander Kanavin
Sent: Thursday, 28 October, 2021 6:37 PM
To: Teoh, Jay Shen <jay.shen.teoh@intel.com>
Cc: Khem Raj <raj.khem@gmail.com>; Jose Quaresma <quaresma.jose@gmail.com>; OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

I think the whole line doesn't have to match, it's enough if the string is in it somewhere. You can verify by making the message even shorter, and checking that it still works.

Alex

On Thu, 28 Oct 2021 at 12:15, Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>> wrote:
"[drm] Cannot find any crtc or sizes",
"[drm] Cannot find any crtc or sizes - going 1024x768",

Both lines are covering difference case, the first line covers the case when no fallback size is set, and second line covers the case when fallback size is set.

Thanks,
Jay

From: Alexander Kanavin <alex.kanavin@gmail.com<mailto:alex.kanavin@gmail.com>>
Sent: Thursday, 28 October, 2021 6:10 PM
To: Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>>
Cc: Khem Raj <raj.khem@gmail.com<mailto:raj.khem@gmail.com>>; Jose Quaresma <quaresma.jose@gmail.com<mailto:quaresma.jose@gmail.com>>; OE-core <openembedded-core@lists.openembedded.org<mailto:openembedded-core@lists.openembedded.org>>
Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

But then you can remove the previous line, right?

Alex

On Thu, 28 Oct 2021 at 12:08, Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>> wrote:


> -----Original Message-----
> From: Khem Raj <raj.khem@gmail.com<mailto:raj.khem@gmail.com>>
> Sent: Thursday, 28 October, 2021 12:17 AM
> To: Jose Quaresma <quaresma.jose@gmail.com<mailto:quaresma.jose@gmail.com>>
> Cc: Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>>; OE-core <openembedded-
> core@lists.openembedded.org<mailto:core@lists.openembedded.org>>
> Subject: Re: [OE-core] [PATCH] oeqa/runtime/parselogs: whitelist drm failure in
> common errors list
>
> On Wed, Oct 27, 2021 at 2:24 AM Jose Quaresma <quaresma.jose@gmail.com<mailto:quaresma.jose@gmail.com>>
> wrote:
> >
> >
> >
> > Teoh, Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>> escreveu no dia quarta,
> 27/10/2021 à(s) 10:12:
> >>
> >> From: Teoh Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>>
> >>
> >> Add the following line to common_errors list.
> >>
> >>   [drm] Cannot find any crtc or sizes
> >>
> >> This message is not harmful, it extended the coverage for drm error message.
> >>
> >> Signed-off-by: Teoh Jay Shen <jay.shen.teoh@intel.com<mailto:jay.shen.teoh@intel.com>>
> >> ---
> >>  meta/lib/oeqa/runtime/cases/parselogs.py | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/meta/lib/oeqa/runtime/cases/parselogs.py
> b/meta/lib/oeqa/runtime/cases/parselogs.py
> >> index 2b8893d842..96da0b4f5c 100644
> >> --- a/meta/lib/oeqa/runtime/cases/parselogs.py
> >> +++ b/meta/lib/oeqa/runtime/cases/parselogs.py
> >> @@ -32,6 +32,7 @@ common_errors = [
> >>      "Failed to load module \"fbdev\"",
> >>      "Failed to load module fbdev",
> >>      "Failed to load module glx",
> >> +    "[drm] Cannot find any crtc or sizes",
> >>      "[drm] Cannot find any crtc or sizes - going 1024x768",
> >
> >
> > I think this one ^ can be removed
>
> will the first entry cover the case when a fallback size is set ?

In that case, it won't cover it. That's why I am adding a new line to expand the coverage

>
> >
> >>
> >>      "_OSC failed (AE_NOT_FOUND); disabling ASPM",
> >>      "Open ACPI failed (/var/run/acpid.socket) (No such file or directory)",
> >> --
> >> 2.33.1
> >>
> >>
> >>
> >>
> >
> >
> > --
> > Best regards,
> >
> > José Quaresma
> >
> >
> >



[-- Attachment #2: Type: text/html, Size: 10841 bytes --]

Re: [PATCH] oeqa/runtime/parselogs: whitelist drm failure in common errors list

[Teoh, Jay Shen]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

Hi Alex,

you're right, sorry I get confused with the question just now. Yes, the entire string doesn't have to match, it's enough if the string is part of the error message. I will go ahead and send out a v2 patch.

Thanks,

Jay

[-- Attachment #2: Type: text/html, Size: 669 bytes --]