Re: [OE-core] [PATCH] sstate: inside the threadedpool don't write to the shared localdata

[Jose Quaresma <quaresma.jose@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1791 bytes --]

Mark Hatle <mark.hatle@kernel.crashing.org> escreveu no dia segunda,
7/03/2022 à(s) 16:14:

> Note, it appears this bug is in honister as well.
>

is already a little old, dunfell needs this fix as well.

jose


>
> On 3/6/22 3:08 PM, Jose Quaresma wrote:
> > When inside the threadedpool we make a copy of the localdata
> > to avoid some race condition, so we need to use this new
> > localdata2 and stop write the shared localdata.
> >
> > Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> > ---
> >   meta/classes/sstate.bbclass | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
> > index dc9a2c085b..7aca415159 100644
> > --- a/meta/classes/sstate.bbclass
> > +++ b/meta/classes/sstate.bbclass
> > @@ -988,7 +988,7 @@ def sstate_checkhashes(sq_data, d, siginfo=False,
> currentcount=0, summary=True,
> >
> >               localdata2 = bb.data.createCopy(localdata)
> >               srcuri = "file://" + sstatefile
> > -            localdata.setVar('SRC_URI', srcuri)
> > +            localdata2.setVar('SRC_URI', srcuri)
> >               bb.debug(2, "SState: Attempting to fetch %s" % srcuri)
> >
> >               import traceback
> >
> >
> >
> >
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#162853):
> https://lists.openembedded.org/g/openembedded-core/message/162853
> Mute This Topic: https://lists.openembedded.org/mt/89597961/5052612
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 3178 bytes --]