From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jose Quaresma <quaresma.jose@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] sstate: inside the threadedpool don't write to the shared localdata
Date: Sun, 06 Mar 2022 21:22:50 +0000 [thread overview]
Message-ID: <dcdeda69bf242df78f2675ff9045654e97b1f0cb.camel@linuxfoundation.org> (raw)
In-Reply-To: <20220306210823.53177-1-quaresma.jose@gmail.com>
On Sun, 2022-03-06 at 21:08 +0000, Jose Quaresma wrote:
> When inside the threadedpool we make a copy of the localdata
> to avoid some race condition, so we need to use this new
> localdata2 and stop write the shared localdata.
>
> Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> ---
> meta/classes/sstate.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
> index dc9a2c085b..7aca415159 100644
> --- a/meta/classes/sstate.bbclass
> +++ b/meta/classes/sstate.bbclass
> @@ -988,7 +988,7 @@ def sstate_checkhashes(sq_data, d, siginfo=False, currentcount=0, summary=True,
>
> localdata2 = bb.data.createCopy(localdata)
> srcuri = "file://" + sstatefile
> - localdata.setVar('SRC_URI', srcuri)
> + localdata2.setVar('SRC_URI', srcuri)
> bb.debug(2, "SState: Attempting to fetch %s" % srcuri)
>
> import traceback
That looks like a good find and may explain a few things!
Cheers,
Richard
next prev parent reply other threads:[~2022-03-06 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-06 21:08 [PATCH] sstate: inside the threadedpool don't write to the shared localdata Jose Quaresma
2022-03-06 21:22 ` Richard Purdie [this message]
2022-03-07 16:14 ` [OE-core] " Mark Hatle
2022-03-07 17:30 ` Jose Quaresma
2022-03-07 17:40 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcdeda69bf242df78f2675ff9045654e97b1f0cb.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=quaresma.jose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.