All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-networking][PATCH] wireguard-tools: change path for wg-quick systemd unit
@ 2021-05-14 14:07 athomasset
  2021-05-14 14:21 ` [oe] " Khem Raj
  2021-05-14 17:06 ` Jose Quaresma
  0 siblings, 2 replies; 4+ messages in thread
From: athomasset @ 2021-05-14 14:07 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Adrian Thomasset

Fix error when enabling the wg-quick unit:

% systemctl enable wg-quick@wg0
Failed to enable unit: Unit file wg-quick@wg0.service does not exist

The wg-quick@.service template unit needs to be in /lib/systemd/system

Signed-off-by: Adrian Thomasset <adrian.thomasset@doulos.com>
---
 .../recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb b/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb
index f698b9a9a..e769f44b7 100644
--- a/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb
+++ b/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb
@@ -9,7 +9,7 @@ DEPENDS += "wireguard-module libmnl"
 
 do_install () {
     oe_runmake DESTDIR="${D}" PREFIX="${prefix}" SYSCONFDIR="${sysconfdir}" \
-        SYSTEMDUNITDIR="${systemd_unitdir}" \
+        SYSTEMDUNITDIR="${systemd_unitdir}/system" \
         WITH_SYSTEMDUNITS=${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'yes', '', d)} \
         WITH_BASHCOMPLETION=yes \
         WITH_WGQUICK=yes \
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [oe] [meta-networking][PATCH] wireguard-tools: change path for wg-quick systemd unit
  2021-05-14 14:07 [meta-networking][PATCH] wireguard-tools: change path for wg-quick systemd unit athomasset
@ 2021-05-14 14:21 ` Khem Raj
  2021-05-14 15:28   ` Adrian Thomasset
  2021-05-14 17:06 ` Jose Quaresma
  1 sibling, 1 reply; 4+ messages in thread
From: Khem Raj @ 2021-05-14 14:21 UTC (permalink / raw)
  To: Adrian Thomasset, openembedded-devel; +Cc: Adrian Thomasset

Hello Adrian

this is already fixed in master via commit 
https://git.openembedded.org/meta-openembedded/commit/?id=84681a31cfd3f7aa8cc89181c2c87ffffcbc261b
if you are proposing it for backport then add branch name in subject and 
CC armin

On 5/14/21 7:07 AM, Adrian Thomasset wrote:
> Fix error when enabling the wg-quick unit:
> 
> % systemctl enable wg-quick@wg0
> Failed to enable unit: Unit file wg-quick@wg0.service does not exist
> 
> The wg-quick@.service template unit needs to be in /lib/systemd/system
> 
> Signed-off-by: Adrian Thomasset <adrian.thomasset@doulos.com>
> ---
>   .../recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb b/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb
> index f698b9a9a..e769f44b7 100644
> --- a/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb
> +++ b/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb
> @@ -9,7 +9,7 @@ DEPENDS += "wireguard-module libmnl"
>   
>   do_install () {
>       oe_runmake DESTDIR="${D}" PREFIX="${prefix}" SYSCONFDIR="${sysconfdir}" \
> -        SYSTEMDUNITDIR="${systemd_unitdir}" \
> +        SYSTEMDUNITDIR="${systemd_unitdir}/system" \
>           WITH_SYSTEMDUNITS=${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'yes', '', d)} \
>           WITH_BASHCOMPLETION=yes \
>           WITH_WGQUICK=yes \
> 
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [oe] [meta-networking][PATCH] wireguard-tools: change path for wg-quick systemd unit
  2021-05-14 14:21 ` [oe] " Khem Raj
@ 2021-05-14 15:28   ` Adrian Thomasset
  0 siblings, 0 replies; 4+ messages in thread
From: Adrian Thomasset @ 2021-05-14 15:28 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembedded-devel, Adrian Thomasset

[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]

Hello Kehm,

Thanks for pointing this out, I missed the fix.
I will ask to get this backported to dunfell now.

Adrian



On Fri, May 14, 2021 at 3:21 PM Khem Raj <raj.khem@gmail.com> wrote:

> Hello Adrian
>
> this is already fixed in master via commit
>
> https://git.openembedded.org/meta-openembedded/commit/?id=84681a31cfd3f7aa8cc89181c2c87ffffcbc261b
> if you are proposing it for backport then add branch name in subject and
> CC armin
>
> On 5/14/21 7:07 AM, Adrian Thomasset wrote:
> > Fix error when enabling the wg-quick unit:
> >
> > % systemctl enable wg-quick@wg0
> > Failed to enable unit: Unit file wg-quick@wg0.service does not exist
> >
> > The wg-quick@.service template unit needs to be in /lib/systemd/system
> >
> > Signed-off-by: Adrian Thomasset <adrian.thomasset@doulos.com>
> > ---
> >   .../recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb    | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-networking/recipes-kernel/wireguard/
> wireguard-tools_1.0.20200319.bb
> b/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb
> > index f698b9a9a..e769f44b7 100644
> > --- a/meta-networking/recipes-kernel/wireguard/
> wireguard-tools_1.0.20200319.bb
> > +++ b/meta-networking/recipes-kernel/wireguard/
> wireguard-tools_1.0.20200319.bb
> > @@ -9,7 +9,7 @@ DEPENDS += "wireguard-module libmnl"
> >
> >   do_install () {
> >       oe_runmake DESTDIR="${D}" PREFIX="${prefix}"
> SYSCONFDIR="${sysconfdir}" \
> > -        SYSTEMDUNITDIR="${systemd_unitdir}" \
> > +        SYSTEMDUNITDIR="${systemd_unitdir}/system" \
> >           WITH_SYSTEMDUNITS=${@bb.utils.contains('DISTRO_FEATURES',
> 'systemd', 'yes', '', d)} \
> >           WITH_BASHCOMPLETION=yes \
> >           WITH_WGQUICK=yes \
> >
> >
> >
> > 
> >
>


-- 
Adrian Thomasset
t: 0117 923 1990
m: 0776 629 4010

[-- Attachment #2: Type: text/html, Size: 3279 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [oe] [meta-networking][PATCH] wireguard-tools: change path for wg-quick systemd unit
  2021-05-14 14:07 [meta-networking][PATCH] wireguard-tools: change path for wg-quick systemd unit athomasset
  2021-05-14 14:21 ` [oe] " Khem Raj
@ 2021-05-14 17:06 ` Jose Quaresma
  1 sibling, 0 replies; 4+ messages in thread
From: Jose Quaresma @ 2021-05-14 17:06 UTC (permalink / raw)
  To: Adrian Thomasset; +Cc: openembeded-devel, Adrian Thomasset

Hi,

Adrian Thomasset <athomasset@gmail.com> escreveu no dia sexta,
14/05/2021 à(s) 15:08:
>
> Fix error when enabling the wg-quick unit:
>
> % systemctl enable wg-quick@wg0
> Failed to enable unit: Unit file wg-quick@wg0.service does not exist
>
> The wg-quick@.service template unit needs to be in /lib/systemd/system
>
> Signed-off-by: Adrian Thomasset <adrian.thomasset@doulos.com>
> ---
>  .../recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb    | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb b/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb
> index f698b9a9a..e769f44b7 100644
> --- a/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb
> +++ b/meta-networking/recipes-kernel/wireguard/wireguard-tools_1.0.20200319.bb
> @@ -9,7 +9,7 @@ DEPENDS += "wireguard-module libmnl"
>
>  do_install () {
>      oe_runmake DESTDIR="${D}" PREFIX="${prefix}" SYSCONFDIR="${sysconfdir}" \
> -        SYSTEMDUNITDIR="${systemd_unitdir}" \
> +        SYSTEMDUNITDIR="${systemd_unitdir}/system" \

There is variable on bitbake for this:

SYSTEMDUNITDIR="${systemd_system_unitdir}"

>          WITH_SYSTEMDUNITS=${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'yes', '', d)} \
>          WITH_BASHCOMPLETION=yes \
>          WITH_WGQUICK=yes \
> --
> 2.25.1
>
>
> 
>


-- 
Best regards,

José Quaresma

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-14 17:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 14:07 [meta-networking][PATCH] wireguard-tools: change path for wg-quick systemd unit athomasset
2021-05-14 14:21 ` [oe] " Khem Raj
2021-05-14 15:28   ` Adrian Thomasset
2021-05-14 17:06 ` Jose Quaresma

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.