* [Buildroot] [PATCH 1/1] cc-tool: use the same C++ standard as boost
@ 2018-10-22 14:18 Ferdinand van Aartsen
2018-10-23 11:18 ` Matthew Weber
0 siblings, 1 reply; 5+ messages in thread
From: Ferdinand van Aartsen @ 2018-10-22 14:18 UTC (permalink / raw)
To: buildroot
When boost context is enabled, we build boost with -std=c++11.
That causes cc-tool to fail, which was using the gcc default c++14.
Signed-off-by: Ferdinand van Aartsen <ferdinand@ombud.nl>
---
package/cc-tool/cc-tool.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/cc-tool/cc-tool.mk b/package/cc-tool/cc-tool.mk
index e170e06a21..d5de920f6a 100644
--- a/package/cc-tool/cc-tool.mk
+++ b/package/cc-tool/cc-tool.mk
@@ -18,6 +18,11 @@ CC_TOOL_AUTORECONF = YES
CC_TOOL_CONF_OPTS = --with-boost=$(STAGING_DIR)/usr
CC_TOOL_CONF_ENV = LIBS="$(CC_TOOL_LIBS)"
+# With boost context selected, boost gets built with c++11
+ifeq ($(BR2_PACKAGE_BOOST_CONTEXT)$(BR2_TOOLCHAIN_GCC_AT_LEAST_4_7),yy)
+CC_TOOL_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11"
+endif
+
# Help boost.m4 find the Boost Regex library, which needs the pthread
# library, but isn't detected using a modern (pkg-config) mechanism.
ifeq ($(BR2_STATIC_LIBS),y)
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] cc-tool: use the same C++ standard as boost
2018-10-22 14:18 [Buildroot] [PATCH 1/1] cc-tool: use the same C++ standard as boost Ferdinand van Aartsen
@ 2018-10-23 11:18 ` Matthew Weber
2018-10-23 13:03 ` Ferdinand van Aartsen
0 siblings, 1 reply; 5+ messages in thread
From: Matthew Weber @ 2018-10-23 11:18 UTC (permalink / raw)
To: buildroot
Ferdinand,
On Mon, Oct 22, 2018 at 9:18 AM Ferdinand van Aartsen
<ferdinand@ombud.nl> wrote:
>
> When boost context is enabled, we build boost with -std=c++11.
> That causes cc-tool to fail, which was using the gcc default c++14.
>
> Signed-off-by: Ferdinand van Aartsen <ferdinand@ombud.nl>
> ---
> package/cc-tool/cc-tool.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/cc-tool/cc-tool.mk b/package/cc-tool/cc-tool.mk
> index e170e06a21..d5de920f6a 100644
> --- a/package/cc-tool/cc-tool.mk
> +++ b/package/cc-tool/cc-tool.mk
> @@ -18,6 +18,11 @@ CC_TOOL_AUTORECONF = YES
> CC_TOOL_CONF_OPTS = --with-boost=$(STAGING_DIR)/usr
> CC_TOOL_CONF_ENV = LIBS="$(CC_TOOL_LIBS)"
>
> +# With boost context selected, boost gets built with c++11
> +ifeq ($(BR2_PACKAGE_BOOST_CONTEXT)$(BR2_TOOLCHAIN_GCC_AT_LEAST_4_7),yy)
> +CC_TOOL_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11"
> +endif
> +
> # Help boost.m4 find the Boost Regex library, which needs the pthread
> # library, but isn't detected using a modern (pkg-config) mechanism.
> ifeq ($(BR2_STATIC_LIBS),y)
> --
I believe this one is related to this patch, any impacts?
http://patchwork.ozlabs.org/patch/983327/
Matt
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] cc-tool: use the same C++ standard as boost
2018-10-23 11:18 ` Matthew Weber
@ 2018-10-23 13:03 ` Ferdinand van Aartsen
2018-10-23 13:12 ` Matthew Weber
2018-10-23 17:58 ` Arnout Vandecappelle
0 siblings, 2 replies; 5+ messages in thread
From: Ferdinand van Aartsen @ 2018-10-23 13:03 UTC (permalink / raw)
To: buildroot
Matthew Weber schreef op 2018-10-23 13:18:
> Ferdinand,
>
> On Mon, Oct 22, 2018 at 9:18 AM Ferdinand van Aartsen
> <ferdinand@ombud.nl> wrote:
>>
>> When boost context is enabled, we build boost with -std=c++11.
>> That causes cc-tool to fail, which was using the gcc default c++14.
>>
>> Signed-off-by: Ferdinand van Aartsen <ferdinand@ombud.nl>
>> ---
>> package/cc-tool/cc-tool.mk | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/package/cc-tool/cc-tool.mk b/package/cc-tool/cc-tool.mk
>> index e170e06a21..d5de920f6a 100644
>> --- a/package/cc-tool/cc-tool.mk
>> +++ b/package/cc-tool/cc-tool.mk
>> @@ -18,6 +18,11 @@ CC_TOOL_AUTORECONF = YES
>> CC_TOOL_CONF_OPTS = --with-boost=$(STAGING_DIR)/usr
>> CC_TOOL_CONF_ENV = LIBS="$(CC_TOOL_LIBS)"
>>
>> +# With boost context selected, boost gets built with c++11
>> +ifeq
>> ($(BR2_PACKAGE_BOOST_CONTEXT)$(BR2_TOOLCHAIN_GCC_AT_LEAST_4_7),yy)
>> +CC_TOOL_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11"
>> +endif
>> +
>> # Help boost.m4 find the Boost Regex library, which needs the pthread
>> # library, but isn't detected using a modern (pkg-config) mechanism.
>> ifeq ($(BR2_STATIC_LIBS),y)
>> --
>
> I believe this one is related to this patch, any impacts?
> http://patchwork.ozlabs.org/patch/983327/
>
You're right, hadn't spotted that one, then that seems to be the correct
solution.
Ferdinand
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] cc-tool: use the same C++ standard as boost
2018-10-23 13:03 ` Ferdinand van Aartsen
@ 2018-10-23 13:12 ` Matthew Weber
2018-10-23 17:58 ` Arnout Vandecappelle
1 sibling, 0 replies; 5+ messages in thread
From: Matthew Weber @ 2018-10-23 13:12 UTC (permalink / raw)
To: buildroot
Ferdinand,
On Tue, Oct 23, 2018 at 8:05 AM Ferdinand van Aartsen
<ferdinand@ombud.nl> wrote:
>
> Matthew Weber schreef op 2018-10-23 13:18:
> > Ferdinand,
> >
> > On Mon, Oct 22, 2018 at 9:18 AM Ferdinand van Aartsen
> > <ferdinand@ombud.nl> wrote:
> >>
> >> When boost context is enabled, we build boost with -std=c++11.
> >> That causes cc-tool to fail, which was using the gcc default c++14.
> >>
> >> Signed-off-by: Ferdinand van Aartsen <ferdinand@ombud.nl>
> >> ---
> >> package/cc-tool/cc-tool.mk | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/package/cc-tool/cc-tool.mk b/package/cc-tool/cc-tool.mk
> >> index e170e06a21..d5de920f6a 100644
> >> --- a/package/cc-tool/cc-tool.mk
> >> +++ b/package/cc-tool/cc-tool.mk
> >> @@ -18,6 +18,11 @@ CC_TOOL_AUTORECONF = YES
> >> CC_TOOL_CONF_OPTS = --with-boost=$(STAGING_DIR)/usr
> >> CC_TOOL_CONF_ENV = LIBS="$(CC_TOOL_LIBS)"
> >>
> >> +# With boost context selected, boost gets built with c++11
> >> +ifeq
> >> ($(BR2_PACKAGE_BOOST_CONTEXT)$(BR2_TOOLCHAIN_GCC_AT_LEAST_4_7),yy)
> >> +CC_TOOL_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11"
> >> +endif
> >> +
> >> # Help boost.m4 find the Boost Regex library, which needs the pthread
> >> # library, but isn't detected using a modern (pkg-config) mechanism.
> >> ifeq ($(BR2_STATIC_LIBS),y)
> >> --
> >
> > I believe this one is related to this patch, any impacts?
> > http://patchwork.ozlabs.org/patch/983327/
> >
>
> You're right, hadn't spotted that one, then that seems to be the correct
> solution.
Would you mind providing your review/tested by on that series?
Thanks!
Matt
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] cc-tool: use the same C++ standard as boost
2018-10-23 13:03 ` Ferdinand van Aartsen
2018-10-23 13:12 ` Matthew Weber
@ 2018-10-23 17:58 ` Arnout Vandecappelle
1 sibling, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2018-10-23 17:58 UTC (permalink / raw)
To: buildroot
On 10/23/18 2:03 PM, Ferdinand van Aartsen wrote:
> Matthew Weber schreef op 2018-10-23 13:18:
>> Ferdinand,
>>
>> On Mon, Oct 22, 2018 at 9:18 AM Ferdinand van Aartsen
>> <ferdinand@ombud.nl> wrote:
>>>
>>> When boost context is enabled, we build boost with -std=c++11.
>>> That causes cc-tool to fail, which was using the gcc default c++14.
>>>
>>> Signed-off-by: Ferdinand van Aartsen <ferdinand@ombud.nl>
>>> ---
>>> ?package/cc-tool/cc-tool.mk | 5 +++++
>>> ?1 file changed, 5 insertions(+)
>>>
>>> diff --git a/package/cc-tool/cc-tool.mk b/package/cc-tool/cc-tool.mk
>>> index e170e06a21..d5de920f6a 100644
>>> --- a/package/cc-tool/cc-tool.mk
>>> +++ b/package/cc-tool/cc-tool.mk
>>> @@ -18,6 +18,11 @@ CC_TOOL_AUTORECONF = YES
>>> ?CC_TOOL_CONF_OPTS = --with-boost=$(STAGING_DIR)/usr
>>> ?CC_TOOL_CONF_ENV = LIBS="$(CC_TOOL_LIBS)"
>>>
>>> +# With boost context selected, boost gets built with c++11
>>> +ifeq ($(BR2_PACKAGE_BOOST_CONTEXT)$(BR2_TOOLCHAIN_GCC_AT_LEAST_4_7),yy)
>>> +CC_TOOL_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11"
>>> +endif
>>> +
>>> ?# Help boost.m4 find the Boost Regex library, which needs the pthread
>>> ?# library, but isn't detected using a modern (pkg-config) mechanism.
>>> ?ifeq ($(BR2_STATIC_LIBS),y)
>>> --
>>
>> I believe this one is related to this patch, any impacts?
>> http://patchwork.ozlabs.org/patch/983327/
>>
>
> You're right, hadn't spotted that one, then that seems to be the correct solution.
I've marked this one as Superseded in patchwork.
Regards,
Arnout
>
> Ferdinand
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-23 17:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-22 14:18 [Buildroot] [PATCH 1/1] cc-tool: use the same C++ standard as boost Ferdinand van Aartsen
2018-10-23 11:18 ` Matthew Weber
2018-10-23 13:03 ` Ferdinand van Aartsen
2018-10-23 13:12 ` Matthew Weber
2018-10-23 17:58 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.