* [Buildroot] [PATCH] package/bridge-utils: fix missing PATH_MAX include
@ 2021-04-12 14:37 Matt Weber
2021-04-12 14:52 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Matt Weber @ 2021-04-12 14:37 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/3ec818e676827c03f08c264c6c7a53b025b7ba1d/
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
| 63 +++++++++++++++++++
1 file changed, 63 insertions(+)
create mode 100644 package/bridge-utils/0001-Include-header-for-use-of-PATH_MAX.patch
--git a/package/bridge-utils/0001-Include-header-for-use-of-PATH_MAX.patch b/package/bridge-utils/0001-Include-header-for-use-of-PATH_MAX.patch
new file mode 100644
index 0000000000..759b772519
--- /dev/null
+++ b/package/bridge-utils/0001-Include-header-for-use-of-PATH_MAX.patch
@@ -0,0 +1,63 @@
+From 19694aaf08b7ef2f2a1bd549915b133bfbcd422e Mon Sep 17 00:00:00 2001
+From: Matt Weber <matthew.weber@rockwellcollins.com>
+Date: Mon, 12 Apr 2021 09:25:16 -0500
+Subject: [PATCH] Include header for use of PATH_MAX
+
+Since a1f20223cfcf7b9eae8c9e7e7a07e7bf1377f65b in some build
+configurations PATH_MAX is undefined.
+
+Build log from Buildroot testing failure:
+http://autobuild.buildroot.net/results/3ec818e676827c03f08c264c6c7a53b025b7ba1d/build-end.log
+
+...
+/home/giuliobenetti/autobuild/run/instance-0/output-1/host/bin/arm-buildroot-linux-musleabihf-gcc -Wall -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -I/home/giuliobenetti/autobuild/run/instance-0/output-1/host/arm-buildroot-linux-musleabihf/sysroot/usr/include -c libbridge_misc.c
+libbridge_init.c: In function 'isbridge':
+libbridge_init.c:49:12: error: 'PATH_MAX' undeclared (first use in this function); did you mean 'AF_MAX'?
+ 49 | char path[PATH_MAX];
+ | ^~~~~~~~
+ | AF_MAX
+libbridge_init.c:49:12: note: each undeclared identifier is reported only once for each function it appears in
+libbridge_init.c:49:7: warning: unused variable 'path' [-Wunused-variable]
+ 49 | char path[PATH_MAX];
+ | ^~~~
+make[2]: *** [Makefile:37: libbridge_init.o] Error 1
+make[2]: *** Waiting for unfinished jobs....
+libbridge_devif.c: In function 'fpopen':
+libbridge_devif.c:33:12: error: 'PATH_MAX' undeclared (first use in this function); did you mean 'AF_MAX'?
+ 33 | char path[PATH_MAX];
+ | ^~~~~~~~
+ | AF_MAX
+
+Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
+---
+ libbridge/libbridge_devif.c | 1 +
+ libbridge/libbridge_init.c | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/libbridge/libbridge_devif.c b/libbridge/libbridge_devif.c
+index 8b7d954..95f7769 100644
+--- a/libbridge/libbridge_devif.c
++++ b/libbridge/libbridge_devif.c
+@@ -24,6 +24,7 @@
+ #include <string.h>
+ #include <dirent.h>
+ #include <fcntl.h>
++#include <linux/limits.h>
+
+ #include "libbridge.h"
+ #include "libbridge_private.h"
+diff --git a/libbridge/libbridge_init.c b/libbridge/libbridge_init.c
+index c914971..645dda6 100644
+--- a/libbridge/libbridge_init.c
++++ b/libbridge/libbridge_init.c
+@@ -24,6 +24,7 @@
+ #include <dirent.h>
+ #include <sys/types.h>
+ #include <sys/stat.h>
++#include <linux/limits.h>
+
+ #include "libbridge.h"
+ #include "libbridge_private.h"
+--
+2.17.1
+
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/bridge-utils: fix missing PATH_MAX include
2021-04-12 14:37 [Buildroot] [PATCH] package/bridge-utils: fix missing PATH_MAX include Matt Weber
@ 2021-04-12 14:52 ` Baruch Siach
2021-04-12 14:56 ` Matthew Weber
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2021-04-12 14:52 UTC (permalink / raw)
To: buildroot
Hi Matt,
On Mon, Apr 12 2021, Matt Weber wrote:
> Fixes:
> http://autobuild.buildroot.net/results/3ec818e676827c03f08c264c6c7a53b025b7ba1d/
>
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Fabrice posted a patch for that already. It's committed as
aa75b053baef70c9 ("package/bridge-utils: fix build on musl").
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/bridge-utils: fix missing PATH_MAX include
2021-04-12 14:52 ` Baruch Siach
@ 2021-04-12 14:56 ` Matthew Weber
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Weber @ 2021-04-12 14:56 UTC (permalink / raw)
To: buildroot
Baruch,
On Mon, Apr 12, 2021 at 9:53 AM Baruch Siach <baruch@tkos.co.il> wrote:
>
> Hi Matt,
>
> On Mon, Apr 12 2021, Matt Weber wrote:
>
> > Fixes:
> > http://autobuild.buildroot.net/results/3ec818e676827c03f08c264c6c7a53b025b7ba1d/
> >
> > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
>
> Fabrice posted a patch for that already. It's committed as
> aa75b053baef70c9 ("package/bridge-utils: fix build on musl").
:-) I was too slow. Hopefully, the additional patch on bridge-utils
mailing list encourages it to merge.
Thx Matt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-12 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-12 14:37 [Buildroot] [PATCH] package/bridge-utils: fix missing PATH_MAX include Matt Weber
2021-04-12 14:52 ` Baruch Siach
2021-04-12 14:56 ` Matthew Weber
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.