All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Weber <matthew.weber@rockwellcollins.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] support/scripts/pkg-stats: URL check using threads
Date: Fri, 21 Sep 2018 10:38:38 -0500	[thread overview]
Message-ID: <CANQCQpZPGOr5ayfY42jec9H-491uzLmXN67zBh4-wtt3GAnMmQ@mail.gmail.com> (raw)
In-Reply-To: <1537544157-2992-2-git-send-email-matthew.weber@rockwellcollins.com>

All,

On Fri, Sep 21, 2018 at 10:36 AM Matt Weber
<matthew.weber@rockwellcollins.com> wrote:
>
> Adds a pool of worker threads to accelerate connection testing.
>

Takes an example serial ~15min execution of the script with the URL
testing feature and makes it ~4-5mins when ran in parallel.

> CC: Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
>  support/scripts/pkg-stats | 27 +++++++++++++++++++++------
>  1 file changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats
> index 37f89ef..f5c8353 100755
> --- a/support/scripts/pkg-stats
> +++ b/support/scripts/pkg-stats
> @@ -25,6 +25,7 @@ import re
>  import subprocess
>  import sys
>  import requests  # URL checking
> +from multiprocessing import Pool
>
>  INFRA_RE = re.compile("\$\(eval \$\(([a-z-]*)-package\)\)")
>
> @@ -46,6 +47,7 @@ class Package:
>          self.current_version = None
>          self.url = None
>          self.url_status = None
> +        self.url_worker = None
>
>      def pkgvar(self):
>          return self.name.upper().replace("-", "_")
> @@ -277,14 +279,26 @@ def package_init_make_info():
>
>          Package.all_versions[pkgvar] = value
>
> -def check_url_status(pkg):
> -    if pkg.url_status != "Missing" and pkg.url_status != "No Config.in":
> +
> +def check_url_status_worker(url, url_status):
> +    if url_status != "Missing" and url_status != "No Config.in":
>          try:
> -            url_status_code = requests.head(pkg.url, timeout=5).status_code
> +            url_status_code = requests.head(url, timeout=5).status_code
>              if url_status_code >= 400:
> -                pkg.url_status = "Invalid(%s)" % str(url_status_code)
> +                return "Invalid(%s)" % str(url_status_code)
>          except requests.exceptions.RequestException as e:
> -            return
> +            return "Invalid(Err)"
> +        return "Ok"
> +    return url_status
> +
> +
> +def check_package_urls(packages):
> +    Package.pool = Pool(processes=64)
> +    for pkg in packages:
> +        pkg.url_worker = pkg.pool.apply_async(check_url_status_worker, (pkg.url, pkg.url_status))
> +    for pkg in packages:
> +        pkg.url_status = pkg.url_worker.get(timeout=3600)
> +
>
>  def calculate_stats(packages):
>      stats = defaultdict(int)
> @@ -573,7 +587,8 @@ def __main__():
>          pkg.set_check_package_warnings()
>          pkg.set_current_version()
>          pkg.set_url()
> -        check_url_status(pkg)
> +    print("Checking URL status")
> +    check_package_urls(packages)
>      print("Calculate stats")
>      stats = calculate_stats(packages)
>      print("Write HTML")
> --
> 1.9.1
>


-- 
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / RC Linux Secure Platforms
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and
sent to matthew.weber at corp.rockwellcollins.com.

  reply	other threads:[~2018-09-21 15:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 15:35 [Buildroot] [PATCH v2 1/2] support/scripts/pkg-stats: URL checking support Matt Weber
2018-09-21 15:35 ` [Buildroot] [PATCH v2 2/2] support/scripts/pkg-stats: URL check using threads Matt Weber
2018-09-21 15:38   ` Matthew Weber [this message]
2018-09-29  5:42   ` Ricardo Martincoski
2018-10-01 14:05     ` Matthew Weber
2018-10-01 14:20       ` Matthew Weber
2018-09-21 15:37 ` [Buildroot] [PATCH v2 1/2] support/scripts/pkg-stats: URL checking support Matthew Weber
2018-09-29  5:40 ` Ricardo Martincoski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANQCQpZPGOr5ayfY42jec9H-491uzLmXN67zBh4-wtt3GAnMmQ@mail.gmail.com \
    --to=matthew.weber@rockwellcollins.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.