All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Weber <matthew.weber@rockwellcollins.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] support/scripts/pkg-stats: URL check using threads
Date: Mon, 1 Oct 2018 09:05:53 -0500	[thread overview]
Message-ID: <CANQCQpaGuW6BNFdxR=btL+YnufQke9PzUOojX63PAFZ9OZEqxw@mail.gmail.com> (raw)
In-Reply-To: <5baf10d51c63b_62ce3fdd0e04334832349@ultri5.mail>

Ricardo,

On Sat, Sep 29, 2018 at 12:42 AM Ricardo Martincoski
<ricardo.martincoski@gmail.com> wrote:
>
> Hello,
>
> On Fri, Sep 21, 2018 at 12:35 PM, Matt Weber wrote:
>
> [snip]
> > +def check_url_status_worker(url, url_status):
> > +    if url_status != "Missing" and url_status != "No Config.in":
> >          try:
> > -            url_status_code = requests.head(pkg.url, timeout=5).status_code
> > +            url_status_code = requests.head(url, timeout=5).status_code
>
> In order to avoid false timeouts for slow hosts, or hosts with a high load, or
> limited internet connection, or slow servers ... I think 30 seconds is a better
> timeout here.

Sure.

>
> >              if url_status_code >= 400:
> > -                pkg.url_status = "Invalid(%s)" % str(url_status_code)
> > +                return "Invalid(%s)" % str(url_status_code)
> >          except requests.exceptions.RequestException as e:
>
> There is a warning from flake8 for this line. Please fix it in previous patch.

I'm not seeing any output from flake8.  To be sure the tool is
working, I changed something syntax wise in the script and I get a
flake8 err/warning.  Are there options you're calling it with?

Matt

  reply	other threads:[~2018-10-01 14:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 15:35 [Buildroot] [PATCH v2 1/2] support/scripts/pkg-stats: URL checking support Matt Weber
2018-09-21 15:35 ` [Buildroot] [PATCH v2 2/2] support/scripts/pkg-stats: URL check using threads Matt Weber
2018-09-21 15:38   ` Matthew Weber
2018-09-29  5:42   ` Ricardo Martincoski
2018-10-01 14:05     ` Matthew Weber [this message]
2018-10-01 14:20       ` Matthew Weber
2018-09-21 15:37 ` [Buildroot] [PATCH v2 1/2] support/scripts/pkg-stats: URL checking support Matthew Weber
2018-09-29  5:40 ` Ricardo Martincoski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANQCQpaGuW6BNFdxR=btL+YnufQke9PzUOojX63PAFZ9OZEqxw@mail.gmail.com' \
    --to=matthew.weber@rockwellcollins.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.