All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Weber <matthew.weber@rockwellcollins.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/hostapd: add support for hostapd_cli
Date: Mon, 20 Jul 2020 06:46:20 -0500	[thread overview]
Message-ID: <CANQCQpaFFBLeNcKz95AQjGkadMM9k6_iS0JuZ1eBD7hpb0yD6g@mail.gmail.com> (raw)
In-Reply-To: <20200720102247.9780-1-marco.oliverio@tanaza.com>

Marco,


On Mon, Jul 20, 2020 at 5:24 AM Marco Oliverio
<marco.oliverio@tanaza.com> wrote:
>
> Signed-off-by: Marco Oliverio <marco.oliverio@tanaza.com>
> ---
>  package/hostapd/Config.in  | 6 ++++++
>  package/hostapd/hostapd.mk | 8 ++++++++
>  2 files changed, 14 insertions(+)
>
> diff --git a/package/hostapd/Config.in b/package/hostapd/Config.in
> index 54d2086c09..185fa04626 100644
> --- a/package/hostapd/Config.in
> +++ b/package/hostapd/Config.in
> @@ -111,4 +111,10 @@ comment "netlink-based VLAN support needs a toolchain w/ threads"
>
>  endif # BR2_PACKAGE_HOSTAPD_VLAN
>
> +config BR2_PACKAGE_HOSTAPD_HOSTAPD_CLI
> +       bool "Install hostapd_cli"
> +       default n
> +       help
> +         Install hostapd command-line interface
> +
>  endif
> diff --git a/package/hostapd/hostapd.mk b/package/hostapd/hostapd.mk
> index b94a0e4578..d65e4b03fd 100644
> --- a/package/hostapd/hostapd.mk
> +++ b/package/hostapd/hostapd.mk
> @@ -144,4 +144,12 @@ define HOSTAPD_INSTALL_TARGET_CMDS
>                 $(TARGET_DIR)/etc/hostapd.conf
>  endef
>
> +ifeq ($(BR2_PACKAGE_HOSTAPD_HOSTAPD_CLI),y)
> +define HOSTAPD_INSTALL_TARGET_CMDS +=

Future note, instead of the += you'd need to define a new variable and
then call it in the HOSTAPD_INSTALL_TARGET_CMDS.

> +
> +       $(INSTALL) -m 0755 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd_cli \
> +               $(TARGET_DIR)/usr/sbin/hostapd_cli

It looks like the  HOSTAPD_INSTALL_TARGET_CMDS stage already is
installing the cli tool with the main service and default conf file.
Do you have an example where that wasn't working?

Regards,
Matt

  reply	other threads:[~2020-07-20 11:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 10:22 [Buildroot] [PATCH 1/1] package/hostapd: add support for hostapd_cli Marco Oliverio
2020-07-20 11:46 ` Matthew Weber [this message]
2020-07-20 13:25   ` Marco Oliverio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANQCQpaFFBLeNcKz95AQjGkadMM9k6_iS0JuZ1eBD7hpb0yD6g@mail.gmail.com \
    --to=matthew.weber@rockwellcollins.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.