* [Buildroot] [PATCH 1/1] package/hostapd: add support for hostapd_cli
@ 2020-07-20 10:22 Marco Oliverio
2020-07-20 11:46 ` Matthew Weber
0 siblings, 1 reply; 3+ messages in thread
From: Marco Oliverio @ 2020-07-20 10:22 UTC (permalink / raw)
To: buildroot
Signed-off-by: Marco Oliverio <marco.oliverio@tanaza.com>
---
package/hostapd/Config.in | 6 ++++++
package/hostapd/hostapd.mk | 8 ++++++++
2 files changed, 14 insertions(+)
diff --git a/package/hostapd/Config.in b/package/hostapd/Config.in
index 54d2086c09..185fa04626 100644
--- a/package/hostapd/Config.in
+++ b/package/hostapd/Config.in
@@ -111,4 +111,10 @@ comment "netlink-based VLAN support needs a toolchain w/ threads"
endif # BR2_PACKAGE_HOSTAPD_VLAN
+config BR2_PACKAGE_HOSTAPD_HOSTAPD_CLI
+ bool "Install hostapd_cli"
+ default n
+ help
+ Install hostapd command-line interface
+
endif
diff --git a/package/hostapd/hostapd.mk b/package/hostapd/hostapd.mk
index b94a0e4578..d65e4b03fd 100644
--- a/package/hostapd/hostapd.mk
+++ b/package/hostapd/hostapd.mk
@@ -144,4 +144,12 @@ define HOSTAPD_INSTALL_TARGET_CMDS
$(TARGET_DIR)/etc/hostapd.conf
endef
+ifeq ($(BR2_PACKAGE_HOSTAPD_HOSTAPD_CLI),y)
+define HOSTAPD_INSTALL_TARGET_CMDS +=
+
+ $(INSTALL) -m 0755 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd_cli \
+ $(TARGET_DIR)/usr/sbin/hostapd_cli
+endef
+endif
+
$(eval $(generic-package))
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/hostapd: add support for hostapd_cli
2020-07-20 10:22 [Buildroot] [PATCH 1/1] package/hostapd: add support for hostapd_cli Marco Oliverio
@ 2020-07-20 11:46 ` Matthew Weber
2020-07-20 13:25 ` Marco Oliverio
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Weber @ 2020-07-20 11:46 UTC (permalink / raw)
To: buildroot
Marco,
On Mon, Jul 20, 2020 at 5:24 AM Marco Oliverio
<marco.oliverio@tanaza.com> wrote:
>
> Signed-off-by: Marco Oliverio <marco.oliverio@tanaza.com>
> ---
> package/hostapd/Config.in | 6 ++++++
> package/hostapd/hostapd.mk | 8 ++++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/package/hostapd/Config.in b/package/hostapd/Config.in
> index 54d2086c09..185fa04626 100644
> --- a/package/hostapd/Config.in
> +++ b/package/hostapd/Config.in
> @@ -111,4 +111,10 @@ comment "netlink-based VLAN support needs a toolchain w/ threads"
>
> endif # BR2_PACKAGE_HOSTAPD_VLAN
>
> +config BR2_PACKAGE_HOSTAPD_HOSTAPD_CLI
> + bool "Install hostapd_cli"
> + default n
> + help
> + Install hostapd command-line interface
> +
> endif
> diff --git a/package/hostapd/hostapd.mk b/package/hostapd/hostapd.mk
> index b94a0e4578..d65e4b03fd 100644
> --- a/package/hostapd/hostapd.mk
> +++ b/package/hostapd/hostapd.mk
> @@ -144,4 +144,12 @@ define HOSTAPD_INSTALL_TARGET_CMDS
> $(TARGET_DIR)/etc/hostapd.conf
> endef
>
> +ifeq ($(BR2_PACKAGE_HOSTAPD_HOSTAPD_CLI),y)
> +define HOSTAPD_INSTALL_TARGET_CMDS +=
Future note, instead of the += you'd need to define a new variable and
then call it in the HOSTAPD_INSTALL_TARGET_CMDS.
> +
> + $(INSTALL) -m 0755 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd_cli \
> + $(TARGET_DIR)/usr/sbin/hostapd_cli
It looks like the HOSTAPD_INSTALL_TARGET_CMDS stage already is
installing the cli tool with the main service and default conf file.
Do you have an example where that wasn't working?
Regards,
Matt
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/hostapd: add support for hostapd_cli
2020-07-20 11:46 ` Matthew Weber
@ 2020-07-20 13:25 ` Marco Oliverio
0 siblings, 0 replies; 3+ messages in thread
From: Marco Oliverio @ 2020-07-20 13:25 UTC (permalink / raw)
To: buildroot
Yes you're right.
That's my fault.
I was working on a custom version and I didn't check upstream/master
properly.
Never mind the patch.
Marco
On Mon, Jul 20, 2020 at 1:47 PM Matthew Weber <matthew.weber@collins.com>
wrote:
> Marco,
>
>
> On Mon, Jul 20, 2020 at 5:24 AM Marco Oliverio
> <marco.oliverio@tanaza.com> wrote:
> >
> > Signed-off-by: Marco Oliverio <marco.oliverio@tanaza.com>
> > ---
> > package/hostapd/Config.in | 6 ++++++
> > package/hostapd/hostapd.mk | 8 ++++++++
> > 2 files changed, 14 insertions(+)
> >
> > diff --git a/package/hostapd/Config.in b/package/hostapd/Config.in
> > index 54d2086c09..185fa04626 100644
> > --- a/package/hostapd/Config.in
> > +++ b/package/hostapd/Config.in
> > @@ -111,4 +111,10 @@ comment "netlink-based VLAN support needs a
> toolchain w/ threads"
> >
> > endif # BR2_PACKAGE_HOSTAPD_VLAN
> >
> > +config BR2_PACKAGE_HOSTAPD_HOSTAPD_CLI
> > + bool "Install hostapd_cli"
> > + default n
> > + help
> > + Install hostapd command-line interface
> > +
> > endif
> > diff --git a/package/hostapd/hostapd.mk b/package/hostapd/hostapd.mk
> > index b94a0e4578..d65e4b03fd 100644
> > --- a/package/hostapd/hostapd.mk
> > +++ b/package/hostapd/hostapd.mk
> > @@ -144,4 +144,12 @@ define HOSTAPD_INSTALL_TARGET_CMDS
> > $(TARGET_DIR)/etc/hostapd.conf
> > endef
> >
> > +ifeq ($(BR2_PACKAGE_HOSTAPD_HOSTAPD_CLI),y)
> > +define HOSTAPD_INSTALL_TARGET_CMDS +=
>
> Future note, instead of the += you'd need to define a new variable and
> then call it in the HOSTAPD_INSTALL_TARGET_CMDS.
>
> > +
> > + $(INSTALL) -m 0755 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd_cli \
> > + $(TARGET_DIR)/usr/sbin/hostapd_cli
>
> It looks like the HOSTAPD_INSTALL_TARGET_CMDS stage already is
> installing the cli tool with the main service and default conf file.
> Do you have an example where that wasn't working?
>
> Regards,
> Matt
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200720/cfa097bd/attachment.html>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-20 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 10:22 [Buildroot] [PATCH 1/1] package/hostapd: add support for hostapd_cli Marco Oliverio
2020-07-20 11:46 ` Matthew Weber
2020-07-20 13:25 ` Marco Oliverio
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.