All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] vboot-utils: disable static futility
@ 2017-10-03  8:37 Alex Suykov
  2017-10-03 12:45 ` Matthew Weber
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Alex Suykov @ 2017-10-03  8:37 UTC (permalink / raw)
  To: buildroot

Possibly fixes
http://autobuild.buildroot.net/results/fbe/fbe7892539cc1bf18f89d18c6609a5aa747647d0/
http://autobuild.buildroot.net/results/4bc/4bc388618ff02dde26ae09db021434a936c8cc1b/
and similar errors.

Signed-off-by: Alex Suykov <alex.suykov@gmail.com>
---
Please note this is a blind fix. I cannot reproduce the build errors,
which all happen on the same build node, and I cannot verify that
the patch does in fact fix them. 

It's probably still a good idea to avoid unnecessary static linking
in a host package.

 .../vboot-utils/0004-Disable-static-futility.patch | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 package/vboot-utils/0004-Disable-static-futility.patch

diff --git a/package/vboot-utils/0004-Disable-static-futility.patch b/package/vboot-utils/0004-Disable-static-futility.patch
new file mode 100644
index 0000000000..574476d340
--- /dev/null
+++ b/package/vboot-utils/0004-Disable-static-futility.patch
@@ -0,0 +1,30 @@
+The package attempts to build a statically-linked host binary, futility_s,
+which is not used anywhere in buildroot but may be causing build failures
+if the build host lacks static libc.
+
+Signed-off-by: Alex Suykov <alex.suykov@gmail.com>
+
+--- a/Makefile
++++ b/Makefile
+@@ -1079,7 +1079,7 @@
+ # new Firmware Utility
+ 
+ .PHONY: futil
+-futil: ${FUTIL_STATIC_BIN} ${FUTIL_BIN}
++futil: ${FUTIL_BIN}
+ 
+ ${FUTIL_STATIC_BIN}: ${FUTIL_STATIC_OBJS} ${UTILLIB}
+ 	@${PRINTF} "    LD            $(subst ${BUILD}/,,$@)\n"
+@@ -1091,10 +1091,10 @@
+ 	${Q}${LD} -o $@ ${CFLAGS} ${LDFLAGS} $^ ${LDLIBS}
+ 
+ .PHONY: futil_install
+-futil_install: ${FUTIL_BIN} ${FUTIL_STATIC_BIN}
++futil_install: ${FUTIL_BIN}
+ 	@${PRINTF} "    INSTALL       futility\n"
+ 	${Q}mkdir -p ${UB_DIR}
+-	${Q}${INSTALL} -t ${UB_DIR} ${FUTIL_BIN} ${FUTIL_STATIC_BIN}
++	${Q}${INSTALL} -t ${UB_DIR} ${FUTIL_BIN}
+ 	${Q}for prog in ${FUTIL_SYMLINKS}; do \
+ 		ln -sf futility "${UB_DIR}/$$prog"; done
+ 
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] vboot-utils: disable static futility
  2017-10-03  8:37 [Buildroot] [PATCH] vboot-utils: disable static futility Alex Suykov
@ 2017-10-03 12:45 ` Matthew Weber
  2017-10-03 12:55   ` Matthew Weber
  2017-10-03 13:13   ` Alex Suykov
  2017-10-05 18:59 ` Arnout Vandecappelle
  2017-10-17  9:04 ` Peter Korsgaard
  2 siblings, 2 replies; 6+ messages in thread
From: Matthew Weber @ 2017-10-03 12:45 UTC (permalink / raw)
  To: buildroot

Alex,

On Tue, Oct 3, 2017 at 3:37 AM, Alex Suykov <alex.suykov@gmail.com> wrote:
>
> Possibly fixes
> http://autobuild.buildroot.net/results/fbe/fbe7892539cc1bf18f89d18c6609a5aa747647d0/
> http://autobuild.buildroot.net/results/4bc/4bc388618ff02dde26ae09db021434a936c8cc1b/
> and similar errors.

I'll take a look and see if it works.  The patch looks like it
completely disables building of static bins for target and host.  Is
that intended?

>
> Signed-off-by: Alex Suykov <alex.suykov@gmail.com>
> ---
> Please note this is a blind fix. I cannot reproduce the build errors,
> which all happen on the same build node, and I cannot verify that
> the patch does in fact fix them.
>
> It's probably still a good idea to avoid unnecessary static linking
> in a host package.
>
>  .../vboot-utils/0004-Disable-static-futility.patch | 30 ++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 package/vboot-utils/0004-Disable-static-futility.patch
>
> diff --git a/package/vboot-utils/0004-Disable-static-futility.patch b/package/vboot-utils/0004-Disable-static-futility.patch
> new file mode 100644
> index 0000000000..574476d340
> --- /dev/null
> +++ b/package/vboot-utils/0004-Disable-static-futility.patch
> @@ -0,0 +1,30 @@
> +The package attempts to build a statically-linked host binary, futility_s,
> +which is not used anywhere in buildroot but may be causing build failures
> +if the build host lacks static libc.
> +
> +Signed-off-by: Alex Suykov <alex.suykov@gmail.com>
> +
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -1079,7 +1079,7 @@
> + # new Firmware Utility
> +
> + .PHONY: futil
> +-futil: ${FUTIL_STATIC_BIN} ${FUTIL_BIN}
> ++futil: ${FUTIL_BIN}
> +
> + ${FUTIL_STATIC_BIN}: ${FUTIL_STATIC_OBJS} ${UTILLIB}
> +       @${PRINTF} "    LD            $(subst ${BUILD}/,,$@)\n"
> +@@ -1091,10 +1091,10 @@
> +       ${Q}${LD} -o $@ ${CFLAGS} ${LDFLAGS} $^ ${LDLIBS}
> +
> + .PHONY: futil_install
> +-futil_install: ${FUTIL_BIN} ${FUTIL_STATIC_BIN}
> ++futil_install: ${FUTIL_BIN}
> +       @${PRINTF} "    INSTALL       futility\n"
> +       ${Q}mkdir -p ${UB_DIR}
> +-      ${Q}${INSTALL} -t ${UB_DIR} ${FUTIL_BIN} ${FUTIL_STATIC_BIN}
> ++      ${Q}${INSTALL} -t ${UB_DIR} ${FUTIL_BIN}
> +       ${Q}for prog in ${FUTIL_SYMLINKS}; do \
> +               ln -sf futility "${UB_DIR}/$$prog"; done
> +
> --
> 2.14.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot




-- 
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software / Secure Platforms
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and
sent to matthew.weber at corp.rockwellcollins.com.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] vboot-utils: disable static futility
  2017-10-03 12:45 ` Matthew Weber
@ 2017-10-03 12:55   ` Matthew Weber
  2017-10-03 13:13   ` Alex Suykov
  1 sibling, 0 replies; 6+ messages in thread
From: Matthew Weber @ 2017-10-03 12:55 UTC (permalink / raw)
  To: buildroot

Alex,

On Tue, Oct 3, 2017 at 7:45 AM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> Alex,
>
> On Tue, Oct 3, 2017 at 3:37 AM, Alex Suykov <alex.suykov@gmail.com> wrote:
>>
>> Possibly fixes
>> http://autobuild.buildroot.net/results/fbe/fbe7892539cc1bf18f89d18c6609a5aa747647d0/
>> http://autobuild.buildroot.net/results/4bc/4bc388618ff02dde26ae09db021434a936c8cc1b/
>> and similar errors.
>
> I'll take a look and see if it works.  The patch looks like it
> completely disables building of static bins for target and host.  Is
> that intended?

Confirmed, resolves the build failures above, but I'm still curious
about my previous question.

Tested-by: Matt Weber <matthew.weber@rockwellcollins.com>

>
>>
>> Signed-off-by: Alex Suykov <alex.suykov@gmail.com>
>> ---
>> Please note this is a blind fix. I cannot reproduce the build errors,
>> which all happen on the same build node, and I cannot verify that
>> the patch does in fact fix them.
>>
>> It's probably still a good idea to avoid unnecessary static linking
>> in a host package.
>>
>>  .../vboot-utils/0004-Disable-static-futility.patch | 30 ++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>  create mode 100644 package/vboot-utils/0004-Disable-static-futility.patch
>>
>> diff --git a/package/vboot-utils/0004-Disable-static-futility.patch b/package/vboot-utils/0004-Disable-static-futility.patch
>> new file mode 100644
>> index 0000000000..574476d340
>> --- /dev/null
>> +++ b/package/vboot-utils/0004-Disable-static-futility.patch
>> @@ -0,0 +1,30 @@
>> +The package attempts to build a statically-linked host binary, futility_s,
>> +which is not used anywhere in buildroot but may be causing build failures
>> +if the build host lacks static libc.
>> +
>> +Signed-off-by: Alex Suykov <alex.suykov@gmail.com>
>> +
>> +--- a/Makefile
>> ++++ b/Makefile
>> +@@ -1079,7 +1079,7 @@
>> + # new Firmware Utility
>> +
>> + .PHONY: futil
>> +-futil: ${FUTIL_STATIC_BIN} ${FUTIL_BIN}
>> ++futil: ${FUTIL_BIN}
>> +
>> + ${FUTIL_STATIC_BIN}: ${FUTIL_STATIC_OBJS} ${UTILLIB}
>> +       @${PRINTF} "    LD            $(subst ${BUILD}/,,$@)\n"
>> +@@ -1091,10 +1091,10 @@
>> +       ${Q}${LD} -o $@ ${CFLAGS} ${LDFLAGS} $^ ${LDLIBS}
>> +
>> + .PHONY: futil_install
>> +-futil_install: ${FUTIL_BIN} ${FUTIL_STATIC_BIN}
>> ++futil_install: ${FUTIL_BIN}
>> +       @${PRINTF} "    INSTALL       futility\n"
>> +       ${Q}mkdir -p ${UB_DIR}
>> +-      ${Q}${INSTALL} -t ${UB_DIR} ${FUTIL_BIN} ${FUTIL_STATIC_BIN}
>> ++      ${Q}${INSTALL} -t ${UB_DIR} ${FUTIL_BIN}
>> +       ${Q}for prog in ${FUTIL_SYMLINKS}; do \
>> +               ln -sf futility "${UB_DIR}/$$prog"; done
>> +
>> --
>> 2.14.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
>
>
>
> --
> Matthew L Weber / Pr Software Engineer
> Airborne Information Systems / Security Systems and Software / Secure Platforms
> MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
> www.rockwellcollins.com
>
> Note: Any Export License Required Information and License Restricted
> Third Party Intellectual Property (TPIP) content must be encrypted and
> sent to matthew.weber at corp.rockwellcollins.com.



-- 
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software / Secure Platforms
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and
sent to matthew.weber at corp.rockwellcollins.com.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] vboot-utils: disable static futility
  2017-10-03 12:45 ` Matthew Weber
  2017-10-03 12:55   ` Matthew Weber
@ 2017-10-03 13:13   ` Alex Suykov
  1 sibling, 0 replies; 6+ messages in thread
From: Alex Suykov @ 2017-10-03 13:13 UTC (permalink / raw)
  To: buildroot

Tue, Oct 03, 2017 at 07:45:48AM -0500, Matthew Weber wrote:

> I'll take a look and see if it works.  The patch looks like it
> completely disables building of static bins for target and host.  Is
> that intended?

There's a single static binary, and it's a host-only package.
So yeah the patch just cuts it out and it's intentional.

I'm not even sure why they needed a static version of this particular
tool, but it doesn't look like there's any better way to disable it.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] vboot-utils: disable static futility
  2017-10-03  8:37 [Buildroot] [PATCH] vboot-utils: disable static futility Alex Suykov
  2017-10-03 12:45 ` Matthew Weber
@ 2017-10-05 18:59 ` Arnout Vandecappelle
  2017-10-17  9:04 ` Peter Korsgaard
  2 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2017-10-05 18:59 UTC (permalink / raw)
  To: buildroot



On 03-10-17 10:37, Alex Suykov wrote:
> Possibly fixes
> http://autobuild.buildroot.net/results/fbe/fbe7892539cc1bf18f89d18c6609a5aa747647d0/
> http://autobuild.buildroot.net/results/4bc/4bc388618ff02dde26ae09db021434a936c8cc1b/
> and similar errors.
> 
> Signed-off-by: Alex Suykov <alex.suykov@gmail.com>

 Applied to master, thanks.

 I don't particularly like this solution (a non-upstreamable patch), but the
comments in the Makefile seem to suggest that this stuff is going to change in
the future, so eventually the patch will fail to apply and will be removed :-)

 It would be nice though if you could work with upstream to find a fundamental
solution.

 I'm actually quite surprised that this happens, because I thought 'gcc -static'
didn't preclude dynamic linking if only a dynamic lib was available.

 Regards,
 Arnout

> ---
> Please note this is a blind fix. I cannot reproduce the build errors,
> which all happen on the same build node, and I cannot verify that
> the patch does in fact fix them. 
> 
> It's probably still a good idea to avoid unnecessary static linking
> in a host package.
> 
>  .../vboot-utils/0004-Disable-static-futility.patch | 30 ++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 package/vboot-utils/0004-Disable-static-futility.patch
> 
> diff --git a/package/vboot-utils/0004-Disable-static-futility.patch b/package/vboot-utils/0004-Disable-static-futility.patch
> new file mode 100644
> index 0000000000..574476d340
> --- /dev/null
> +++ b/package/vboot-utils/0004-Disable-static-futility.patch
> @@ -0,0 +1,30 @@
> +The package attempts to build a statically-linked host binary, futility_s,
> +which is not used anywhere in buildroot but may be causing build failures
> +if the build host lacks static libc.
> +
> +Signed-off-by: Alex Suykov <alex.suykov@gmail.com>
> +
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -1079,7 +1079,7 @@
> + # new Firmware Utility
> + 
> + .PHONY: futil
> +-futil: ${FUTIL_STATIC_BIN} ${FUTIL_BIN}
> ++futil: ${FUTIL_BIN}
> + 
> + ${FUTIL_STATIC_BIN}: ${FUTIL_STATIC_OBJS} ${UTILLIB}
> + 	@${PRINTF} "    LD            $(subst ${BUILD}/,,$@)\n"
> +@@ -1091,10 +1091,10 @@
> + 	${Q}${LD} -o $@ ${CFLAGS} ${LDFLAGS} $^ ${LDLIBS}
> + 
> + .PHONY: futil_install
> +-futil_install: ${FUTIL_BIN} ${FUTIL_STATIC_BIN}
> ++futil_install: ${FUTIL_BIN}
> + 	@${PRINTF} "    INSTALL       futility\n"
> + 	${Q}mkdir -p ${UB_DIR}
> +-	${Q}${INSTALL} -t ${UB_DIR} ${FUTIL_BIN} ${FUTIL_STATIC_BIN}
> ++	${Q}${INSTALL} -t ${UB_DIR} ${FUTIL_BIN}
> + 	${Q}for prog in ${FUTIL_SYMLINKS}; do \
> + 		ln -sf futility "${UB_DIR}/$$prog"; done
> + 
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] vboot-utils: disable static futility
  2017-10-03  8:37 [Buildroot] [PATCH] vboot-utils: disable static futility Alex Suykov
  2017-10-03 12:45 ` Matthew Weber
  2017-10-05 18:59 ` Arnout Vandecappelle
@ 2017-10-17  9:04 ` Peter Korsgaard
  2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2017-10-17  9:04 UTC (permalink / raw)
  To: buildroot

>>>>> "Alex" == Alex Suykov <alex.suykov@gmail.com> writes:

 > Possibly fixes
 > http://autobuild.buildroot.net/results/fbe/fbe7892539cc1bf18f89d18c6609a5aa747647d0/
 > http://autobuild.buildroot.net/results/4bc/4bc388618ff02dde26ae09db021434a936c8cc1b/
 > and similar errors.

 > Signed-off-by: Alex Suykov <alex.suykov@gmail.com>
 > ---
 > Please note this is a blind fix. I cannot reproduce the build errors,
 > which all happen on the same build node, and I cannot verify that
 > the patch does in fact fix them. 

 > It's probably still a good idea to avoid unnecessary static linking
 > in a host package.

 >  .../vboot-utils/0004-Disable-static-futility.patch | 30 ++++++++++++++++++++++
 >  1 file changed, 30 insertions(+)
 >  create mode 100644 package/vboot-utils/0004-Disable-static-futility.patch

Committed to 2017.08.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-17  9:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-03  8:37 [Buildroot] [PATCH] vboot-utils: disable static futility Alex Suykov
2017-10-03 12:45 ` Matthew Weber
2017-10-03 12:55   ` Matthew Weber
2017-10-03 13:13   ` Alex Suykov
2017-10-05 18:59 ` Arnout Vandecappelle
2017-10-17  9:04 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.