Multichannel fixes

Multichannel fixes

[Shyam Prasad N]

Hi Steve/Ronnie,

During the final stages of 5.17 kernel, we identified that my recent
changes related to multichannel broke multiuser scenario. At that
point, we took the less risky, single line change that Steve
suggested.

These are more complete patches for fixing the scenario, while also
allowing parallel reconnects for the multichannel scenario. Please
review these patches.

[PATCH] cifs: do not use tcpStatus after negotiate completes
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/35a6b903a8aaa2ae78a764329fd34ecba00647eb.patch

[PATCH] cifs: use new enum for ses_status
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/a1f9fbe6915573807250cd2deac417ee98736b0a.patch

[PATCH] cifs: avoid parallel session setups on same channel
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/c1e3cb0a09a6253a96068d0b7156511883de533a.patch

[PATCH] cifs: use session_estab from primary channel
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/f5130d025ba42bce5fd39268704a9c7b091ce8e1.patch

This time, I've verified that it does not break the multiuser scenario. :)

-- 
Regards,
Shyam

Re: Multichannel fixes

[Paulo Alcantara]

Shyam Prasad N <nspmangalore@gmail.com> writes:

> This time, I've verified that it does not break the multiuser
> scenario. :)

Thanks!  What about DFS failover scenario?  :-)

Re: Multichannel fixes

[Shyam Prasad N]

Hi Paulo,

Sorry for the late reply.
Good point. Tested basic DFS mounts. I was facing setup issues while
setting up DFS for failover.
Steve will be running the buildbot DFS tests anyway, which will
contain DFS failover.

On Thu, May 19, 2022 at 12:45 AM Paulo Alcantara <pc@cjr.nz> wrote:
>
> Shyam Prasad N <nspmangalore@gmail.com> writes:
>
> > This time, I've verified that it does not break the multiuser
> > scenario. :)
>
> Thanks!  What about DFS failover scenario?  :-)



-- 
Regards,
Shyam

Re: Multichannel fixes

[Shyam Prasad N]

On Mon, Jun 6, 2022 at 11:12 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> Hi Paulo,
>
> Sorry for the late reply.
> Good point. Tested basic DFS mounts. I was facing setup issues while
> setting up DFS for failover.
> Steve will be running the buildbot DFS tests anyway, which will
> contain DFS failover.
>
> On Thu, May 19, 2022 at 12:45 AM Paulo Alcantara <pc@cjr.nz> wrote:
> >
> > Shyam Prasad N <nspmangalore@gmail.com> writes:
> >
> > > This time, I've verified that it does not break the multiuser
> > > scenario. :)
> >
> > Thanks!  What about DFS failover scenario?  :-)
>
>
>
> --
> Regards,
> Shyam

More fixes for multichannel:

[PATCH] cifs: populate empty hostnames for extra channels
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/fb231a3e148e7537c899f4e145fc0dd876c2b195.patch

[PATCH] cifs: change iface_list from array to sorted linked list
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/94363021b50edb86813ae280526d7f33d6903703.patch

[PATCH] cifs: during reconnect, update interface if necessary
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7610df44d276634a51155e6314ee159b7618013f.patch

[PATCH] cifs: periodically query network interfaces from server
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7dad71410514232501f921a8c3ad389d3344fddb.patch

First one is a fix for ensuring that reconnect does not resolve extra
channels to possibly wrong IP address.
Rest three enable periodic query of server interfaces. This is
important for Azure service, where the server can change the IP
addresses of secondary channels.

Reviews will be appreciated.

-- 
Regards,
Shyam

Re: Multichannel fixes

[Shyam Prasad N]

On Mon, Jun 6, 2022 at 3:57 PM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> On Mon, Jun 6, 2022 at 11:12 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> >
> > Hi Paulo,
> >
> > Sorry for the late reply.
> > Good point. Tested basic DFS mounts. I was facing setup issues while
> > setting up DFS for failover.
> > Steve will be running the buildbot DFS tests anyway, which will
> > contain DFS failover.
> >
> > On Thu, May 19, 2022 at 12:45 AM Paulo Alcantara <pc@cjr.nz> wrote:
> > >
> > > Shyam Prasad N <nspmangalore@gmail.com> writes:
> > >
> > > > This time, I've verified that it does not break the multiuser
> > > > scenario. :)
> > >
> > > Thanks!  What about DFS failover scenario?  :-)
> >
> >
> >
> > --
> > Regards,
> > Shyam
>
> More fixes for multichannel:
>
> [PATCH] cifs: populate empty hostnames for extra channels
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/fb231a3e148e7537c899f4e145fc0dd876c2b195.patch
>
> [PATCH] cifs: change iface_list from array to sorted linked list
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/94363021b50edb86813ae280526d7f33d6903703.patch
>
> [PATCH] cifs: during reconnect, update interface if necessary
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7610df44d276634a51155e6314ee159b7618013f.patch
>
> [PATCH] cifs: periodically query network interfaces from server
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7dad71410514232501f921a8c3ad389d3344fddb.patch
>
> First one is a fix for ensuring that reconnect does not resolve extra
> channels to possibly wrong IP address.
> Rest three enable periodic query of server interfaces. This is
> important for Azure service, where the server can change the IP
> addresses of secondary channels.
>
> Reviews will be appreciated.
>
> --
> Regards,
> Shyam

Updated the last set of patches to the below set after fixing some
coverity warnings.

https://github.com/sprasad-microsoft/smb3-kernel-client/commit/37d488b3d38c04f9f4caf1fab2b58301f0c20227.patch
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/a21e72b2a9599482739884329523ed91cfabf8db.patch
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/ad8f403ac707cf326371d1361ef5880d89b9bbe6.patch
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/85ede3abb8348d3b9b5a2548c9773ed0fec0f157.patch
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/8577d17e605634f297e1be71f602c8027737fefc.patch

-- 
Regards,
Shyam

Re: Multichannel fixes

[Steve French]

FYI - the last one includes the fix for the lock ordering problem that
Coverity spotted.

On Fri, Jun 24, 2022 at 9:43 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> On Mon, Jun 6, 2022 at 3:57 PM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> >
> > On Mon, Jun 6, 2022 at 11:12 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> > >
> > > Hi Paulo,
> > >
> > > Sorry for the late reply.
> > > Good point. Tested basic DFS mounts. I was facing setup issues while
> > > setting up DFS for failover.
> > > Steve will be running the buildbot DFS tests anyway, which will
> > > contain DFS failover.
> > >
> > > On Thu, May 19, 2022 at 12:45 AM Paulo Alcantara <pc@cjr.nz> wrote:
> > > >
> > > > Shyam Prasad N <nspmangalore@gmail.com> writes:
> > > >
> > > > > This time, I've verified that it does not break the multiuser
> > > > > scenario. :)
> > > >
> > > > Thanks!  What about DFS failover scenario?  :-)
> > >
> > >
> > >
> > > --
> > > Regards,
> > > Shyam
> >
> > More fixes for multichannel:
> >
> > [PATCH] cifs: populate empty hostnames for extra channels
> > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/fb231a3e148e7537c899f4e145fc0dd876c2b195.patch
> >
> > [PATCH] cifs: change iface_list from array to sorted linked list
> > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/94363021b50edb86813ae280526d7f33d6903703.patch
> >
> > [PATCH] cifs: during reconnect, update interface if necessary
> > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7610df44d276634a51155e6314ee159b7618013f.patch
> >
> > [PATCH] cifs: periodically query network interfaces from server
> > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7dad71410514232501f921a8c3ad389d3344fddb.patch
> >
> > First one is a fix for ensuring that reconnect does not resolve extra
> > channels to possibly wrong IP address.
> > Rest three enable periodic query of server interfaces. This is
> > important for Azure service, where the server can change the IP
> > addresses of secondary channels.
> >
> > Reviews will be appreciated.
> >
> > --
> > Regards,
> > Shyam
>
> Updated the last set of patches to the below set after fixing some
> coverity warnings.
>
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/37d488b3d38c04f9f4caf1fab2b58301f0c20227.patch
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/a21e72b2a9599482739884329523ed91cfabf8db.patch
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/ad8f403ac707cf326371d1361ef5880d89b9bbe6.patch
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/85ede3abb8348d3b9b5a2548c9773ed0fec0f157.patch
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/8577d17e605634f297e1be71f602c8027737fefc.patch
>
> --
> Regards,
> Shyam



-- 
Thanks,

Steve

Re: Multichannel fixes

[Shyam Prasad N]

On Fri, Jun 24, 2022 at 8:14 PM Steve French <smfrench@gmail.com> wrote:
>
> FYI - the last one includes the fix for the lock ordering problem that
> Coverity spotted.
>
> On Fri, Jun 24, 2022 at 9:43 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> >
> > On Mon, Jun 6, 2022 at 3:57 PM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> > >
> > > On Mon, Jun 6, 2022 at 11:12 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> > > >
> > > > Hi Paulo,
> > > >
> > > > Sorry for the late reply.
> > > > Good point. Tested basic DFS mounts. I was facing setup issues while
> > > > setting up DFS for failover.
> > > > Steve will be running the buildbot DFS tests anyway, which will
> > > > contain DFS failover.
> > > >
> > > > On Thu, May 19, 2022 at 12:45 AM Paulo Alcantara <pc@cjr.nz> wrote:
> > > > >
> > > > > Shyam Prasad N <nspmangalore@gmail.com> writes:
> > > > >
> > > > > > This time, I've verified that it does not break the multiuser
> > > > > > scenario. :)
> > > > >
> > > > > Thanks!  What about DFS failover scenario?  :-)
> > > >
> > > >
> > > >
> > > > --
> > > > Regards,
> > > > Shyam
> > >
> > > More fixes for multichannel:
> > >
> > > [PATCH] cifs: populate empty hostnames for extra channels
> > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/fb231a3e148e7537c899f4e145fc0dd876c2b195.patch
> > >
> > > [PATCH] cifs: change iface_list from array to sorted linked list
> > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/94363021b50edb86813ae280526d7f33d6903703.patch
> > >
> > > [PATCH] cifs: during reconnect, update interface if necessary
> > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7610df44d276634a51155e6314ee159b7618013f.patch
> > >
> > > [PATCH] cifs: periodically query network interfaces from server
> > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7dad71410514232501f921a8c3ad389d3344fddb.patch
> > >
> > > First one is a fix for ensuring that reconnect does not resolve extra
> > > channels to possibly wrong IP address.
> > > Rest three enable periodic query of server interfaces. This is
> > > important for Azure service, where the server can change the IP
> > > addresses of secondary channels.
> > >
> > > Reviews will be appreciated.
> > >
> > > --
> > > Regards,
> > > Shyam
> >
> > Updated the last set of patches to the below set after fixing some
> > coverity warnings.
> >
> > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/37d488b3d38c04f9f4caf1fab2b58301f0c20227.patch
> > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/a21e72b2a9599482739884329523ed91cfabf8db.patch
> > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/ad8f403ac707cf326371d1361ef5880d89b9bbe6.patch
> > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/85ede3abb8348d3b9b5a2548c9773ed0fec0f157.patch
> > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/8577d17e605634f297e1be71f602c8027737fefc.patch
> >
> > --
> > Regards,
> > Shyam
>
>
>
> --
> Thanks,
>
> Steve

Hi all,

Found a race condition between the delayed workers when there's a
failure to add a channel to a session.
This was causing occasional failures on the buildbot due to a warning
being logged.

Fixed it with the below patch:
https://github.com/sprasad-microsoft/smb3-kernel-client/commit/ff9ba549b08b8a54bd951e74dae7a1e74f8e7db6.patch

Please review the fix.

-- 
Regards,
Shyam

Re: Multichannel fixes

[Steve French]

tentatively merged into cifs-2.6.git for-next pending testing

On Tue, Jul 5, 2022 at 6:28 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> On Fri, Jun 24, 2022 at 8:14 PM Steve French <smfrench@gmail.com> wrote:
> >
> > FYI - the last one includes the fix for the lock ordering problem that
> > Coverity spotted.
> >
> > On Fri, Jun 24, 2022 at 9:43 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> > >
> > > On Mon, Jun 6, 2022 at 3:57 PM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> > > >
> > > > On Mon, Jun 6, 2022 at 11:12 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> > > > >
> > > > > Hi Paulo,
> > > > >
> > > > > Sorry for the late reply.
> > > > > Good point. Tested basic DFS mounts. I was facing setup issues while
> > > > > setting up DFS for failover.
> > > > > Steve will be running the buildbot DFS tests anyway, which will
> > > > > contain DFS failover.
> > > > >
> > > > > On Thu, May 19, 2022 at 12:45 AM Paulo Alcantara <pc@cjr.nz> wrote:
> > > > > >
> > > > > > Shyam Prasad N <nspmangalore@gmail.com> writes:
> > > > > >
> > > > > > > This time, I've verified that it does not break the multiuser
> > > > > > > scenario. :)
> > > > > >
> > > > > > Thanks!  What about DFS failover scenario?  :-)
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Regards,
> > > > > Shyam
> > > >
> > > > More fixes for multichannel:
> > > >
> > > > [PATCH] cifs: populate empty hostnames for extra channels
> > > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/fb231a3e148e7537c899f4e145fc0dd876c2b195.patch
> > > >
> > > > [PATCH] cifs: change iface_list from array to sorted linked list
> > > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/94363021b50edb86813ae280526d7f33d6903703.patch
> > > >
> > > > [PATCH] cifs: during reconnect, update interface if necessary
> > > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7610df44d276634a51155e6314ee159b7618013f.patch
> > > >
> > > > [PATCH] cifs: periodically query network interfaces from server
> > > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/7dad71410514232501f921a8c3ad389d3344fddb.patch
> > > >
> > > > First one is a fix for ensuring that reconnect does not resolve extra
> > > > channels to possibly wrong IP address.
> > > > Rest three enable periodic query of server interfaces. This is
> > > > important for Azure service, where the server can change the IP
> > > > addresses of secondary channels.
> > > >
> > > > Reviews will be appreciated.
> > > >
> > > > --
> > > > Regards,
> > > > Shyam
> > >
> > > Updated the last set of patches to the below set after fixing some
> > > coverity warnings.
> > >
> > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/37d488b3d38c04f9f4caf1fab2b58301f0c20227.patch
> > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/a21e72b2a9599482739884329523ed91cfabf8db.patch
> > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/ad8f403ac707cf326371d1361ef5880d89b9bbe6.patch
> > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/85ede3abb8348d3b9b5a2548c9773ed0fec0f157.patch
> > > https://github.com/sprasad-microsoft/smb3-kernel-client/commit/8577d17e605634f297e1be71f602c8027737fefc.patch
> > >
> > > --
> > > Regards,
> > > Shyam
> >
> >
> >
> > --
> > Thanks,
> >
> > Steve
>
> Hi all,
>
> Found a race condition between the delayed workers when there's a
> failure to add a channel to a session.
> This was causing occasional failures on the buildbot due to a warning
> being logged.
>
> Fixed it with the below patch:
> https://github.com/sprasad-microsoft/smb3-kernel-client/commit/ff9ba549b08b8a54bd951e74dae7a1e74f8e7db6.patch
>
> Please review the fix.
>
> --
> Regards,
> Shyam



-- 
Thanks,

Steve