[Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove unnecessary parentheses

[Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove unnecessary parentheses

[Payal Kshirsagar]

Challenge suggested by coccinelle

This patch removes unnecessary parentheses while returning a value and 
removes unnecessary space.
Using following semantic patch:

@@ 
local idexpression id;
@@

- return(id);
+ return id;

@@ 
local idexpression id;
@@

-return (id) ;
+return id;

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.c
---
Changes in v2:
	-Add new semantic patch to drop spaces.

--- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ /tmp/cocci-output-4620-ca634c-ioctl_linux.c
@@ -961,7 +961,7 @@ static int rtw_wx_set_pmkid(struct net_d
         if (pPMK->cmd == IW_PMKSA_ADD) {
                 DBG_871X("[rtw_wx_set_pmkid] IW_PMKSA_ADD!\n");
                 if (!memcmp(strIssueBssid, strZeroMacAddress, ETH_ALEN))
-                    return(intReturn);
+                    return intReturn;
                 else
                     intReturn = true;
 
@@ -1489,7 +1489,7 @@ exit:
 	DBG_871X("DBG_IOCTL %s:%d return %d\n", __func__, __LINE__, ret);
 	#endif
 
-	return ret ;
+	return ret;
 
 }
 

Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove unnecessary parentheses

[Greg KH]

On Thu, Mar 28, 2019 at 09:54:24PM +0530, Payal Kshirsagar wrote:
> Challenge suggested by coccinelle
> 
> This patch removes unnecessary parentheses while returning a value and 
> removes unnecessary space.
> Using following semantic patch:
> 
> @@ 
> local idexpression id;
> @@
> 
> - return(id);
> + return id;
> 
> @@ 
> local idexpression id;
> @@
> 
> -return (id) ;
> +return id;
> 
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.c
> ---
> Changes in v2:
> 	-Add new semantic patch to drop spaces.
> 
> --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ /tmp/cocci-output-4620-ca634c-ioctl_linux.c

That is a _VERY_ odd diff, and obviously does not apply to the kernel
tree.  Did something go wrong when creating it?

Please fix up and resend.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove unnecessary parentheses

[Payal Kshirsagar]

[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]

On Fri, Mar 29, 2019, 9:42 PM Greg KH <greg@kroah.com> wrote:

> On Thu, Mar 28, 2019 at 09:54:24PM +0530, Payal Kshirsagar wrote:
> > Challenge suggested by coccinelle
> >
> > This patch removes unnecessary parentheses while returning a value and
> > removes unnecessary space.
> > Using following semantic patch:
> >
> > @@
> > local idexpression id;
> > @@
> >
> > - return(id);
> > + return id;
> >
> > @@
> > local idexpression id;
> > @@
> >
> > -return (id) ;
> > +return id;
> >
> > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.c
> > ---
> > Changes in v2:
> >       -Add new semantic patch to drop spaces.
> >
> > --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > +++ /tmp/cocci-output-4620-ca634c-ioctl_linux.c
>
> That is a _VERY_ odd diff, and obviously does not apply to the kernel
> tree.  Did something go wrong when creating it?
>
> Please fix up and resend.
>

Okay,I will fix it and resend.
Thanks ,
Payal

thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20190329161253.GA32685%40kroah.com
> .
> For more options, visit https://groups.google.com/d/optout.
>

[-- Attachment #2: Type: text/html, Size: 2926 bytes --]

Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove unnecessary parentheses

[Julia Lawall]

On Fri, 29 Mar 2019, Greg KH wrote:

> On Thu, Mar 28, 2019 at 09:54:24PM +0530, Payal Kshirsagar wrote:
> > Challenge suggested by coccinelle
> >
> > This patch removes unnecessary parentheses while returning a value and
> > removes unnecessary space.
> > Using following semantic patch:
> >
> > @@
> > local idexpression id;
> > @@
> >
> > - return(id);
> > + return id;
> >
> > @@
> > local idexpression id;
> > @@
> >
> > -return (id) ;
> > +return id;
> >
> > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.c
> > ---
> > Changes in v2:
> > 	-Add new semantic patch to drop spaces.
> >
> > --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > +++ /tmp/cocci-output-4620-ca634c-ioctl_linux.c
>
> That is a _VERY_ odd diff, and obviously does not apply to the kernel
> tree.  Did something go wrong when creating it?

It looks like the output of Coccinelle.  Payal, you have to apply the diff
that you get from Coccinelle to your kernel tree, check that it compiles,
and then make a patch in the normal way.

julia

>
> Please fix up and resend.
>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190329161253.GA32685%40kroah.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: Remove unnecessary parentheses

[Payal Kshirsagar]

[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]

On Fri, Mar 29, 2019, 11:38 PM Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Fri, 29 Mar 2019, Greg KH wrote:
>
> > On Thu, Mar 28, 2019 at 09:54:24PM +0530, Payal Kshirsagar wrote:
> > > Challenge suggested by coccinelle
> > >
> > > This patch removes unnecessary parentheses while returning a value and
> > > removes unnecessary space.
> > > Using following semantic patch:
> > >
> > > @@
> > > local idexpression id;
> > > @@
> > >
> > > - return(id);
> > > + return id;
> > >
> > > @@
> > > local idexpression id;
> > > @@
> > >
> > > -return (id) ;
> > > +return id;
> > >
> > > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.c
> > > ---
> > > Changes in v2:
> > >     -Add new semantic patch to drop spaces.
> > >
> > > --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > > +++ /tmp/cocci-output-4620-ca634c-ioctl_linux.c
> >
> > That is a _VERY_ odd diff, and obviously does not apply to the kernel
> > tree.  Did something go wrong when creating it?
>
> It looks like the output of Coccinelle.  Payal, you have to apply the diff
> that you get from Coccinelle to your kernel tree, check that it compiles,
> and then make a patch in the normal way.
>

Thank you for letting me know :)
Payal

julia
>
> >
> > Please fix up and resend.
> >
> > thanks,
> >
> > greg k-h
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20190329161253.GA32685%40kroah.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>

[-- Attachment #2: Type: text/html, Size: 3344 bytes --]