[PATCH] [Outreachy kernel] staging: greybus: align to open parenthesis

[PATCH] [Outreachy kernel] staging: greybus: align to open parenthesis

[Payal Kshirsagar]

Aligning to open parenthesis
In file drivers/staging/greybus/arche-platform.c

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/greybus/arche-platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
index 307ff51..6bdb5d9 100644
--- a/drivers/staging/greybus/arche-platform.c
+++ b/drivers/staging/greybus/arche-platform.c
@@ -170,7 +170,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
 		 */
 		if (arche_pdata->wake_detect_state == WD_STATE_BOOT_INIT) {
 			if (time_before(jiffies,
-				arche_pdata->wake_detect_start +
+					arche_pdata->wake_detect_start +
 				msecs_to_jiffies(WD_COLDBOOT_PULSE_WIDTH_MS))) {
 				arche_platform_set_wake_detect_state(arche_pdata
 							    , WD_STATE_IDLE);
-- 
2.7.4

Re: [PATCH] [Outreachy kernel] staging: greybus: align to open parenthesis

[Julia Lawall]

On Wed, 20 Mar 2019, Payal Kshirsagar wrote:

> Aligning to open parenthesis
> In file drivers/staging/greybus/arche-platform.c
>
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
>  drivers/staging/greybus/arche-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index 307ff51..6bdb5d9 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -170,7 +170,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  		 */
>  		if (arche_pdata->wake_detect_state == WD_STATE_BOOT_INIT) {
>  			if (time_before(jiffies,
> -				arche_pdata->wake_detect_start +
> +					arche_pdata->wake_detect_start +
>  				msecs_to_jiffies(WD_COLDBOOT_PULSE_WIDTH_MS))) {

You can't have the second argument of + to the left of th first argument
of +.  Pease look more carefully at the code you ar producing by these
changes and see if you really think that the resulting code looks better.

julia



>  				arche_platform_set_wake_detect_state(arche_pdata
>  							    , WD_STATE_IDLE);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1553088353-5599-1-git-send-email-payal.s.kshirsagar.98%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH] [Outreachy kernel] staging: greybus: align to open parenthesis

[Payal Kshirsagar]

[-- Attachment #1: Type: text/plain, Size: 2608 bytes --]

On Wed, 20 Mar 2019 at 19:11, Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Wed, 20 Mar 2019, Payal Kshirsagar wrote:
>
> > Aligning to open parenthesis
> > In file drivers/staging/greybus/arche-platform.c
> >
> > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > ---
> >  drivers/staging/greybus/arche-platform.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/greybus/arche-platform.c
> b/drivers/staging/greybus/arche-platform.c
> > index 307ff51..6bdb5d9 100644
> > --- a/drivers/staging/greybus/arche-platform.c
> > +++ b/drivers/staging/greybus/arche-platform.c
> > @@ -170,7 +170,7 @@ static irqreturn_t arche_platform_wd_irq(int irq,
> void *devid)
> >                */
> >               if (arche_pdata->wake_detect_state == WD_STATE_BOOT_INIT) {
> >                       if (time_before(jiffies,
> > -                             arche_pdata->wake_detect_start +
> > +                                     arche_pdata->wake_detect_start +
> >
>  msecs_to_jiffies(WD_COLDBOOT_PULSE_WIDTH_MS))) {
>
> You can't have the second argument of + to the left of th first argument
> of +.  Pease look more carefully at the code you ar producing by these
> changes and see if you really think that the resulting code looks better.
>
> julia
>
> Okay, I understood.
Thanks!
payal

>
>
> >
>  arche_platform_set_wake_detect_state(arche_pdata
> >                                                           ,
> WD_STATE_IDLE);
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/1553088353-5599-1-git-send-email-payal.s.kshirsagar.98%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.20.1903201439330.3627%40hadrien
> .
> For more options, visit https://groups.google.com/d/optout.
>

[-- Attachment #2: Type: text/html, Size: 4383 bytes --]