All of lore.kernel.org
 help / color / mirror / Atom feed
* [BUG]scsi: bnx2fc: bnx2fc_els.c: two refcount leak in function bnx2fc_initiate_seq_cleanup and bnx2fc_eh_abort
@ 2021-08-01  3:30 亿一
  0 siblings, 0 replies; only message in thread
From: 亿一 @ 2021-08-01  3:30 UTC (permalink / raw)
  To: skashyap, jhasan, GR-QLogic-Storage-Upstream; +Cc: linux-scsi

Hi,

I found there are two possible refcount leak in the bnx2fc driver in v5.14-rc3:

In bnx2fc_initiate_seq_cleanup :
946: kref_get(&orig_io_req->refcount);

this refcnt increment won't be released in:
994: cleanup_err:
995: return rc;


similar issue happens in bnx2fc_eh_abort:
1161: kref_get(&io_req->refcount);
1187: return FAILED;

Is it a refcount leak or just a valid refcount increment?
Any feedback would be appreciated, thanks~ :)


Best wishes,
Lin Yi

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-01  3:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-01  3:30 [BUG]scsi: bnx2fc: bnx2fc_els.c: two refcount leak in function bnx2fc_initiate_seq_cleanup and bnx2fc_eh_abort 亿一

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.