From: Zong Li <zong.li@sifive.com> To: Palmer Dabbelt <palmer@dabbelt.com> Cc: Rob Herring <robh+dt@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Conor Dooley <conor.dooley@microchip.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Bin Meng <bin.meng@windriver.com>, Green Wan <green.wan@sifive.com>, Vinod <vkoul@kernel.org>, dmaengine <dmaengine@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>, linux-riscv <linux-riscv@lists.infradead.org> Subject: Re: [PATCH v4 2/3] dt-bindings: Add dma-channels for pdma device node Date: Fri, 21 Jan 2022 09:57:55 +0800 [thread overview] Message-ID: <CANXhq0o_d58cx7L_cUQMUYALwBbY7DKm3agT9+LM8Lt8KYaMnQ@mail.gmail.com> (raw) In-Reply-To: <mhng-e5e649a2-96bf-4244-a29a-a75c913111a2@palmer-ri-x1c9> On Fri, Jan 21, 2022 at 2:51 AM Palmer Dabbelt <palmer@dabbelt.com> wrote: > > On Sun, 16 Jan 2022 17:35:27 PST (-0800), zong.li@sifive.com wrote: > > Add dma-channels property, then we can determine how many channels there > > by device tree, rather than statically defines it in PDMA driver > > Maybe "statically defining it" is better here? > Thanks for the correction, I would modify it in the next version. > > > > Signed-off-by: Zong Li <zong.li@sifive.com> > > --- > > .../devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > > index d32a71b975fe..3dbb8caefc17 100644 > > --- a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > > +++ b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > > @@ -34,6 +34,12 @@ properties: > > minItems: 1 > > maxItems: 8 > > > > + dma-channels: > > + description: For backwards-compatible, the default value is 4 > > Maybe "backwards-compatibility" is better here? Thanks, let me change it in the next version together. > > > + minimum: 1 > > + maximum: 4 > > + default: 4 > > + > > '#dma-cells': > > const: 1 > > > > @@ -50,6 +56,7 @@ examples: > > dma@3000000 { > > compatible = "sifive,fu540-c000-pdma"; > > IMO we should have a "sifive,pdma-1.0.0" (or whatever the versioning > scheme ended up being) here, in addition to the SOC-specific DT entry. > It's kind of odd to start extending the SOC-specific DT entry, as the > whole idea there is to let us have an out in case we find future > compatibility issues. yes, I notice that we usually have a entry with the version in other device nodes, such as "sifive,xxx0", I guess we should have a "sifive,pdma0" there, thanks for your advice, let me add it and use it in match table of pdma driver in the next version. > > > reg = <0x3000000 0x8000>; > > + dma-channels = <4>; > > interrupts = <23 24 25 26 27 28 29 30>; > > #dma-cells = <1>; > > };
WARNING: multiple messages have this Message-ID (diff)
From: Zong Li <zong.li@sifive.com> To: Palmer Dabbelt <palmer@dabbelt.com> Cc: Rob Herring <robh+dt@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Conor Dooley <conor.dooley@microchip.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Bin Meng <bin.meng@windriver.com>, Green Wan <green.wan@sifive.com>, Vinod <vkoul@kernel.org>, dmaengine <dmaengine@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>, linux-riscv <linux-riscv@lists.infradead.org> Subject: Re: [PATCH v4 2/3] dt-bindings: Add dma-channels for pdma device node Date: Fri, 21 Jan 2022 09:57:55 +0800 [thread overview] Message-ID: <CANXhq0o_d58cx7L_cUQMUYALwBbY7DKm3agT9+LM8Lt8KYaMnQ@mail.gmail.com> (raw) In-Reply-To: <mhng-e5e649a2-96bf-4244-a29a-a75c913111a2@palmer-ri-x1c9> On Fri, Jan 21, 2022 at 2:51 AM Palmer Dabbelt <palmer@dabbelt.com> wrote: > > On Sun, 16 Jan 2022 17:35:27 PST (-0800), zong.li@sifive.com wrote: > > Add dma-channels property, then we can determine how many channels there > > by device tree, rather than statically defines it in PDMA driver > > Maybe "statically defining it" is better here? > Thanks for the correction, I would modify it in the next version. > > > > Signed-off-by: Zong Li <zong.li@sifive.com> > > --- > > .../devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > > index d32a71b975fe..3dbb8caefc17 100644 > > --- a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > > +++ b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml > > @@ -34,6 +34,12 @@ properties: > > minItems: 1 > > maxItems: 8 > > > > + dma-channels: > > + description: For backwards-compatible, the default value is 4 > > Maybe "backwards-compatibility" is better here? Thanks, let me change it in the next version together. > > > + minimum: 1 > > + maximum: 4 > > + default: 4 > > + > > '#dma-cells': > > const: 1 > > > > @@ -50,6 +56,7 @@ examples: > > dma@3000000 { > > compatible = "sifive,fu540-c000-pdma"; > > IMO we should have a "sifive,pdma-1.0.0" (or whatever the versioning > scheme ended up being) here, in addition to the SOC-specific DT entry. > It's kind of odd to start extending the SOC-specific DT entry, as the > whole idea there is to let us have an out in case we find future > compatibility issues. yes, I notice that we usually have a entry with the version in other device nodes, such as "sifive,xxx0", I guess we should have a "sifive,pdma0" there, thanks for your advice, let me add it and use it in match table of pdma driver in the next version. > > > reg = <0x3000000 0x8000>; > > + dma-channels = <4>; > > interrupts = <23 24 25 26 27 28 29 30>; > > #dma-cells = <1>; > > }; _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-01-21 1:58 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-17 1:35 [PATCH v4 0/3] Determine the number of DMA channels by 'dma-channels' property Zong Li 2022-01-17 1:35 ` Zong Li 2022-01-17 1:35 ` [PATCH v4 1/3] riscv: dts: Add dma-channels property in dma node Zong Li 2022-01-17 1:35 ` Zong Li 2022-01-18 15:04 ` Conor.Dooley 2022-01-18 15:04 ` Conor.Dooley 2022-01-20 18:51 ` Palmer Dabbelt 2022-01-20 18:51 ` Palmer Dabbelt 2022-01-27 7:03 ` Vinod Koul 2022-01-27 7:03 ` Vinod Koul 2022-01-27 7:35 ` Zong Li 2022-01-27 7:35 ` Zong Li 2022-01-17 1:35 ` [PATCH v4 2/3] dt-bindings: Add dma-channels for pdma device node Zong Li 2022-01-17 1:35 ` Zong Li 2022-01-20 18:51 ` Palmer Dabbelt 2022-01-20 18:51 ` Palmer Dabbelt 2022-01-21 1:57 ` Zong Li [this message] 2022-01-21 1:57 ` Zong Li 2022-01-17 1:35 ` [PATCH v4 3/3] dmaengine: sf-pdma: Get number of channel by device tree Zong Li 2022-01-17 1:35 ` Zong Li 2022-01-20 18:51 ` Palmer Dabbelt 2022-01-20 18:51 ` Palmer Dabbelt 2022-01-21 2:21 ` Zong Li 2022-01-21 2:21 ` Zong Li 2022-01-21 8:33 ` Geert Uytterhoeven 2022-01-21 8:33 ` Geert Uytterhoeven 2022-01-21 10:29 ` Zong Li 2022-01-21 10:29 ` Zong Li 2022-01-25 5:08 ` Zong Li 2022-01-25 5:08 ` Zong Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CANXhq0o_d58cx7L_cUQMUYALwBbY7DKm3agT9+LM8Lt8KYaMnQ@mail.gmail.com \ --to=zong.li@sifive.com \ --cc=aou@eecs.berkeley.edu \ --cc=bin.meng@windriver.com \ --cc=conor.dooley@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=green.wan@sifive.com \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.