From: Zong Li <zong.li@sifive.com> To: Rob Herring <robh+dt@kernel.org> Cc: Palmer Dabbelt <palmer@dabbelt.com>, Vinod <vkoul@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Conor Dooley <conor.dooley@microchip.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Bin Meng <bin.meng@windriver.com>, Green Wan <green.wan@sifive.com>, "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" <dmaengine@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-riscv <linux-riscv@lists.infradead.org> Subject: Re: [PATCH v8 0/4] Determine the number of DMA channels by 'dma-channels' property Date: Thu, 21 Apr 2022 09:07:59 +0800 [thread overview] Message-ID: <CANXhq0rYBCQyGK-zfKdU51y03dSD9XsPwtCqg8a7xvxYV3LL+A@mail.gmail.com> (raw) In-Reply-To: <CAL_Jsq+5TbfFxD3p4ckvNw=jFweuvjQPRQfjmvPqZJga25o0pA@mail.gmail.com> On Wed, Apr 20, 2022 at 10:26 PM Rob Herring <robh+dt@kernel.org> wrote: > > On Tue, Apr 19, 2022 at 7:18 PM Palmer Dabbelt <palmer@dabbelt.com> wrote: > > > > On Mon, 11 Apr 2022 04:43:35 PDT (-0700), zong.li@sifive.com wrote: > > > On Mon, Apr 11, 2022 at 6:48 PM Vinod Koul <vkoul@kernel.org> wrote: > > >> > > >> On 11-04-22, 10:51, Zong Li wrote: > > >> > On Fri, Apr 8, 2022 at 9:13 PM Vinod Koul <vkoul@kernel.org> wrote: > > >> > > > > >> > > On 28-03-22, 17:52, Zong Li wrote: > > >> > > > The PDMA driver currently assumes there are four channels by default, it > > >> > > > might cause the error if there is actually less than four channels. > > >> > > > Change that by getting number of channel dynamically from device tree. > > >> > > > For backwards-compatible, it uses the default value (i.e. 4) when there > > >> > > > is no 'dma-channels' information in dts. > > >> > > > > >> > > Applied patch 1 & 4 to dmaengine-next, thanks > > >> > > > >> > Hi Vinod, > > >> > Thanks for your help and review. For patch 2 and 3, does it mean that > > >> > we should go through the riscv tree? > > >> > > >> Yes > > >> > > > > > > Hi Palmer, > > > Could you please help me to pick up the patch 2 and 3. Thanks :) > > > > Sorry about that, I forgot about this one. I just put them on for-next, > > there was a minor merge conflict but it looks pretty simple. > > Looks like you applied patch 1 too which Vinod already applied to the > dmaengine tree. And you changed the 1st line removing the "# " before > the SPDX tag which results in: Hi Palmer, Many thanks for helping me to pick them into riscv-tree, It seems like we need to pick patch 2 and 3 in riscv tree, instead of patch 1 and 2. :) > > make[1]: *** Deleting file > 'Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.example.dts' > Traceback (most recent call last): > File "/usr/local/bin/dt-extract-example", line 52, in <module> > binding = yaml.load(open(args.yamlfile, encoding='utf-8').read()) > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", > line 434, in load > return constructor.get_single_data() > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", > line 119, in get_single_data > node = self.composer.get_single_node() > File "_ruamel_yaml.pyx", line 718, in _ruamel_yaml.CParser.get_single_node > ruamel.yaml.composer.ComposerError: expected a single document in the stream > in "<unicode string>", line 1, column 1 > but found another document > in "<unicode string>", line 2, column 1 > make[1]: *** [Documentation/devicetree/bindings/Makefile:26: > Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.example.dts] > Error 1 > ./Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml:1:1: > [error] missing document start "---" (document-start) > > > Rob
WARNING: multiple messages have this Message-ID (diff)
From: Zong Li <zong.li@sifive.com> To: Rob Herring <robh+dt@kernel.org> Cc: Palmer Dabbelt <palmer@dabbelt.com>, Vinod <vkoul@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Conor Dooley <conor.dooley@microchip.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Bin Meng <bin.meng@windriver.com>, Green Wan <green.wan@sifive.com>, "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" <dmaengine@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-riscv <linux-riscv@lists.infradead.org> Subject: Re: [PATCH v8 0/4] Determine the number of DMA channels by 'dma-channels' property Date: Thu, 21 Apr 2022 09:07:59 +0800 [thread overview] Message-ID: <CANXhq0rYBCQyGK-zfKdU51y03dSD9XsPwtCqg8a7xvxYV3LL+A@mail.gmail.com> (raw) In-Reply-To: <CAL_Jsq+5TbfFxD3p4ckvNw=jFweuvjQPRQfjmvPqZJga25o0pA@mail.gmail.com> On Wed, Apr 20, 2022 at 10:26 PM Rob Herring <robh+dt@kernel.org> wrote: > > On Tue, Apr 19, 2022 at 7:18 PM Palmer Dabbelt <palmer@dabbelt.com> wrote: > > > > On Mon, 11 Apr 2022 04:43:35 PDT (-0700), zong.li@sifive.com wrote: > > > On Mon, Apr 11, 2022 at 6:48 PM Vinod Koul <vkoul@kernel.org> wrote: > > >> > > >> On 11-04-22, 10:51, Zong Li wrote: > > >> > On Fri, Apr 8, 2022 at 9:13 PM Vinod Koul <vkoul@kernel.org> wrote: > > >> > > > > >> > > On 28-03-22, 17:52, Zong Li wrote: > > >> > > > The PDMA driver currently assumes there are four channels by default, it > > >> > > > might cause the error if there is actually less than four channels. > > >> > > > Change that by getting number of channel dynamically from device tree. > > >> > > > For backwards-compatible, it uses the default value (i.e. 4) when there > > >> > > > is no 'dma-channels' information in dts. > > >> > > > > >> > > Applied patch 1 & 4 to dmaengine-next, thanks > > >> > > > >> > Hi Vinod, > > >> > Thanks for your help and review. For patch 2 and 3, does it mean that > > >> > we should go through the riscv tree? > > >> > > >> Yes > > >> > > > > > > Hi Palmer, > > > Could you please help me to pick up the patch 2 and 3. Thanks :) > > > > Sorry about that, I forgot about this one. I just put them on for-next, > > there was a minor merge conflict but it looks pretty simple. > > Looks like you applied patch 1 too which Vinod already applied to the > dmaengine tree. And you changed the 1st line removing the "# " before > the SPDX tag which results in: Hi Palmer, Many thanks for helping me to pick them into riscv-tree, It seems like we need to pick patch 2 and 3 in riscv tree, instead of patch 1 and 2. :) > > make[1]: *** Deleting file > 'Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.example.dts' > Traceback (most recent call last): > File "/usr/local/bin/dt-extract-example", line 52, in <module> > binding = yaml.load(open(args.yamlfile, encoding='utf-8').read()) > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", > line 434, in load > return constructor.get_single_data() > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", > line 119, in get_single_data > node = self.composer.get_single_node() > File "_ruamel_yaml.pyx", line 718, in _ruamel_yaml.CParser.get_single_node > ruamel.yaml.composer.ComposerError: expected a single document in the stream > in "<unicode string>", line 1, column 1 > but found another document > in "<unicode string>", line 2, column 1 > make[1]: *** [Documentation/devicetree/bindings/Makefile:26: > Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.example.dts] > Error 1 > ./Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml:1:1: > [error] missing document start "---" (document-start) > > > Rob _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-04-21 1:08 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-28 9:52 [PATCH v8 0/4] Determine the number of DMA channels by 'dma-channels' property Zong Li 2022-03-28 9:52 ` Zong Li 2022-03-28 9:52 ` [PATCH v8 1/4] dt-bindings: dma-engine: sifive,fu540: Add dma-channels property and modify compatible Zong Li 2022-03-28 9:52 ` [PATCH v8 1/4] dt-bindings: dma-engine: sifive, fu540: " Zong Li 2022-03-29 1:35 ` [PATCH v8 1/4] dt-bindings: dma-engine: sifive,fu540: " Bin Meng 2022-03-29 1:35 ` Bin Meng 2022-03-28 9:52 ` [PATCH v8 2/4] riscv: dts: " Zong Li 2022-03-28 9:52 ` Zong Li 2022-03-29 1:35 ` Bin Meng 2022-03-29 1:35 ` Bin Meng 2022-03-28 9:52 ` [PATCH v8 3/4] riscv: dts: rename the node name of dma Zong Li 2022-03-28 9:52 ` Zong Li 2022-03-29 1:35 ` Bin Meng 2022-03-29 1:35 ` Bin Meng 2022-03-28 9:52 ` [PATCH v8 4/4] dmaengine: sf-pdma: Get number of channel by device tree Zong Li 2022-03-28 9:52 ` Zong Li 2022-03-29 1:35 ` Bin Meng 2022-03-29 1:35 ` Bin Meng 2022-03-31 1:06 ` [PATCH v8 0/4] Determine the number of DMA channels by 'dma-channels' property Zong Li 2022-03-31 1:06 ` Zong Li 2022-03-31 3:15 ` Palmer Dabbelt 2022-03-31 3:15 ` Palmer Dabbelt 2022-03-31 5:21 ` Vinod Koul 2022-03-31 5:21 ` Vinod Koul 2022-03-31 5:54 ` Palmer Dabbelt 2022-03-31 5:54 ` Palmer Dabbelt 2022-03-31 22:42 ` Palmer Dabbelt 2022-03-31 22:42 ` Palmer Dabbelt 2022-04-01 5:50 ` Zong Li 2022-04-01 5:50 ` Zong Li 2022-04-08 8:03 ` Zong Li 2022-04-08 8:03 ` Zong Li 2022-04-08 13:13 ` Vinod Koul 2022-04-08 13:13 ` Vinod Koul 2022-04-11 2:51 ` Zong Li 2022-04-11 2:51 ` Zong Li 2022-04-11 10:48 ` Vinod Koul 2022-04-11 10:48 ` Vinod Koul 2022-04-11 11:43 ` Zong Li 2022-04-11 11:43 ` Zong Li 2022-04-20 0:18 ` Palmer Dabbelt 2022-04-20 0:18 ` Palmer Dabbelt 2022-04-20 14:25 ` Rob Herring 2022-04-20 14:25 ` Rob Herring 2022-04-21 1:07 ` Zong Li [this message] 2022-04-21 1:07 ` Zong Li 2022-04-21 2:49 ` Palmer Dabbelt 2022-04-21 2:49 ` Palmer Dabbelt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CANXhq0rYBCQyGK-zfKdU51y03dSD9XsPwtCqg8a7xvxYV3LL+A@mail.gmail.com \ --to=zong.li@sifive.com \ --cc=aou@eecs.berkeley.edu \ --cc=bin.meng@windriver.com \ --cc=conor.dooley@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=green.wan@sifive.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.