* [Buildroot] [PATCH 1/1] Adding the Scrypt key derivation library.
@ 2015-08-08 18:02 Parnell Springmeyer
2015-08-28 13:38 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Parnell Springmeyer @ 2015-08-08 18:02 UTC (permalink / raw)
To: buildroot
--
Parnell Springmeyer
parnell at digitalmentat.com | digitalmentat.com | 0xDCCF89258EAD874A
<http://pgp.mit.edu/pks/lookup?op=get&search=0xDCCF89258EAD874A>
?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150808/796da8ed/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Adding-the-Scrypt-key-derivation-library.patch
Type: text/x-patch
Size: 2231 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150808/796da8ed/attachment.bin>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] Adding the Scrypt key derivation library.
2015-08-08 18:02 [Buildroot] [PATCH 1/1] Adding the Scrypt key derivation library Parnell Springmeyer
@ 2015-08-28 13:38 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-08-28 13:38 UTC (permalink / raw)
To: buildroot
Dear Parnell Springmeyer,
Thanks for your contribution!
You should normally send patches inline (using git send-email) rather
than as an attachment. This allows to more easily review your patch by
simply replying to your e-mail.
That being said, for this first patch, I applied it to our next branch,
after doing quite a few changes:
[Thomas:
- move from "Libraries -> Crypto" to "System tools", since it only
installs one binary, scrypt, and no library.
- bump from 1.1.6 to 1.2.0
- add comment in the .hash file explaining where the hash is coming
from.
- add missing dependency on OpenSSL
- use BSD-2c as the license code, instead of BSD2
- use 'main.c' as the license file.]
I messed up a bit when committing, since I committed your original
patch, and then separately my changes. But at least this way you can
clearly see what I have changed:
http://git.buildroot.net/buildroot/commit/?h=next&id=84face61cf1dfefe864d6d47976932a32bbde9f2
http://git.buildroot.net/buildroot/commit/?h=next&id=0d83de383224c65ec250a005130b1d3cc6fd6d76
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-28 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-08 18:02 [Buildroot] [PATCH 1/1] Adding the Scrypt key derivation library Parnell Springmeyer
2015-08-28 13:38 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.