From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Mark Rutland <mark.rutland@arm.com>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Wu Hao <hao.wu@intel.com>,
Tomohiro Kusumi <kusumi.tomohiro@gmail.com>,
"Bryant G . Ly" <bryantly@linux.vnet.ibm.com>,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
"David S . Miller" <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Vinod Koul <vkoul@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
David Kershner <david.kershner@unisys.com>,
Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
Sagar Dharia <sdharia@codeaurora.org>,
Johan Hovold <johan@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Juergen Gross <jgross@suse.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
openbmc@lists.ozlabs.org, Alan Cox <alan@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jason M Biils <jason.m.bills@linux.intel.com>,
Andrew Lunn <andrew@lunn.ch>,
Stef van Os <stef.van.os@prodrive-technologies.com>,
Haiyue Wang <haiyue.wang@linux.intel.com>,
James Feist <james.feist@linux.intel.com>,
Vernon Mauery <vernon.mauery@linux.intel.com>
Subject: Re: [PATCH v10 10/12] hwmon: Add PECI cputemp driver
Date: Fri, 18 Jan 2019 20:05:06 +0100 [thread overview]
Message-ID: <CANiq72=qO0B_WfWRM0sXOE4Hz_gU=_VsijTNsqVFN2PJehOWQg@mail.gmail.com> (raw)
In-Reply-To: <8ef997aa-2971-2907-3821-e71f9e8dd53a@linux.intel.com>
Hi Jae,
On Fri, Jan 18, 2019 at 6:52 PM Jae Hyun Yoo
<jae.hyun.yoo@linux.intel.com> wrote:
>
> I'm assuming you meant:
>
> return !(temp->valid && time_before(jiffies, temp->last_updated +
> UPDATE_INTERVAL));
Yeah, or return !... || !..., whatever you feel is more comprehensible. :)
> Thanks for your review!
You're welcome! It is just nitpicking, but I thought sending the email
wouldn't hurt too much (in case you do another version of the series,
otherwise don't change it just for this! :-)
Cheers,
Miguel
next prev parent reply other threads:[~2019-01-18 19:05 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 21:41 [PATCH v10 00/12] PECI device driver introduction Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-07 21:41 ` [PATCH v10 01/12] dt-bindings: Add a document of PECI subsystem Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-14 5:34 ` Joel Stanley
2019-01-14 5:34 ` Joel Stanley
2019-01-14 5:34 ` Joel Stanley
2019-01-07 21:41 ` [PATCH v10 02/12] Documentation: ioctl: Add ioctl numbers for " Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-07 21:41 ` [PATCH v10 03/12] peci: Add support for PECI bus driver core Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-14 11:13 ` Joel Stanley
2019-01-14 11:13 ` Joel Stanley
2019-01-14 22:38 ` Jae Hyun Yoo
2019-01-22 13:20 ` Greg Kroah-Hartman
2019-01-23 21:38 ` Jae Hyun Yoo
2019-01-24 6:57 ` Greg Kroah-Hartman
2019-01-24 22:01 ` Jae Hyun Yoo
2019-01-25 7:18 ` Greg Kroah-Hartman
2019-01-25 18:51 ` Jae Hyun Yoo
2019-01-26 8:29 ` Greg Kroah-Hartman
2019-01-28 17:25 ` Jae Hyun Yoo
2019-01-07 21:41 ` [PATCH v10 04/12] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-14 5:37 ` Joel Stanley
2019-01-14 5:37 ` Joel Stanley
2019-01-07 21:41 ` [PATCH v10 05/12] ARM: dts: aspeed: peci: Add PECI node Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-14 5:45 ` Joel Stanley
2019-01-14 5:45 ` Joel Stanley
2019-01-14 22:12 ` Jae Hyun Yoo
2019-01-07 21:41 ` [PATCH v10 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-14 11:37 ` Joel Stanley
2019-01-14 11:37 ` Joel Stanley
2019-01-14 22:49 ` Jae Hyun Yoo
2019-01-15 23:14 ` Joel Stanley
2019-01-15 23:14 ` Joel Stanley
2019-01-15 23:36 ` Jae Hyun Yoo
2019-01-07 21:41 ` [PATCH v10 07/12] dt-bindings: mfd: Add a document for PECI client driver Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-14 11:39 ` Joel Stanley
2019-01-14 11:39 ` Joel Stanley
2019-01-07 21:41 ` [PATCH v10 08/12] mfd: intel-peci-client: Add " Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-14 11:42 ` Joel Stanley
2019-01-14 11:42 ` Joel Stanley
2019-01-14 11:42 ` Joel Stanley
2019-01-14 23:03 ` Jae Hyun Yoo
2019-01-14 23:03 ` Jae Hyun Yoo
2019-01-07 21:41 ` [PATCH v10 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-14 11:43 ` Joel Stanley
2019-01-14 11:43 ` Joel Stanley
2019-01-14 11:43 ` Joel Stanley
2019-01-14 22:54 ` Jae Hyun Yoo
2019-01-14 22:54 ` Jae Hyun Yoo
2019-01-07 21:41 ` [PATCH v10 10/12] hwmon: Add PECI cputemp driver Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-09 12:57 ` Miguel Ojeda
2019-01-09 12:57 ` Miguel Ojeda
2019-01-18 17:52 ` Jae Hyun Yoo
2019-01-18 19:05 ` Miguel Ojeda [this message]
2019-01-18 19:05 ` Miguel Ojeda
2019-01-18 19:15 ` Jae Hyun Yoo
2019-01-07 21:41 ` [PATCH v10 11/12] hwmon: Add PECI dimmtemp driver Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
2019-01-07 21:41 ` [PATCH v10 12/12] Add maintainers for the PECI subsystem Jae Hyun Yoo
2019-01-07 21:41 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72=qO0B_WfWRM0sXOE4Hz_gU=_VsijTNsqVFN2PJehOWQg@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bryantly@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=darrick.wong@oracle.com \
--cc=davem@davemloft.net \
--cc=david.kershner@unisys.com \
--cc=devicetree@vger.kernel.org \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=haiyue.wang@linux.intel.com \
--cc=hao.wu@intel.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=james.feist@linux.intel.com \
--cc=jason.m.bills@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=jgross@suse.com \
--cc=joel@jms.id.au \
--cc=johan@kernel.org \
--cc=kishon@ti.com \
--cc=kusumi.tomohiro@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pombredanne@nexb.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sandeen@redhat.com \
--cc=sboyd@codeaurora.org \
--cc=sdharia@codeaurora.org \
--cc=stef.van.os@prodrive-technologies.com \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vernon.mauery@linux.intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.