All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Qingsong Chen <changxian.cqs@antgroup.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, 田洪亮 <tate.thl@antgroup.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Wedson Almeida Filho" <wedsonaf@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
	"Asahi Lina" <lina@asahilina.net>,
	"Sven Van Asbroeck" <thesven73@gmail.com>,
	"Viktor Garske" <viktor@v-gar.de>, "Finn Behrens" <me@kloenk.dev>,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 2/2] samples: rust: add `SgTable` and `ScatterList` selftests
Date: Wed, 31 May 2023 12:17:13 +0200	[thread overview]
Message-ID: <CANiq72mghZMnDFcAgjxu0swMYEbpkWS5vLMpA4zThH0KbtLwxw@mail.gmail.com> (raw)
In-Reply-To: <170fa8d4-7851-cc1a-14ba-7213d0a5da0c@antgroup.com>

On Wed, May 31, 2023 at 7:35 AM Qingsong Chen
<changxian.cqs@antgroup.com> wrote:
>
> Maybe I should place those use cases in the doc ( `Examples` section)
> and remove this commit

If you think they would help readers of the docs, then that is
definitely the best approach, because they double as tests and docs at
the same time.

Cheers,
Miguel

  reply	other threads:[~2023-05-31 10:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30  6:48 [PATCH 0/2] Rust scatterlist abstractions Qingsong Chen
2023-05-30  6:48 ` [PATCH 1/2] rust: kernel: add scatterlist wrapper Qingsong Chen
2023-05-30 20:15   ` Martin Rodriguez Reboredo
2023-05-30  6:48 ` [PATCH 2/2] samples: rust: add `SgTable` and `ScatterList` selftests Qingsong Chen
2023-05-30  7:31   ` Greg KH
2023-05-30 18:33     ` Boqun Feng
2023-05-31  5:30       ` Qingsong Chen
2023-05-31 10:17         ` Miguel Ojeda [this message]
2023-05-30 14:21   ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANiq72mghZMnDFcAgjxu0swMYEbpkWS5vLMpA4zThH0KbtLwxw@mail.gmail.com \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=changxian.cqs@antgroup.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=lina@asahilina.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@kloenk.dev \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tate.thl@antgroup.com \
    --cc=thesven73@gmail.com \
    --cc=viktor@v-gar.de \
    --cc=wedsonaf@gmail.com \
    --cc=yakoyoku@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.